Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Mar 14, 2024

Proposed changes

This PR involves refactoring the projection in the join node. It is used for testing the compatibility between higher version BE and lower version FE.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@Mryange
Copy link
Contributor Author

Mryange commented Mar 14, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.99% (8573/24500)
Line Coverage: 26.73% (69458/259865)
Region Coverage: 26.00% (36073/138727)
Branch Coverage: 22.96% (18422/80240)
Coverage Report: http://coverage.selectdb-in.cc/coverage/148d8bd7b37600ea8eec8bbde13325713fc5e1a8_148d8bd7b37600ea8eec8bbde13325713fc5e1a8/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38442 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 148d8bd7b37600ea8eec8bbde13325713fc5e1a8, data reload: false

------ Round 1 ----------------------------------
q1	17699	4172	4115	4115
q2	2017	154	162	154
q3	10583	1107	894	894
q4	6744	697	730	697
q5	7495	2754	2755	2754
q6	186	123	123	123
q7	1143	833	812	812
q8	9371	2029	2016	2016
q9	7232	6430	6431	6430
q10	8535	3527	3641	3527
q11	435	229	228	228
q12	756	304	302	302
q13	18091	2870	2850	2850
q14	268	237	253	237
q15	491	441	451	441
q16	507	391	383	383
q17	963	533	528	528
q18	7105	6481	6494	6481
q19	1702	1465	1415	1415
q20	539	288	273	273
q21	6410	3496	3555	3496
q22	363	286	286	286
Total cold run time: 108635 ms
Total hot run time: 38442 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4142	4107	4104	4104
q2	317	226	221	221
q3	2951	2824	2843	2824
q4	1840	1579	1543	1543
q5	5240	5243	5254	5243
q6	197	114	118	114
q7	2224	1855	1893	1855
q8	3162	3279	3275	3275
q9	8562	8576	8530	8530
q10	3713	3661	3672	3661
q11	539	425	447	425
q12	723	548	545	545
q13	16952	2872	2864	2864
q14	279	254	255	254
q15	487	438	447	438
q16	450	419	399	399
q17	1742	1485	1454	1454
q18	7536	7219	7105	7105
q19	1575	1560	1511	1511
q20	1916	1700	1694	1694
q21	4861	4705	4651	4651
q22	527	458	423	423
Total cold run time: 69935 ms
Total hot run time: 53133 ms

@Mryange
Copy link
Contributor Author

Mryange commented Mar 15, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38480 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 148d8bd7b37600ea8eec8bbde13325713fc5e1a8, data reload: false

------ Round 1 ----------------------------------
q1	17612	4349	4237	4237
q2	2020	145	142	142
q3	10614	1062	902	902
q4	6733	731	696	696
q5	7460	2629	2606	2606
q6	184	125	122	122
q7	1213	817	806	806
q8	9333	2053	2051	2051
q9	7272	6461	6445	6445
q10	8531	3471	3641	3471
q11	427	235	218	218
q12	1271	291	293	291
q13	18136	2858	2875	2858
q14	287	249	246	246
q15	501	460	451	451
q16	523	388	381	381
q17	952	539	549	539
q18	7159	6507	6461	6461
q19	1723	1409	1408	1408
q20	544	294	280	280
q21	6251	3570	3655	3570
q22	351	321	299	299
Total cold run time: 109097 ms
Total hot run time: 38480 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4121	4127	4055	4055
q2	319	225	221	221
q3	2935	2852	2847	2847
q4	1853	1583	1560	1560
q5	5225	5230	5215	5215
q6	196	120	122	120
q7	2235	1838	1805	1805
q8	3156	3296	3276	3276
q9	8536	8534	8531	8531
q10	3665	3681	3650	3650
q11	544	446	432	432
q12	716	566	547	547
q13	16909	2825	2849	2825
q14	272	247	248	247
q15	477	449	444	444
q16	473	409	410	409
q17	1724	1482	1451	1451
q18	7640	7091	7272	7091
q19	1638	1562	1561	1561
q20	1890	1698	1726	1698
q21	4976	4619	4750	4619
q22	556	427	443	427
Total cold run time: 70056 ms
Total hot run time: 53031 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.94% (8573/24536)
Line Coverage: 26.64% (69494/260872)
Region Coverage: 25.92% (36096/139238)
Branch Coverage: 22.86% (18432/80620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/148d8bd7b37600ea8eec8bbde13325713fc5e1a8_148d8bd7b37600ea8eec8bbde13325713fc5e1a8/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Mar 15, 2024

run p0

@Mryange
Copy link
Contributor Author

Mryange commented Mar 18, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.24% (8701/24689)
Line Coverage: 27.07% (71188/263002)
Region Coverage: 26.31% (36919/140320)
Branch Coverage: 23.23% (18888/81308)
Coverage Report: http://coverage.selectdb-in.cc/coverage/148d8bd7b37600ea8eec8bbde13325713fc5e1a8_148d8bd7b37600ea8eec8bbde13325713fc5e1a8/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Mar 19, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.24% (8701/24689)
Line Coverage: 27.06% (71178/263001)
Region Coverage: 26.31% (36914/140324)
Branch Coverage: 23.22% (18882/81312)
Coverage Report: http://coverage.selectdb-in.cc/coverage/148d8bd7b37600ea8eec8bbde13325713fc5e1a8_148d8bd7b37600ea8eec8bbde13325713fc5e1a8/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 21, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Mryange Mryange closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants