[fix](analysis) sorted partition when do sample analyze #32185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
|
Thank you for your contribution to Apache Doris. |
freemandealer
changed the title
Contributor
Author
|
run buildall |
morrySnow
reviewed
Mar 18, 2024
Comment on lines
+259
to
+261
| List<Partition> sortedPartitions = olapTable.getPartitions().stream().sorted( | ||
| Comparator.comparing(Partition::getName)).collect(Collectors.toList()); | ||
| for (Partition p : sortedPartitions) { |
Contributor
There was a problem hiding this comment.
do we need update inject stats of nereids tpcds shape test? @Jibing-Li
Contributor
There was a problem hiding this comment.
Yes, we need to regenerate tpcds stats.
Contributor
There was a problem hiding this comment.
Nereids tpcds shape test stats was collected using full analyze, so we don't need to update it.
gavinchou
approved these changes
Mar 18, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run performance |
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
Jibing-Li
approved these changes
Mar 20, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Mar 20, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 21, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...