Skip to content

[fix](analysis) sorted partition when do sample analyze #32185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 3 commits into from
Mar 20, 2024
Merged

[fix](analysis) sorted partition when do sample analyze #32185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8312e54
sort partition when do sample analyze
freemandealer Mar 13, 2024
118777f
Merge branch 'master' into sort-partition
freemandealer Mar 18, 2024
7020bcd
Merge branch 'master' into sort-partition
freemandealer Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -255,7 +256,9 @@ protected Pair<List<Long>, Long> calcActualSampleTablets(boolean forPartitionCol
List<Long> sampleTabletIds = new ArrayList<>();
long actualSampledRowCount = 0;
boolean enough = false;
for (Partition p : olapTable.getPartitions()) {
List<Partition> sortedPartitions = olapTable.getPartitions().stream().sorted(
Comparator.comparing(Partition::getName)).collect(Collectors.toList());
for (Partition p : sortedPartitions) {
Comment on lines +259 to +261
Copy link
Contributor

@morrySnow morrySnow Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need update inject stats of nereids tpcds shape test? @Jibing-Li

Copy link
Contributor

@Jibing-Li Jibing-Li Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to regenerate tpcds stats.

Copy link
Contributor

@Jibing-Li Jibing-Li Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nereids tpcds shape test stats was collected using full analyze, so we don't need to update it.

MaterializedIndex materializedIndex = info.indexId == -1 ? p.getBaseIndex() : p.getIndex(info.indexId);
if (materializedIndex == null) {
continue;
Expand Down