[fix](jdbc catalog) fix jdbc-connector coredump as get env return nullptr #32217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
yiguolei
reviewed
Mar 14, 2024
be/src/vec/exec/vjdbc_connector.cpp
Outdated
| JNIEnv* env; | ||
| RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env)); | ||
| JNIEnv* env = nullptr; | ||
| Status status = JniUtil::GetJNIEnv(&env); |
Contributor
There was a problem hiding this comment.
There are many APIs that call GetJNIEnv, and use RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
I think we should add check in GetJNIEnv if the result == nullptr, should return an error status.
TPC-H: Total hot run time: 38373 ms |
github-actions
bot
removed
the
approved
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
approved these changes
Mar 14, 2024
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
TPC-H: Total hot run time: 38562 ms |
|
TeamCity be ut coverage result: |
morningman
approved these changes
Mar 14, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 14, 2024
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Mar 15, 2024
zy-kkk
added a commit
that referenced
this pull request
Mar 17, 2024
morningman
added a commit
that referenced
this pull request
Mar 29, 2024
This PR #32217 find a problem that may failed to get jni env. And it did a work around to avoid BE crash. This PR followup this issue, to avoid BE crash when doing `close()` of JniConnector if failed to get jni env. The `close()` method will return error when: 1. Failed to get jni env 2. Failed to release jni resource. This PR will ignore the first error, and still log fatal for second error
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 29, 2024
This PR apache#32217 find a problem that may failed to get jni env. And it did a work around to avoid BE crash. This PR followup this issue, to avoid BE crash when doing `close()` of JniConnector if failed to get jni env. The `close()` method will return error when: 1. Failed to get jni env 2. Failed to release jni resource. This PR will ignore the first error, and still log fatal for second error
yiguolei
pushed a commit
that referenced
this pull request
Apr 1, 2024
This PR #32217 find a problem that may failed to get jni env. And it did a work around to avoid BE crash. This PR followup this issue, to avoid BE crash when doing `close()` of JniConnector if failed to get jni env. The `close()` method will return error when: 1. Failed to get jni env 2. Failed to release jni resource. This PR will ignore the first error, and still log fatal for second error
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 7, 2024
This PR apache#32217 find a problem that may failed to get jni env. And it did a work around to avoid BE crash. This PR followup this issue, to avoid BE crash when doing `close()` of JniConnector if failed to get jni env. The `close()` method will return error when: 1. Failed to get jni env 2. Failed to release jni resource. This PR will ignore the first error, and still log fatal for second error
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...