Skip to content

[pick][fix](jdbc catalog) fix jdbc-connector coredump as get env return nullptr #32304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Mar 17, 2024
Merged

[pick][fix](jdbc catalog) fix jdbc-connector coredump as get env return nullptr #32304

zy-kkk merged 1 commit into from
Mar 17, 2024

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 15, 2024

Proposed changes

Issue Number: close #xxx

pick (#32217)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 15, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (8039/21263)
Line Coverage: 29.48% (65603/222532)
Region Coverage: 28.95% (33758/116605)
Branch Coverage: 24.79% (17325/69878)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c96dfe42d27acf53bfc9d0b8579717f54e6df089_c96dfe42d27acf53bfc9d0b8579717f54e6df089/report/index.html

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

TPC-H: Total hot run time: 50219 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c96dfe42d27acf53bfc9d0b8579717f54e6df089, data reload: false

------ Round 1 ----------------------------------
q1	17630	4439	4406	4406
q2	2114	148	146	146
q3	10312	1913	1939	1913
q4	10318	1267	1326	1267
q5	8531	3967	4032	3967
q6	231	124	122	122
q7	2049	1595	1590	1590
q8	9519	2751	2750	2750
q9	14106	10553	10472	10472
q10	8625	3559	3503	3503
q11	411	249	242	242
q12	472	299	305	299
q13	18318	4006	4027	4006
q14	346	314	328	314
q15	496	458	465	458
q16	674	591	585	585
q17	1150	942	918	918
q18	7208	6921	6931	6921
q19	1710	1571	1536	1536
q20	530	288	325	288
q21	4472	4190	4115	4115
q22	504	418	401	401
Total cold run time: 119726 ms
Total hot run time: 50219 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4320	4286	4340	4286
q2	314	227	226	226
q3	4191	4163	4148	4148
q4	2767	2766	2762	2762
q5	7299	7192	7227	7192
q6	240	119	119	119
q7	3222	2842	2901	2842
q8	4398	4491	4586	4491
q9	17166	16978	16849	16849
q10	4204	4278	4307	4278
q11	751	679	706	679
q12	1016	857	841	841
q13	6713	3763	3730	3730
q14	453	417	424	417
q15	491	446	459	446
q16	754	693	702	693
q17	3822	3833	3870	3833
q18	8876	8679	8852	8679
q19	1752	1733	1679	1679
q20	2378	2153	2142	2142
q21	8628	8450	8463	8450
q22	1067	1009	997	997
Total cold run time: 84822 ms
Total hot run time: 79779 ms

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

TPC-DS: Total hot run time: 203374 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c96dfe42d27acf53bfc9d0b8579717f54e6df089, data reload: false

query1	918	395	380	380
query2	6539	2240	2021	2021
query3	6912	201	191	191
query4	21216	17870	17950	17870
query5	19705	6556	6565	6556
query6	309	214	220	214
query7	4197	298	300	298
query8	244	270	230	230
query9	3140	2686	2610	2610
query10	397	290	306	290
query11	11205	10726	10754	10726
query12	120	72	74	72
query13	5591	670	639	639
query14	17678	13724	13529	13529
query15	344	222	233	222
query16	6422	264	266	264
query17	1709	1454	870	870
query18	2324	416	407	407
query19	208	146	153	146
query20	82	76	75	75
query21	189	94	97	94
query22	5287	5013	5022	5013
query23	32456	31841	32059	31841
query24	6934	6575	6475	6475
query25	509	416	418	416
query26	518	163	158	158
query27	1873	300	290	290
query28	6034	2222	2199	2199
query29	3037	2791	2848	2791
query30	248	161	160	160
query31	911	772	715	715
query32	70	58	60	58
query33	392	245	254	245
query34	842	471	482	471
query35	1106	906	932	906
query36	1547	1335	1573	1335
query37	87	59	57	57
query38	3050	2941	2908	2908
query39	1360	1313	1308	1308
query40	200	95	94	94
query41	34	31	31	31
query42	92	78	84	78
query43	675	645	637	637
query44	1103	713	708	708
query45	239	229	230	229
query46	1244	986	984	984
query47	1839	1688	1757	1688
query48	989	698	681	681
query49	618	368	377	368
query50	862	630	603	603
query51	4753	4624	4679	4624
query52	81	84	77	77
query53	449	313	310	310
query54	2652	2444	2429	2429
query55	77	79	81	79
query56	198	209	205	205
query57	1188	1118	1131	1118
query58	210	197	180	180
query59	3369	3361	3141	3141
query60	202	179	199	179
query61	79	78	79	78
query62	830	478	519	478
query63	470	335	345	335
query64	2514	1518	1328	1328
query65	3640	3546	3545	3545
query66	798	376	360	360
query67	17395	18083	15341	15341
query68	8572	644	649	644
query69	582	322	348	322
query70	1984	1561	1650	1561
query71	387	304	309	304
query72	6435	3424	3404	3404
query73	727	323	316	316
query74	6237	5831	5874	5831
query75	5068	3732	3680	3680
query76	5132	1150	1181	1150
query77	701	242	244	242
query78	12490	13409	13195	13195
query79	11364	629	664	629
query80	723	397	382	382
query81	501	226	229	226
query82	249	97	96	96
query83	170	130	130	130
query84	255	68	66	66
query85	702	283	272	272
query86	381	377	382	377
query87	3235	3025	2993	2993
query88	5017	2307	2310	2307
query89	366	279	280	279
query90	2353	209	194	194
query91	153	115	126	115
query92	53	52	55	52
query93	2986	601	569	569
query94	1036	208	203	203
query95	1109	1052	1050	1050
query96	647	332	320	320
query97	6465	6408	6411	6408
query98	183	189	168	168
query99	2828	1037	931	931
Total cold run time: 311601 ms
Total hot run time: 203374 ms

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

ClickBench: Total hot run time: 30.25 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c96dfe42d27acf53bfc9d0b8579717f54e6df089, data reload: false

query1	0.02	0.02	0.02
query2	0.06	0.03	0.02
query3	0.24	0.05	0.04
query4	1.82	0.06	0.07
query5	0.52	0.52	0.52
query6	1.25	0.62	0.62
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.49	0.48	0.48
query10	0.53	0.53	0.53
query11	0.11	0.08	0.09
query12	0.11	0.09	0.09
query13	0.62	0.61	0.60
query14	0.78	0.80	0.77
query15	0.77	0.76	0.76
query16	0.36	0.37	0.37
query17	1.01	0.97	0.99
query18	0.21	0.25	0.26
query19	1.89	1.83	1.86
query20	0.01	0.01	0.01
query21	15.46	0.57	0.56
query22	2.12	2.10	1.66
query23	17.16	0.93	0.86
query24	4.97	3.53	0.59
query25	0.43	0.07	0.06
query26	0.76	0.16	0.16
query27	0.04	0.03	0.04
query28	6.10	0.74	0.71
query29	12.63	2.33	2.31
query30	0.62	0.54	0.51
query31	2.83	0.38	0.37
query32	3.42	0.50	0.49
query33	3.07	3.07	3.03
query34	15.28	4.83	4.78
query35	4.84	4.86	4.84
query36	1.05	1.02	1.00
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.13	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.01
query43	0.03	0.01	0.02
Total cold run time: 102.03 s
Total hot run time: 30.25 s

@doris-robot
Copy link

doris-robot commented Mar 15, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit c96dfe42d27acf53bfc9d0b8579717f54e6df089 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       20.3 seconds inserted 10000000 Rows, about 492K ops/s

@zy-kkk zy-kkk merged commit 131fa12 into apache:branch-2.0 Mar 17, 2024
@zy-kkk zy-kkk deleted the jni_null_fix branch March 17, 2024 09:51
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zy-kkk
[fix](jdbc catalog) fix jdbc-connector coredump as get env return nul…
46ea4b0 
…lptr (apache#32217) (apache#32304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zy-kkk @doris-robot