[fix](datetime) fix datetime rounding on BE (#32075) #32359

zhiqiang-hhhh · 2024-03-18T02:37:16Z

pick #32075

doris-robot · 2024-03-18T02:37:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

zhiqiang-hhhh · 2024-03-18T02:37:29Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-18T02:44:18Z

be/test/vec/data_types/datetime_round_test.cpp

+// specific language governing permissions and limitations
+// under the License.
+
+#include <gen_cpp/Exprs_types.h>


warning: 'gen_cpp/Exprs_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/Exprs_types.h> ^

github-actions · 2024-03-18T02:44:18Z

be/test/vec/data_types/from_string_test.cpp

@@ -17,6 +17,7 @@

 #include "gtest/gtest_pred_impl.h"


warning: 'gtest/gtest_pred_impl.h' file not found [clang-diagnostic-error]

#include "gtest/gtest_pred_impl.h" ^

doris-robot · 2024-03-18T03:01:23Z

TPC-H: Total hot run time: 50416 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f71d073f0aaaf6f3324461998bf0750fa536a610, data reload: false

------ Round 1 ----------------------------------
q1	17618	4473	4429	4429
q2	2056	158	152	152
q3	10266	1944	1899	1899
q4	10198	1282	1318	1282
q5	8468	4074	4102	4074
q6	232	124	126	124
q7	2067	1623	1634	1623
q8	9262	2776	2742	2742
q9	11147	10541	10700	10541
q10	8663	3554	3519	3519
q11	416	243	247	243
q12	464	292	306	292
q13	18348	3979	4055	3979
q14	344	323	323	323
q15	502	464	460	460
q16	691	591	584	584
q17	1164	954	969	954
q18	7281	6953	6827	6827
q19	1666	1552	1545	1545
q20	542	314	311	311
q21	4500	4129	4130	4129
q22	507	384	390	384
Total cold run time: 116402 ms
Total hot run time: 50416 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4346	4355	4342	4342
q2	318	223	222	222
q3	4203	4171	4147	4147
q4	2760	2762	2760	2760
q5	7430	7566	7310	7310
q6	235	120	118	118
q7	3238	2874	2895	2874
q8	4375	4429	4538	4429
q9	17775	17370	17352	17352
q10	4239	4295	4259	4259
q11	741	694	695	694
q12	1014	848	834	834
q13	6704	3743	3747	3743
q14	461	431	417	417
q15	510	448	450	448
q16	758	711	729	711
q17	3807	3834	3846	3834
q18	8845	8784	8975	8784
q19	1717	1703	1653	1653
q20	2395	2132	2117	2117
q21	8445	8531	8509	8509
q22	1030	969	966	966
Total cold run time: 85346 ms
Total hot run time: 80523 ms

doris-robot · 2024-03-18T03:12:07Z

TeamCity be ut coverage result:
Function Coverage: 37.81% (8041/21266)
Line Coverage: 29.49% (65638/222575)
Region Coverage: 28.95% (33769/116629)
Branch Coverage: 24.80% (17333/69888)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f71d073f0aaaf6f3324461998bf0750fa536a610_f71d073f0aaaf6f3324461998bf0750fa536a610/report/index.html

doris-robot · 2024-03-18T03:14:02Z

TPC-DS: Total hot run time: 201997 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f71d073f0aaaf6f3324461998bf0750fa536a610, data reload: false

query1	937	394	385	385
query2	6513	2369	2184	2184
query3	6916	205	200	200
query4	20648	17904	18038	17904
query5	19704	6586	6475	6475
query6	291	210	215	210
query7	4161	302	295	295
query8	262	258	238	238
query9	3154	2711	2649	2649
query10	419	297	305	297
query11	11314	10834	10818	10818
query12	120	78	71	71
query13	5575	638	637	637
query14	17690	13571	13227	13227
query15	355	235	239	235
query16	6450	265	266	265
query17	1765	1462	865	865
query18	2317	425	407	407
query19	203	149	143	143
query20	76	78	75	75
query21	189	89	90	89
query22	5281	5055	5047	5047
query23	32502	31820	31992	31820
query24	7036	6505	6440	6440
query25	525	441	426	426
query26	526	162	157	157
query27	1894	297	287	287
query28	6130	2242	2207	2207
query29	2802	2784	2676	2676
query30	241	160	162	160
query31	885	733	738	733
query32	64	55	56	55
query33	395	245	271	245
query34	838	463	472	463
query35	1144	968	923	923
query36	1495	1537	1631	1537
query37	87	60	63	60
query38	3080	2970	2916	2916
query39	1380	1303	1324	1303
query40	204	98	94	94
query41	35	33	33	33
query42	80	83	85	83
query43	595	568	634	568
query44	1133	714	706	706
query45	242	232	226	226
query46	1248	986	970	970
query47	2112	1795	1757	1757
query48	964	674	649	649
query49	611	373	361	361
query50	860	598	563	563
query51	4777	4663	4622	4622
query52	88	68	81	68
query53	442	315	306	306
query54	2654	2499	2486	2486
query55	86	87	79	79
query56	198	197	188	188
query57	1258	1073	1082	1073
query58	213	209	196	196
query59	3392	3399	3016	3016
query60	207	192	193	192
query61	83	81	92	81
query62	862	447	441	441
query63	474	332	331	331
query64	2527	1464	1460	1460
query65	3702	3550	3564	3550
query66	788	371	369	369
query67	18157	15995	15482	15482
query68	8238	653	663	653
query69	562	361	337	337
query70	2018	1691	2001	1691
query71	393	311	306	306
query72	6547	3451	3398	3398
query73	731	325	316	316
query74	6348	5939	5937	5937
query75	4602	3728	3664	3664
query76	4659	1165	1200	1165
query77	588	249	250	249
query78	12776	11534	11720	11534
query79	9096	624	655	624
query80	1353	400	386	386
query81	495	239	228	228
query82	1719	98	92	92
query83	178	132	142	132
query84	270	70	68	68
query85	918	288	277	277
query86	406	382	380	380
query87	3246	3018	3017	3017
query88	5214	2313	2325	2313
query89	383	282	274	274
query90	1891	206	202	202
query91	146	117	117	117
query92	55	53	48	48
query93	5612	586	548	548
query94	782	205	204	204
query95	1091	1049	1044	1044
query96	647	325	321	321
query97	6474	6332	6445	6332
query98	176	180	177	177
query99	2990	906	889	889
Total cold run time: 313960 ms
Total hot run time: 201997 ms

doris-robot · 2024-03-18T03:19:27Z

ClickBench: Total hot run time: 30.54 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f71d073f0aaaf6f3324461998bf0750fa536a610, data reload: false

query1	0.02	0.03	0.02
query2	0.06	0.02	0.02
query3	0.23	0.05	0.05
query4	1.83	0.08	0.09
query5	0.53	0.53	0.52
query6	1.30	0.62	0.62
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.53	0.49	0.48
query10	0.53	0.52	0.53
query11	0.12	0.08	0.09
query12	0.11	0.09	0.10
query13	0.63	0.62	0.61
query14	0.78	0.80	0.78
query15	0.80	0.74	0.78
query16	0.37	0.38	0.36
query17	1.01	1.00	1.00
query18	0.20	0.26	0.27
query19	1.94	1.82	1.82
query20	0.01	0.01	0.01
query21	15.49	0.55	0.56
query22	1.72	2.19	1.31
query23	17.22	1.06	0.95
query24	3.17	4.53	1.13
query25	0.38	0.09	0.05
query26	0.84	0.15	0.17
query27	0.05	0.03	0.04
query28	6.38	0.74	0.71
query29	12.64	2.32	2.18
query30	0.61	0.53	0.55
query31	2.84	0.39	0.39
query32	3.43	0.50	0.49
query33	3.06	3.07	3.08
query34	15.26	4.83	4.82
query35	4.89	4.86	4.82
query36	1.13	1.02	1.02
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.01	0.02	0.02
query40	0.16	0.14	0.14
query41	0.06	0.01	0.02
query42	0.02	0.01	0.01
query43	0.02	0.02	0.01
Total cold run time: 100.51 s
Total hot run time: 30.54 s

doris-robot · 2024-03-18T03:22:39Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit f71d073f0aaaf6f3324461998bf0750fa536a610 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       20.8 seconds inserted 10000000 Rows, about 480K ops/s

zhiqiang-hhhh · 2024-03-19T04:11:50Z

merge blocked for waiting #27965 merge to 2.0

…to_upstream_branch-2.0

…ng-hhhh/doris into pick_32075_to_upstream_branch-2.0

zhiqiang-hhhh · 2024-03-21T06:01:01Z

run buildall

zhiqiang-hhhh · 2024-03-21T06:06:55Z

run buildall

doris-robot · 2024-03-21T07:08:30Z

TeamCity be ut coverage result:
Function Coverage: 37.82% (8046/21275)
Line Coverage: 29.48% (65675/222813)
Region Coverage: 28.96% (33807/116736)
Branch Coverage: 24.80% (17350/69960)
Coverage Report: http://coverage.selectdb-in.cc/coverage/02ee070b3001e2a2a41e85af0ed3f13ab35b724a_02ee070b3001e2a2a41e85af0ed3f13ab35b724a/report/index.html

)

[fix](datetime) fix datetime rounding on BE (apache#32075)

f71d073

github-actions bot reviewed Mar 18, 2024

View reviewed changes

zhiqiang-hhhh added 4 commits March 21, 2024 13:54

Merge branch 'branch-2.0' into pick_32075_to_upstream_branch-2.0

6b74778

FORMAT

97d731b

Merge branch 'branch-2.0' of github.com:apache/doris into pick_32075_…

8fa74ef

…to_upstream_branch-2.0

Merge branch 'pick_32075_to_upstream_branch-2.0' of github.com:zhiqia…

6acc8b9

…ng-hhhh/doris into pick_32075_to_upstream_branch-2.0

Merge branch 'branch-2.0' into pick_32075_to_upstream_branch-2.0

02ee070

xiaokang merged commit eb2834a into apache:branch-2.0 Mar 21, 2024

zhiqiang-hhhh deleted the pick_32075_to_upstream_branch-2.0 branch March 21, 2024 11:18

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024

[fix](datetime) fix datetime rounding on BE (apache#32075) (apache#32359

75c9e9e

)

[fix](datetime) fix datetime rounding on BE (#32075) #32359

[fix](datetime) fix datetime rounding on BE (#32075) #32359

Uh oh!

Conversation

zhiqiang-hhhh commented Mar 18, 2024

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

zhiqiang-hhhh commented Mar 18, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

doris-robot commented Mar 18, 2024

Uh oh!

zhiqiang-hhhh commented Mar 19, 2024

Uh oh!

zhiqiang-hhhh commented Mar 21, 2024

Uh oh!

zhiqiang-hhhh commented Mar 21, 2024

Uh oh!

doris-robot commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants