Skip to content

[FIX](serde)fix datetimev2 serde parse from string with scale #27965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Dec 5, 2023
Merged

[FIX](serde)fix datetimev2 serde parse from string with scale #27965

dataroaring merged 3 commits into from
Dec 5, 2023

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Dec 4, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Dec 4, 2023

run buildall

dataroaring
dataroaring previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 4, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.32 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17164142029 Bytes

@amorynan
Copy link
Contributor Author

amorynan commented Dec 5, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb
zclllyybb approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 5, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.67 seconds
stream load tsv: 565 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.4 seconds inserted 10000000 Rows, about 352K ops/s
storage size: 17164126787 Bytes

@dataroaring dataroaring merged commit 79f6f85 into apache:master Dec 5, 2023
@doris-robot
Copy link

doris-robot commented Dec 5, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 28dc7c8adb95a1975b88126c8faf67daa34058fc, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4907	4700	4700	4700
q2	374	147	160	147
q3	1505	1306	1290	1290
q4	1146	972	970	970
q5	3273	3240	3227	3227
q6	258	128	128	128
q7	1042	499	513	499
q8	2258	2239	2242	2239
q9	6877	6879	6886	6879
q10	3254	3352	3322	3322
q11	341	206	215	206
q12	362	209	214	209
q13	4653	3887	3814	3814
q14	243	212	224	212
q15	609	539	551	539
q16	452	396	402	396
q17	1034	645	579	579
q18	7799	7374	7388	7374
q19	1567	1551	1543	1543
q20	548	347	338	338
q21	3421	2934	2984	2934
q22	380	306	311	306
Total cold run time: 46303 ms
Total hot run time: 41851 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4628	4640	4583	4583
q2	312	199	223	199
q3	3743	3724	3722	3722
q4	2551	2530	2538	2530
q5	6120	6127	6143	6127
q6	243	122	123	122
q7	2551	1948	1919	1919
q8	3745	3756	3723	3723
q9	9398	9327	9289	9289
q10	4031	4125	4122	4122
q11	594	488	475	475
q12	816	629	641	629
q13	4385	3633	3646	3633
q14	282	256	253	253
q15	585	533	534	533
q16	542	483	472	472
q17	2019	1950	1987	1950
q18	9249	8746	9026	8746
q19	1744	1754	1753	1753
q20	2311	1978	1962	1962
q21	7152	6792	6760	6760
q22	694	562	591	562
Total cold run time: 67695 ms
Total hot run time: 64064 ms

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
[FIX](serde)fix datetimev2 serde parse from string with scale (apache…
1582eb4 
…#27965)
@zhiqiang-hhhh
Copy link
Contributor

zhiqiang-hhhh commented Mar 19, 2024

This pr should be merge to branch-2.0

@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Mar 19, 2024
Merged
zhiqiang-hhhh pushed a commit to zhiqiang-hhhh/doris that referenced this pull request Mar 19, 2024
@zhiqiang-hhhh
[FIX](serde)fix datetimev2 serde parse from string with scale (apache…
04935bb 
…#27965)
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Mar 19, 2024
Closed
@amorynan amorynan mentioned this pull request Mar 20, 2024
Merged
@xiaokang xiaokang mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged kind/behavior-changed p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@amorynan @doris-robot @zhiqiang-hhhh @zclllyybb @dataroaring @xiaokang @yiguolei