-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[FIX](serde )pick 27965 for decimalv2 #32533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run p0 |
| return Status::InvalidDataFormat("parse date fail, string: '{}'", | ||
| !read_datetime_v2_text_impl<UInt64>(val, rb, scale)) { | ||
| return Status::InvalidArgument("parse date fail, string: '{}'", | ||
| std::string(rb.position(), rb.count()).c_str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not pick related regression tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the out file is generate from master which round behavior is not compatible for 2.0
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
* fix scale * fixed
Proposed changes
fix datetimev2 serde parse from string with scale
pick: #27965
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...