Skip to content

Conversation

@amorynan
Copy link
Contributor

Proposed changes

fix datetimev2 serde parse from string with scale
pick: #27965
Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8041/21268)
Line Coverage: 29.47% (65620/222675)
Region Coverage: 28.95% (33779/116687)
Branch Coverage: 24.79% (17336/69944)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b9f8377bb68d15bda8f4a750ce1d4234d59bd389_b9f8377bb68d15bda8f4a750ce1d4234d59bd389/report/index.html

@amorynan
Copy link
Contributor Author

run p0

return Status::InvalidDataFormat("parse date fail, string: '{}'",
!read_datetime_v2_text_impl<UInt64>(val, rb, scale)) {
return Status::InvalidArgument("parse date fail, string: '{}'",
std::string(rb.position(), rb.count()).c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not pick related regression tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the out file is generate from master which round behavior is not compatible for 2.0

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (8043/21269)
Line Coverage: 29.47% (65634/222678)
Region Coverage: 28.95% (33786/116700)
Branch Coverage: 24.79% (17338/69946)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c941ab4b4d3299dd2c04f7596077dddc3b218c01_c941ab4b4d3299dd2c04f7596077dddc3b218c01/report/index.html

@yiguolei yiguolei merged commit 725f07f into apache:branch-2.0 Mar 21, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants