[Fix](Nereids) ntile function should check argument #32994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37354 ms |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37852 ms |
TPC-DS: Total hot run time: 182310 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38079 ms |
TPC-DS: Total hot run time: 182268 ms |
ClickBench: Total hot run time: 30.15 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38326 ms |
TPC-DS: Total hot run time: 181949 ms |
ClickBench: Total hot run time: 30.91 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
reviewed
Apr 1, 2024
| @Override | ||
| public void checkLegalityBeforeTypeCoercion() { | ||
| DataType type = getBuckets().getDataType(); | ||
| if (!type.isNumericType()) { |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38944 ms |
TPC-DS: Total hot run time: 181701 ms |
ClickBench: Total hot run time: 29.7 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Apr 2, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Apr 2, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 10, 2024
Problem: when ntile using 0 as parameter, be would core because no checking of parameter Solved: check parameter in fe analyze
yiguolei
pushed a commit
that referenced
this pull request
Apr 10, 2024
Problem: when ntile using 0 as parameter, be would core because no checking of parameter Solved: check parameter in fe analyze
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Apr 18, 2024
Problem: when ntile using 0 as parameter, be would core because no checking of parameter Solved: check parameter in fe analyze
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
May 10, 2024
Problem: when ntile using 0 as parameter, be would core because no checking of parameter Solved: check parameter in fe analyze
morrySnow
pushed a commit
that referenced
this pull request
May 17, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…pache#34661) pick from master apache#32994 Problem: when ntile using 0 as parameter, be would core because no checking of parameter Solved: check parameter in fe analyze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
when ntile using 0 as parameter, be would core because no checking of parameter
Solved:
check parameter in fe analyze
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...