Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented May 10, 2024

pick from master #32994

Problem:
when ntile using 0 as parameter, be would core because no checking of parameter Solved:
check parameter in fe analyze

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Problem:
when ntile using 0 as parameter, be would core because no checking of parameter
Solved:
check parameter in fe analyze
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49564 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false

------ Round 1 ----------------------------------
q1	17871	4362	4320	4320
q2	2018	150	145	145
q3	10465	1906	1980	1906
q4	10341	1235	1333	1235
q5	8540	3889	3908	3889
q6	235	125	122	122
q7	2030	1590	1590	1590
q8	9258	2721	2705	2705
q9	10751	10253	10242	10242
q10	8629	3523	3508	3508
q11	430	237	241	237
q12	480	303	297	297
q13	18342	3943	4007	3943
q14	345	328	327	327
q15	511	466	469	466
q16	666	569	570	569
q17	1135	975	982	975
q18	7335	6828	6887	6828
q19	1710	1536	1575	1536
q20	545	291	304	291
q21	4443	4124	4051	4051
q22	491	406	382	382
Total cold run time: 116571 ms
Total hot run time: 49564 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4317	4304	4307	4304
q2	324	222	226	222
q3	4153	4141	4153	4141
q4	2777	2729	2755	2729
q5	7140	7104	7106	7104
q6	236	116	118	116
q7	3243	2841	2803	2803
q8	4341	4468	4452	4452
q9	16824	16681	16718	16681
q10	4259	4257	4295	4257
q11	765	698	692	692
q12	1044	858	859	858
q13	6983	3725	3712	3712
q14	456	428	419	419
q15	514	466	458	458
q16	739	688	681	681
q17	3915	3931	3812	3812
q18	8846	8689	8857	8689
q19	1720	1694	1677	1677
q20	2381	2108	2122	2108
q21	8534	8448	8391	8391
q22	1015	911	912	911
Total cold run time: 84526 ms
Total hot run time: 79217 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203263 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false

query1	918	393	383	383
query2	6543	2934	2818	2818
query3	6913	209	206	206
query4	20572	17924	18064	17924
query5	19714	6613	6451	6451
query6	285	209	233	209
query7	4161	296	306	296
query8	293	263	237	237
query9	3108	2665	2602	2602
query10	408	318	292	292
query11	11338	10667	10693	10667
query12	119	72	73	72
query13	5586	710	673	673
query14	18062	13500	13107	13107
query15	357	233	233	233
query16	6470	271	260	260
query17	1714	1447	868	868
query18	2322	401	408	401
query19	211	150	152	150
query20	82	77	83	77
query21	191	98	103	98
query22	4997	4968	4949	4949
query23	32687	31990	32140	31990
query24	6921	6480	6524	6480
query25	522	410	419	410
query26	526	166	168	166
query27	1835	301	295	295
query28	6144	2358	2310	2310
query29	2894	2705	2759	2705
query30	241	168	163	163
query31	912	739	754	739
query32	68	64	60	60
query33	401	263	263	263
query34	856	488	479	479
query35	1117	935	944	935
query36	1319	1271	1088	1088
query37	99	58	60	58
query38	3050	2954	2983	2954
query39	1363	1323	1320	1320
query40	211	96	94	94
query41	38	36	38	36
query42	88	83	84	83
query43	708	654	714	654
query44	1142	710	714	710
query45	243	233	226	226
query46	1225	983	976	976
query47	1865	1695	1874	1695
query48	1017	725	707	707
query49	616	370	384	370
query50	849	635	624	624
query51	4843	4594	4687	4594
query52	94	87	81	81
query53	447	315	327	315
query54	2635	2461	2489	2461
query55	79	80	84	80
query56	208	185	222	185
query57	1157	1155	1104	1104
query58	220	213	183	183
query59	4554	4157	3878	3878
query60	210	222	198	198
query61	91	86	87	86
query62	779	507	471	471
query63	475	344	339	339
query64	2283	1502	1467	1467
query65	3640	3536	3570	3536
query66	779	380	381	380
query67	16473	16772	15946	15946
query68	7086	631	651	631
query69	573	337	345	337
query70	1437	1372	1307	1307
query71	403	323	315	315
query72	6461	3410	3421	3410
query73	748	338	326	326
query74	6283	5833	5861	5833
query75	4683	3676	3741	3676
query76	4503	1133	1192	1133
query77	528	249	242	242
query78	12483	11500	14818	11500
query79	6727	645	628	628
query80	1401	396	390	390
query81	504	235	227	227
query82	401	100	100	100
query83	162	128	129	128
query84	254	66	71	66
query85	1272	296	299	296
query86	354	294	305	294
query87	3231	2998	3028	2998
query88	4508	2347	2350	2347
query89	361	290	295	290
query90	1789	193	189	189
query91	172	132	147	132
query92	58	55	53	53
query93	954	596	556	556
query94	866	210	207	207
query95	1123	1062	1068	1062
query96	638	324	328	324
query97	6420	6426	6413	6413
query98	182	164	168	164
query99	2777	984	822	822
Total cold run time: 301630 ms
Total hot run time: 203263 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false

query1	0.03	0.02	0.02
query2	0.06	0.03	0.02
query3	0.24	0.04	0.04
query4	1.80	0.06	0.06
query5	0.53	0.52	0.52
query6	1.23	0.61	0.61
query7	0.01	0.01	0.02
query8	0.03	0.02	0.02
query9	0.52	0.48	0.48
query10	0.54	0.54	0.54
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.61	0.62	0.61
query14	0.77	0.79	0.78
query15	0.77	0.76	0.76
query16	0.35	0.37	0.35
query17	0.99	0.98	1.00
query18	0.23	0.22	0.29
query19	1.94	1.78	1.84
query20	0.01	0.00	0.00
query21	15.51	0.57	0.54
query22	2.34	2.41	1.76
query23	17.23	1.10	1.12
query24	6.28	1.32	0.73
query25	0.42	0.06	0.06
query26	0.66	0.17	0.15
query27	0.04	0.04	0.05
query28	6.85	0.79	0.71
query29	12.64	2.38	2.37
query30	0.54	0.53	0.53
query31	2.81	0.39	0.38
query32	3.39	0.49	0.51
query33	3.07	3.09	3.07
query34	15.25	4.80	4.79
query35	4.82	4.82	4.85
query36	1.04	1.01	1.03
query37	0.06	0.05	0.05
query38	0.04	0.02	0.03
query39	0.02	0.02	0.01
query40	0.16	0.14	0.13
query41	0.06	0.02	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.17 s
Total hot run time: 30.77 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@morrySnow morrySnow merged commit c84b033 into apache:branch-2.0 May 17, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…pache#34661)

pick from master apache#32994

Problem:
when ntile using 0 as parameter, be would core because no checking of parameter

Solved:
check parameter in fe analyze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants