Skip to content

[fix](memory) Fix Jemalloc hook failed to start BE with JDK 17 #33946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 22, 2024
Merged

[fix](memory) Fix Jemalloc hook failed to start BE with JDK 17 #33946

yiguolei merged 1 commit into from
Apr 22, 2024

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Apr 22, 2024

Proposed changes

Issue Number: close #33570

Jemalloc hook not need enable by default, it is only occasionally used during memory debug, such as tracking the memory usage of a function or piece of code.
change Hook implementation maybe solve this problem: #33897

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Apr 22, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

TeamCity be ut coverage result:
Function Coverage: 35.37% (8916/25210)
Line Coverage: 27.10% (73327/270593)
Region Coverage: 26.24% (37879/144369)
Branch Coverage: 23.05% (19291/83696)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6454984b685ddb5b781b0f29a6c00fc4b021d5a5_6454984b685ddb5b781b0f29a6c00fc4b021d5a5/report/index.html

xy720
xy720 reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the different between USE_JEMALLOC and USE_JEMALLOC_HOOK?

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Apr 22, 2024 •
edited
Loading

What is the different between USE_JEMALLOC and USE_JEMALLOC_HOOK?

@xy720
USE_JEMALLOC: whether to use Jemalloc, if false will use TCMalloc
USE_JEMALLOC_HOOK: Whether to use Jemalloc hook, if true, will overwrite malloc/free/realloc/etc.

zhiqiang-hhhh
zhiqiang-hhhh approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 5fee715 into apache:master Apr 22, 2024
yiguolei pushed a commit that referenced this pull request Apr 22, 2024
@xinyiZzz @Doris-Extras
[fix](memory) Fix Jemalloc hook failed to start BE with JDK 17 #33946
188346e
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Apr 25, 2024
@xinyiZzz
Revert "[fix](memory) Fix Jemalloc hook failed to start BE with JDK 17 …
691421c 
…apache#33946"

This reverts commit 5fee715.
@xinyiZzz xinyiZzz mentioned this pull request Apr 25, 2024
Merged
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
@xinyiZzz
Revert "[fix](memory) Fix Jemalloc hook failed to start BE with JDK 17 …
132d974 
…#33946" (#34107)

This reverts commit 5fee715.
@xinyiZzz xinyiZzz mentioned this pull request Dec 17, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720 xy720 xy720 left review comments

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Failed to start BE with JDK 17.

6 participants

@xinyiZzz @doris-robot @morningman @yiguolei @xy720 @zhiqiang-hhhh