Skip to content

(#3395)calculate 'case when expr' when possible #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 9 commits into from
May 7, 2020
Merged

(#3395)calculate 'case when expr' when possible #3396

morningman merged 9 commits into from
May 7, 2020

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Apr 25, 2020

(#3395)
calculate 'case when expr' when possible

morningman
morningman reviewed Apr 25, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a ut for this case? In QueryPlanTest.java

@wangbo
Copy link
Contributor Author

wangbo commented Apr 25, 2020

@morningman ut added

morningman
morningman requested changes Apr 27, 2020
View reviewed changes
@wangbo
Copy link
Contributor Author

wangbo commented Apr 29, 2020

major change
1 support case when and case xxx when
2 support multi case when
3 add ut

Todo
1 fix clerical error in CaseExpr
2 make CaseExpr format better
I will fix the todo in another pr,because I'm not sure the fix cost

kangkaisen
kangkaisen requested changes Apr 29, 2020
View reviewed changes
wangbo added 2 commits April 30, 2020 13:31
@wangbo
1 support skip null
cd9bedd 
2 add more ut
3 fix logic bug
@wangbo
1 use UtFrameUtils.getSQLPlanOrErrorMsg to check plan
1d18a2f 
2 clone a new expr when return CaseExpr which has been changed
kangkaisen
kangkaisen reviewed May 2, 2020
View reviewed changes
@wangbo wangbo force-pushed the eval_case_when_expr branch from 91302de to 4d3c681 Compare May 3, 2020 05:39
kangkaisen
kangkaisen previously approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1， LGTM

@wangbo
[UT] Fix UT bug (apache#3456)
44b7602 
SSD cool downtime shouldn't be fix time in UT;
kangkaisen
kangkaisen previously approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wangbo
Copy link
Contributor Author

wangbo commented May 6, 2020

resolve conflict

morningman
morningman approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this May 7, 2020
@morningman morningman added approved Indicates a PR has been approved by one committer. area/sql/execution Issues or PRs related to the execution engine area/sql/function Issues or PRs related to the SQL functions labels May 7, 2020
@morningman morningman merged commit d60bb81 into apache:master May 7, 2020
@xy720 xy720 mentioned this pull request Sep 22, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/sql/execution Issues or PRs related to the execution engine area/sql/function Issues or PRs related to the SQL functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangbo @morningman @kangkaisen