[Bug] Fix analysis error when there are different types in case-when-then-else with group by clause #4646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #4645
Relevant pr #3396
To Reproduce
Steps to reproduce the behavior:
In the sql above, search_source is a
TINYINTtype and 'string' isVARCHAR(*)type. Because the value of WhenExpr"condition" = ' 'is false, so this case-when clause will produce a CastExpr as SelectListItem with aTINYINTtype SlotRef child representssearch_sourceafter rewriting the sql. However, the analyzeAggregation() method cannot handle the case where SelectListItem is CaseExpr(implicitCast).Expected behavior
Analysis successfully.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...