Skip to content

[Bug] Fix analysis error when there are different types in case-when-then-else with group by clause #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Sep 23, 2020
Merged

[Bug] Fix analysis error when there are different types in case-when-then-else with group by clause #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909ffb2
save code
Sep 22, 2020
9b38e2a
add comments
Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,13 @@ public void createSmaps(Analyzer analyzer) {
exprs.addAll(aggregateExprs_);
for (int i = 0; i < exprs.size(); ++i) {
Expr expr = exprs.get(i);
outputTupleSmap_.put(expr.clone(),
new SlotRef(outputTupleDesc_.getSlots().get(i)));
if (expr.isImplicitCast()) {
outputTupleSmap_.put(expr.getChild(0).clone(),
new SlotRef(outputTupleDesc_.getSlots().get(i)));
} else {
outputTupleSmap_.put(expr.clone(),
new SlotRef(outputTupleDesc_.getSlots().get(i)));
}
if (!requiresIntermediateTuple()) continue;

intermediateTupleSmap_.put(expr.clone(),
Expand Down
1 change: 0 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ public Expr clone() {
}

public SlotDescriptor getDesc() {
Preconditions.checkState(isAnalyzed);
Preconditions.checkNotNull(desc);
return desc;
}
Expand Down
15 changes: 15 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,21 @@ public void testConvertCaseWhenToConstant() throws Exception {
// 4.2.1 test null in when expr
String sql421 = "select case 'a' when null then 'a' else 'other' end as col421";
Assert.assertTrue(StringUtils.containsIgnoreCase(UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, "explain " + sql421), "constant exprs: \n 'other'"));

// 5.1 test same type in then expr and else expr
String sql51 = "select case when 132 then k7 else 'all' end as col51 from test.baseall group by col51";
Assert.assertTrue(StringUtils.containsIgnoreCase(UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, "explain " + sql51),
"OUTPUT EXPRS: CASE WHEN 132 THEN `k7` ELSE 'all' END"));

// 5.2 test same type in then expr and else expr
String sql52 = "select case when 2 < 1 then 'all' else k7 end as col52 from test.baseall group by col52";
Assert.assertTrue(StringUtils.containsIgnoreCase(UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, "explain " + sql52),
"OUTPUT EXPRS: `k7`"));

// 5.3 test different in then expr and else expr, and return CastExpr<SlotRef>
String sql53 = "select case when 2 < 1 then 'all' else k1 end as col53 from test.baseall group by col53";
Assert.assertTrue(StringUtils.containsIgnoreCase(UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, "explain " + sql53),
"OUTPUT EXPRS:<slot 0> `k1`"));
}

@Test
Expand Down