Skip to content

[fix](nereids)prevent null pointer access if translate expression fails #33990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 2 commits into from
Apr 26, 2024
Merged

[fix](nereids)prevent null pointer access if translate expression fails #33990

starocean999 merged 2 commits into from
Apr 26, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Apr 22, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Apr 22, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

TPC-H: Total hot run time: 38262 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6ea24d076511814a162e316eb9f641b6a969fb9c, data reload: false

------ Round 1 ----------------------------------
q1	17776	4342	4190	4190
q2	2020	185	184	184
q3	10525	1131	1174	1131
q4	10216	690	764	690
q5	7495	2672	2605	2605
q6	216	133	133	133
q7	1024	606	589	589
q8	9222	2040	2021	2021
q9	7334	6568	6554	6554
q10	8534	3525	3515	3515
q11	452	229	229	229
q12	472	219	208	208
q13	18215	2902	2943	2902
q14	277	234	229	229
q15	533	489	486	486
q16	495	397	383	383
q17	951	690	711	690
q18	7474	6814	6744	6744
q19	5007	1522	1481	1481
q20	652	307	307	307
q21	3468	2686	2785	2686
q22	364	326	305	305
Total cold run time: 112722 ms
Total hot run time: 38262 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4333	4190	4231	4190
q2	373	258	262	258
q3	2963	2659	2701	2659
q4	1872	1567	1577	1567
q5	5334	5336	5296	5296
q6	204	121	122	121
q7	2212	1832	1832	1832
q8	3159	3334	3323	3323
q9	8547	8595	8555	8555
q10	3952	3724	3833	3724
q11	580	493	495	493
q12	833	618	631	618
q13	16335	3078	3133	3078
q14	329	282	304	282
q15	519	475	483	475
q16	474	461	450	450
q17	1799	1501	1505	1501
q18	8001	8216	7730	7730
q19	1655	1548	1563	1548
q20	2031	1871	1828	1828
q21	5530	4937	4976	4937
q22	575	482	488	482
Total cold run time: 71610 ms
Total hot run time: 54947 ms

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

TPC-DS: Total hot run time: 184942 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6ea24d076511814a162e316eb9f641b6a969fb9c, data reload: false

query1	788	381	366	366
query2	6481	2382	2420	2382
query3	6395	215	212	212
query4	22750	21405	21443	21405
query5	3964	416	422	416
query6	273	180	174	174
query7	4406	297	288	288
query8	243	180	182	180
query9	8382	2290	2253	2253
query10	553	253	282	253
query11	14789	14140	14116	14116
query12	149	90	88	88
query13	1561	377	378	377
query14	10097	7835	7906	7835
query15	248	209	180	180
query16	8172	263	259	259
query17	1897	570	545	545
query18	2097	276	266	266
query19	313	147	151	147
query20	92	84	83	83
query21	196	139	133	133
query22	5149	4862	4842	4842
query23	33792	33131	33236	33131
query24	10584	3026	3001	3001
query25	591	364	381	364
query26	1086	165	153	153
query27	2165	308	307	307
query28	6623	1948	1933	1933
query29	874	598	600	598
query30	310	171	168	168
query31	1000	700	710	700
query32	84	51	54	51
query33	756	275	244	244
query34	996	468	499	468
query35	832	700	693	693
query36	1055	900	902	900
query37	110	69	67	67
query38	3401	3190	3237	3190
query39	1570	1496	1509	1496
query40	212	131	125	125
query41	46	44	46	44
query42	107	96	97	96
query43	571	537	562	537
query44	1221	727	745	727
query45	305	263	260	260
query46	1073	751	745	745
query47	1938	1835	1878	1835
query48	368	304	289	289
query49	965	385	382	382
query50	756	384	394	384
query51	6614	6608	6612	6608
query52	110	85	91	85
query53	346	277	283	277
query54	310	235	233	233
query55	79	74	75	74
query56	257	222	215	215
query57	1175	1128	1129	1128
query58	213	199	197	197
query59	3498	3223	3135	3135
query60	244	227	236	227
query61	122	91	89	89
query62	605	454	460	454
query63	306	279	278	278
query64	5254	3939	4021	3939
query65	3056	3048	3064	3048
query66	792	371	345	345
query67	15626	14929	14808	14808
query68	5778	527	529	527
query69	521	308	306	306
query70	1258	1125	1181	1125
query71	1464	1265	1260	1260
query72	6515	2634	2436	2436
query73	730	322	325	322
query74	6856	6441	6462	6441
query75	3776	2607	2604	2604
query76	4278	977	943	943
query77	655	267	262	262
query78	10917	10110	10113	10110
query79	6881	519	526	519
query80	1161	428	428	428
query81	509	244	247	244
query82	1345	98	99	98
query83	194	171	191	171
query84	263	83	88	83
query85	1343	355	267	267
query86	439	303	293	293
query87	3465	3268	3353	3268
query88	5100	2423	2426	2423
query89	488	371	371	371
query90	2044	182	179	179
query91	121	108	100	100
query92	63	46	45	45
query93	5797	518	503	503
query94	1470	186	186	186
query95	398	311	301	301
query96	618	275	278	275
query97	3206	2958	2959	2958
query98	239	221	212	212
query99	1244	854	909	854
Total cold run time: 290129 ms
Total hot run time: 184942 ms

@doris-robot
Copy link

doris-robot commented Apr 22, 2024

ClickBench: Total hot run time: 30.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ea24d076511814a162e316eb9f641b6a969fb9c, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.03	0.04
query3	0.22	0.05	0.06
query4	1.66	0.08	0.08
query5	0.50	0.51	0.51
query6	1.47	0.71	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.55	0.51	0.49
query10	0.57	0.57	0.55
query11	0.16	0.11	0.12
query12	0.14	0.12	0.12
query13	0.60	0.60	0.59
query14	0.75	0.77	0.78
query15	0.84	0.80	0.81
query16	0.37	0.36	0.37
query17	1.02	0.94	1.04
query18	0.20	0.25	0.23
query19	1.78	1.70	1.74
query20	0.01	0.02	0.01
query21	15.43	0.66	0.65
query22	4.14	7.98	1.88
query23	18.34	1.34	1.25
query24	1.40	0.36	0.24
query25	0.14	0.09	0.08
query26	0.26	0.16	0.15
query27	0.07	0.08	0.08
query28	13.37	0.99	0.97
query29	12.60	3.29	3.22
query30	0.25	0.07	0.06
query31	2.88	0.39	0.37
query32	3.26	0.47	0.45
query33	2.86	2.79	2.85
query34	17.14	4.43	4.41
query35	4.45	4.49	4.46
query36	0.64	0.45	0.46
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.18	0.14	0.14
query41	0.09	0.06	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.03 s
Total hot run time: 30.26 s

@starocean999 starocean999 marked this pull request as ready for review April 24, 2024 02:23
@starocean999
Copy link
Contributor Author

starocean999 commented Apr 24, 2024

run buildall

@starocean999 starocean999 mentioned this pull request Apr 24, 2024
Merged
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 0038423 into apache:master Apr 26, 2024
yiguolei pushed a commit that referenced this pull request Apr 26, 2024
@starocean999 @Doris-Extras
[fix](nereids)prevent null pointer access if translate expression fai…
fdf9175 
…ls (#33990)
dataroaring pushed a commit that referenced this pull request Apr 27, 2024
@starocean999 @dataroaring
[fix](nereids)prevent null pointer access if translate expression fai…
c2c95f8 
…ls (#33990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.10-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@starocean999 @doris-robot @englefly @morrySnow