-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids)prevent null pointer access if translate expression fails #34055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 49718 ms |
TPC-DS: Total hot run time: 203476 ms |
ClickBench: Total hot run time: 30.56 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
can you add some test case? |
I found the NPE in some unexpected scenario. Like user defined var is not replaced by literal in right place would cause the translation fail. After the bug is fixed, there is not NPE now. So this is just a fail-safe for unexpected fail in future. |
Proposed changes
pick from master #33990
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...