Skip to content

Conversation

@zxealous
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Not add disk path to broken list if check status is not IO_ERROR

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zxealous
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.20% (8918/25337)
Line Coverage: 26.97% (73318/271852)
Region Coverage: 26.15% (37881/144880)
Branch Coverage: 22.96% (19284/83978)
Coverage Report: http://coverage.selectdb-in.cc/coverage/57c089143394b4160a4e0ec17f5edd095e330c7d_57c089143394b4160a4e0ec17f5edd095e330c7d/report/index.html

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 25, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 152c586 into apache:master Apr 25, 2024
zxealous added a commit to zxealous/doris that referenced this pull request Apr 25, 2024
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
dataroaring pushed a commit that referenced this pull request Apr 26, 2024
@zxealous zxealous deleted the not-add-broken-path branch April 28, 2024 09:29
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.10-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants