Skip to content

[improve](disk) Not add disk path to broken list if check status is not IO_ERROR #34111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Apr 25, 2024
Merged

[improve](disk) Not add disk path to broken list if check status is not IO_ERROR #34111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/olap/data_dir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ void DataDir::health_check() {
// check disk
if (_is_used) {
Status res = _read_and_write_test_file();
if (!res) {
if (!res && res.is<IO_ERROR>()) {
LOG(WARNING) << "store read/write test file occur IO Error. path=" << _path
<< ", err: " << res;
_engine.add_broken_path(_path);
Expand Down
1 change: 1 addition & 0 deletions be/src/service/doris_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ int main(int argc, char** argv) {
it = paths.erase(it);
} else {
LOG(ERROR) << "read write test file failed, path=" << it->path;
// if only one disk and the disk is full, also need exit because rocksdb will open failed
exit(-1);
}
} else {
Expand Down