Skip to content

Conversation

@ryanzryu
Copy link
Contributor

Proposed changes

Issue Number: #34296

insert add delete sign column to reset delete sign = 0 on partial update mode

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ryanzryu
Copy link
Contributor Author

ryanzryu commented Apr 29, 2024 via email

@ryanzryu ryanzryu force-pushed the fix_partialUpdata_delete_sign branch from 209c27c to e2cb845 Compare April 29, 2024 09:12

sql "insert into ${tableName10}(k,v) values(1,100);"
sql "delete from ${tableName10} where k like '%%';"
sql "insert into ${tableName10}(k,v) values(1,100);"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but this PR can't fix the issue. e.g.
If your table's schema have 3 columns, say k, v1, v2
then insert with values (1, 100, 200);
then delete them all
then you set enable_unique_key_partial_update=true, and insert into ${tableName10}(k,v1) values(1,100);, you should expect to get a result 1, 100, null, but actually you will get a resut 1, 100, 200.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more cases

@zhannngchen
Copy link
Contributor

#36210 fixed the issue, close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants