[fix](round) Fix incorrect decimal scale inference in round functions #34471

zhiqiang-hhhh · 2024-05-07T07:03:20Z

Function execution in backend should always use the scale from planner to create result Decimal for round likes functions.

The problem is fixed in this pr, by:

modify scale inference rule on FE like what [fix](Nereids) ComputePrecisionForRound should only process integral literal #34473 did
round function execution will alway make sure result decimal has exactly same scale with arguments from planner
add test cases for using float as scale arguments(which can not be executed correctly before)

doris-robot · 2024-05-07T07:03:24Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zhiqiang-hhhh · 2024-05-07T07:03:42Z

#34391

zhiqiang-hhhh · 2024-05-07T07:03:53Z

run buildall

github-actions · 2024-05-07T07:08:50Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-07T07:21:58Z

TPC-H: Total hot run time: 41088 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d71e04291f3442998587dc590910256d7d737245, data reload: false

------ Round 1 ----------------------------------
q1	16192	4355	4237	4237
q2	1797	195	191	191
q3	4683	1245	1179	1179
q4	9127	949	796	796
q5	6874	2762	2725	2725
q6	223	138	136	136
q7	1078	618	638	618
q8	9011	2207	2095	2095
q9	7153	6738	6737	6737
q10	8996	3836	3839	3836
q11	479	266	263	263
q12	422	228	219	219
q13	16335	3157	3122	3122
q14	272	215	232	215
q15	536	511	469	469
q16	490	408	414	408
q17	961	714	685	685
q18	8186	7918	7723	7723
q19	1615	1523	1529	1523
q20	647	309	306	306
q21	5232	3318	3388	3318
q22	364	298	287	287
Total cold run time: 100673 ms
Total hot run time: 41088 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4441	4300	4346	4300
q2	395	261	265	261
q3	3024	2688	2726	2688
q4	1874	1649	1583	1583
q5	5249	5276	5285	5276
q6	206	122	118	118
q7	2236	1861	1893	1861
q8	3156	3353	3319	3319
q9	8487	8442	8464	8442
q10	3847	3672	3669	3669
q11	566	497	476	476
q12	745	622	581	581
q13	16259	2936	2949	2936
q14	295	264	273	264
q15	505	473	485	473
q16	470	422	398	398
q17	1756	1464	1436	1436
q18	7607	7553	7388	7388
q19	5289	1566	1545	1545
q20	1962	1771	1738	1738
q21	5048	4879	4780	4780
q22	598	494	491	491
Total cold run time: 74015 ms
Total hot run time: 54023 ms

doris-robot · 2024-05-07T07:32:02Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (8985/25174)
Line Coverage: 27.34% (74213/271421)
Region Coverage: 26.59% (38370/144293)
Branch Coverage: 23.38% (19558/83642)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d71e04291f3442998587dc590910256d7d737245_d71e04291f3442998587dc590910256d7d737245/report/index.html

doris-robot · 2024-05-07T07:33:45Z

TPC-DS: Total hot run time: 187198 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d71e04291f3442998587dc590910256d7d737245, data reload: false

query1	914	366	356	356
query2	6456	2460	2321	2321
query3	6635	206	216	206
query4	22824	21251	21365	21251
query5	4141	422	428	422
query6	267	187	193	187
query7	4581	307	287	287
query8	237	196	194	194
query9	8523	2426	2417	2417
query10	429	253	253	253
query11	14695	14155	14113	14113
query12	141	90	88	88
query13	1637	373	382	373
query14	10469	8297	8255	8255
query15	251	177	181	177
query16	8163	270	268	268
query17	1760	575	551	551
query18	2135	295	278	278
query19	240	157	157	157
query20	91	89	88	88
query21	197	125	129	125
query22	5056	4864	4892	4864
query23	33826	33254	33373	33254
query24	6374	2903	2891	2891
query25	543	382	382	382
query26	689	159	157	157
query27	1882	322	338	322
query28	3770	2089	2119	2089
query29	854	642	621	621
query30	231	153	154	153
query31	941	738	720	720
query32	90	54	56	54
query33	486	266	254	254
query34	869	484	479	479
query35	759	660	673	660
query36	1051	939	898	898
query37	106	69	69	69
query38	3119	3049	3073	3049
query39	1584	1552	1525	1525
query40	206	135	131	131
query41	43	41	43	41
query42	104	100	98	98
query43	580	560	526	526
query44	1057	725	744	725
query45	257	251	256	251
query46	1064	738	734	734
query47	1951	1891	1869	1869
query48	374	303	300	300
query49	785	397	411	397
query50	782	396	381	381
query51	6685	6731	6610	6610
query52	110	90	86	86
query53	342	278	281	278
query54	260	249	242	242
query55	82	76	78	76
query56	265	221	222	221
query57	1212	1132	1121	1121
query58	236	203	201	201
query59	3250	3076	3214	3076
query60	291	235	234	234
query61	90	90	88	88
query62	562	456	435	435
query63	307	279	280	279
query64	8303	7180	7155	7155
query65	3119	3100	3061	3061
query66	795	339	344	339
query67	15717	14944	14928	14928
query68	7344	543	543	543
query69	532	311	304	304
query70	1213	1074	1118	1074
query71	477	305	257	257
query72	8090	2544	2387	2387
query73	731	326	330	326
query74	6486	6149	6065	6065
query75	4280	2650	2643	2643
query76	4452	996	976	976
query77	729	266	269	266
query78	10972	10279	10184	10184
query79	12813	517	522	517
query80	2108	434	456	434
query81	471	219	228	219
query82	737	92	97	92
query83	214	164	164	164
query84	274	86	88	86
query85	1071	276	264	264
query86	385	309	270	270
query87	3338	3100	3052	3052
query88	5474	2420	2442	2420
query89	532	383	375	375
query90	2174	185	186	185
query91	127	97	97	97
query92	67	47	47	47
query93	7556	533	520	520
query94	1100	184	182	182
query95	398	299	301	299
query96	627	270	264	264
query97	3135	2971	2919	2919
query98	244	223	222	222
query99	1326	854	875	854
Total cold run time: 295322 ms
Total hot run time: 187198 ms

zhiqiang-hhhh · 2024-05-07T09:03:50Z

run buildall

github-actions · 2024-05-07T09:08:42Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-07T09:21:40Z

TPC-H: Total hot run time: 39925 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2c3671e7c5e5104a9a01128d0dc5ea0f1ea6fed, data reload: false

------ Round 1 ----------------------------------
q1	17733	4397	4403	4397
q2	2446	189	201	189
q3	10768	1256	1252	1252
q4	10701	732	772	732
q5	7488	2688	2572	2572
q6	221	130	134	130
q7	1033	615	595	595
q8	9638	2071	2049	2049
q9	8937	6518	6481	6481
q10	8966	3760	3739	3739
q11	440	244	246	244
q12	491	221	215	215
q13	17761	2966	2953	2953
q14	259	223	218	218
q15	506	465	465	465
q16	496	382	374	374
q17	963	668	683	668
q18	8044	7433	7291	7291
q19	1630	1535	1526	1526
q20	666	318	308	308
q21	5120	3238	3247	3238
q22	345	298	289	289
Total cold run time: 114652 ms
Total hot run time: 39925 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4511	4229	4184	4184
q2	377	272	266	266
q3	2990	2761	2733	2733
q4	1829	1581	1576	1576
q5	5283	5256	5238	5238
q6	208	123	125	123
q7	2238	1875	1905	1875
q8	3187	3342	3352	3342
q9	8371	8385	8414	8385
q10	3839	3682	3731	3682
q11	582	478	480	478
q12	772	603	599	599
q13	16480	2957	2962	2957
q14	291	257	258	257
q15	513	479	470	470
q16	462	411	417	411
q17	1748	1467	1438	1438
q18	7760	7841	7376	7376
q19	1655	1494	1554	1494
q20	1965	1750	1780	1750
q21	5014	4859	4818	4818
q22	589	488	507	488
Total cold run time: 70664 ms
Total hot run time: 53940 ms

doris-robot · 2024-05-07T09:30:59Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (8984/25174)
Line Coverage: 27.34% (74198/271421)
Region Coverage: 26.59% (38367/144293)
Branch Coverage: 23.37% (19551/83642)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d2c3671e7c5e5104a9a01128d0dc5ea0f1ea6fed_d2c3671e7c5e5104a9a01128d0dc5ea0f1ea6fed/report/index.html

doris-robot · 2024-05-07T09:33:23Z

TPC-DS: Total hot run time: 186007 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2c3671e7c5e5104a9a01128d0dc5ea0f1ea6fed, data reload: false

query1	908	352	343	343
query2	6456	2448	2304	2304
query3	6661	211	212	211
query4	22657	21123	21303	21123
query5	4170	435	417	417
query6	272	179	186	179
query7	4589	304	292	292
query8	238	192	188	188
query9	8674	2434	2418	2418
query10	446	248	267	248
query11	14734	14193	14226	14193
query12	139	92	88	88
query13	1653	377	364	364
query14	10598	7410	7523	7410
query15	263	174	164	164
query16	8178	269	260	260
query17	1852	573	534	534
query18	2102	275	268	268
query19	209	149	148	148
query20	92	87	82	82
query21	197	125	131	125
query22	4990	4866	4830	4830
query23	33951	33064	33128	33064
query24	10983	2870	2902	2870
query25	604	367	355	355
query26	1563	153	152	152
query27	2968	320	316	316
query28	7536	2068	2063	2063
query29	956	613	594	594
query30	295	147	150	147
query31	958	763	746	746
query32	102	57	57	57
query33	761	261	251	251
query34	1063	489	490	489
query35	822	688	693	688
query36	1087	886	902	886
query37	131	68	70	68
query38	2854	2761	2705	2705
query39	1594	1521	1530	1521
query40	282	128	128	128
query41	41	44	43	43
query42	110	97	100	97
query43	584	547	552	547
query44	1304	730	751	730
query45	298	247	253	247
query46	1081	726	719	719
query47	1926	1852	1868	1852
query48	362	307	308	307
query49	1142	401	400	400
query50	767	379	390	379
query51	6744	6709	6676	6676
query52	102	90	88	88
query53	361	285	292	285
query54	327	257	245	245
query55	79	75	74	74
query56	241	220	220	220
query57	1247	1109	1142	1109
query58	233	203	201	201
query59	3496	3222	3279	3222
query60	258	237	241	237
query61	91	87	87	87
query62	671	434	443	434
query63	310	284	279	279
query64	9632	7246	7239	7239
query65	3150	3079	3067	3067
query66	1381	341	341	341
query67	15629	14922	15187	14922
query68	5184	542	549	542
query69	483	302	302	302
query70	1182	1077	1140	1077
query71	408	276	271	271
query72	7445	2577	2348	2348
query73	706	334	338	334
query74	6495	6140	6039	6039
query75	3606	2639	2659	2639
query76	3412	972	969	969
query77	401	268	263	263
query78	11011	10322	10307	10307
query79	4013	537	527	527
query80	1936	450	444	444
query81	540	224	223	223
query82	1087	104	98	98
query83	312	168	163	163
query84	271	93	85	85
query85	1608	262	262	262
query86	506	324	299	299
query87	3264	3122	3068	3068
query88	4720	2421	2460	2421
query89	490	413	388	388
query90	2019	187	191	187
query91	125	97	97	97
query92	60	47	48	47
query93	5042	532	509	509
query94	1246	189	181	181
query95	396	306	309	306
query96	609	270	266	266
query97	3165	2937	2921	2921
query98	245	215	217	215
query99	1294	873	889	873
Total cold run time: 293436 ms
Total hot run time: 186007 ms

github-actions · 2024-05-09T03:30:30Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-09T03:34:35Z

clang-tidy review says "All clean, LGTM! 👍"

zhiqiang-hhhh · 2024-05-09T03:40:27Z

run buildall

doris-robot · 2024-05-09T04:31:33Z

TeamCity be ut coverage result:
Function Coverage: 35.68% (8982/25172)
Line Coverage: 27.35% (74252/271502)
Region Coverage: 26.57% (38366/144402)
Branch Coverage: 23.39% (19567/83672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ef78b96281275cafeb4de3cddbc2f9139c6e019_9ef78b96281275cafeb4de3cddbc2f9139c6e019/report/index.html

zhiqiang-hhhh · 2024-05-09T04:38:37Z

run buildall

github-actions · 2024-05-09T04:41:47Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-09T04:55:40Z

TPC-H: Total hot run time: 41292 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d28d860c8fb6dd41c8ebd07f306640114c3e2b39, data reload: false

------ Round 1 ----------------------------------
q1	7063	4291	4281	4281
q2	520	189	192	189
q3	1406	1171	1179	1171
q4	1013	755	774	755
q5	2631	2660	2604	2604
q6	222	135	139	135
q7	1032	584	567	567
q8	1986	2278	2253	2253
q9	7027	6854	6716	6716
q10	4104	3950	3996	3950
q11	395	255	251	251
q12	402	229	228	228
q13	16319	3030	3143	3030
q14	267	224	239	224
q15	504	482	482	482
q16	511	406	396	396
q17	980	731	674	674
q18	8389	7899	7831	7831
q19	1612	1539	1563	1539
q20	679	335	337	335
q21	9502	3396	4124	3396
q22	364	285	287	285
Total cold run time: 66928 ms
Total hot run time: 41292 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4408	4438	4384	4384
q2	379	278	285	278
q3	3201	2949	2768	2768
q4	1919	1646	1655	1646
q5	5363	5338	5299	5299
q6	216	126	142	126
q7	2228	1875	1869	1869
q8	3169	3344	3345	3344
q9	8359	8475	8456	8456
q10	3930	3690	3648	3648
q11	584	483	478	478
q12	786	572	608	572
q13	3547	2979	2986	2979
q14	286	274	257	257
q15	511	487	473	473
q16	445	415	406	406
q17	1738	1475	1469	1469
q18	7595	7863	7634	7634
q19	1672	1573	1521	1521
q20	1973	1769	1727	1727
q21	5008	4941	4801	4801
q22	563	486	488	486
Total cold run time: 57880 ms
Total hot run time: 54621 ms

doris-robot · 2024-05-09T04:56:32Z

TeamCity be ut coverage result:
Function Coverage: 35.68% (8982/25172)
Line Coverage: 27.35% (74251/271502)
Region Coverage: 26.57% (38367/144402)
Branch Coverage: 23.39% (19567/83672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d28d860c8fb6dd41c8ebd07f306640114c3e2b39_d28d860c8fb6dd41c8ebd07f306640114c3e2b39/report/index.html

doris-robot · 2024-05-09T05:07:23Z

TPC-DS: Total hot run time: 188024 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d28d860c8fb6dd41c8ebd07f306640114c3e2b39, data reload: false

query1	911	364	343	343
query2	6456	2374	2362	2362
query3	6636	218	215	215
query4	26214	21317	21164	21164
query5	4252	429	423	423
query6	270	194	176	176
query7	4578	301	297	297
query8	250	208	196	196
query9	8525	2424	2403	2403
query10	443	258	259	258
query11	14746	14230	14175	14175
query12	135	90	89	89
query13	1636	377	377	377
query14	10665	8620	7719	7719
query15	213	169	175	169
query16	7414	270	265	265
query17	1301	585	554	554
query18	1940	284	270	270
query19	201	147	157	147
query20	92	85	85	85
query21	201	141	136	136
query22	5128	4920	4863	4863
query23	34610	33702	33588	33588
query24	5036	2839	2929	2839
query25	484	390	388	388
query26	697	162	161	161
query27	1830	326	353	326
query28	3866	2074	2067	2067
query29	859	631	618	618
query30	233	156	162	156
query31	944	788	724	724
query32	63	54	56	54
query33	412	260	257	257
query34	880	491	498	491
query35	742	675	702	675
query36	1057	918	906	906
query37	110	69	70	69
query38	2887	2773	2794	2773
query39	1612	1583	1581	1581
query40	200	135	135	135
query41	47	42	48	42
query42	107	103	104	103
query43	566	543	542	542
query44	1066	721	736	721
query45	278	259	261	259
query46	1065	732	749	732
query47	1973	1873	1877	1873
query48	378	309	303	303
query49	799	417	408	408
query50	765	411	406	406
query51	6866	6781	6776	6776
query52	103	95	94	94
query53	365	293	297	293
query54	538	440	454	440
query55	77	78	73	73
query56	254	247	234	234
query57	1225	1160	1168	1160
query58	222	210	219	210
query59	3393	3153	3195	3153
query60	265	246	255	246
query61	152	86	86	86
query62	583	463	470	463
query63	316	295	292	292
query64	7687	7360	7383	7360
query65	3220	3074	3112	3074
query66	683	351	342	342
query67	15574	15015	14948	14948
query68	6642	545	535	535
query69	556	315	319	315
query70	1259	1168	1160	1160
query71	527	280	274	274
query72	8073	2562	2339	2339
query73	743	324	325	324
query74	6488	6182	6157	6157
query75	3906	2637	2641	2637
query76	3536	989	1005	989
query77	644	296	270	270
query78	11027	10277	10196	10196
query79	7038	525	514	514
query80	1853	455	446	446
query81	498	228	224	224
query82	1619	94	97	94
query83	283	163	168	163
query84	269	90	84	84
query85	1101	273	259	259
query86	459	294	309	294
query87	3284	3102	3135	3102
query88	4664	2433	2425	2425
query89	506	396	386	386
query90	2115	199	198	198
query91	132	98	101	98
query92	62	50	54	50
query93	6486	512	503	503
query94	1059	184	183	183
query95	396	309	319	309
query96	608	270	273	270
query97	3151	2994	2961	2961
query98	235	227	260	227
query99	1232	911	931	911
Total cold run time: 287747 ms
Total hot run time: 188024 ms

zhiqiang-hhhh · 2024-05-09T07:27:47Z

run buildall

github-actions · 2024-05-09T07:33:03Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-09T07:49:06Z

TPC-H: Total hot run time: 41703 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 377243efc772b33f0bee51e7d8e684331e08ba44, data reload: false

------ Round 1 ----------------------------------
q1	11090	4306	4266	4266
q2	1639	186	198	186
q3	3081	1180	1221	1180
q4	6079	787	804	787
q5	5561	2844	2717	2717
q6	223	138	145	138
q7	1019	549	560	549
q8	5404	2144	2127	2127
q9	6849	6785	6759	6759
q10	9145	3747	3936	3747
q11	465	243	241	241
q12	420	233	238	233
q13	16810	3157	3166	3157
q14	271	225	236	225
q15	520	488	467	467
q16	498	404	401	401
q17	983	704	707	704
q18	8302	7876	7552	7552
q19	1632	1558	1506	1506
q20	669	322	317	317
q21	5369	4215	4163	4163
q22	351	281	283	281
Total cold run time: 86380 ms
Total hot run time: 41703 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4527	4270	4200	4200
q2	363	260	264	260
q3	3059	2727	2706	2706
q4	1857	1593	1661	1593
q5	5302	5248	5266	5248
q6	209	125	126	125
q7	1819	1425	1404	1404
q8	3182	3372	3346	3346
q9	8427	8415	8442	8415
q10	3938	3762	3700	3700
q11	589	486	496	486
q12	772	615	608	608
q13	16275	2953	2954	2953
q14	280	258	249	249
q15	514	480	476	476
q16	458	418	412	412
q17	1782	1506	1468	1468
q18	7472	7702	7306	7306
q19	1679	1514	1573	1514
q20	1988	1758	1755	1755
q21	5140	4910	4828	4828
q22	548	488	492	488
Total cold run time: 70180 ms
Total hot run time: 53540 ms

doris-robot · 2024-05-09T07:51:01Z

TeamCity be ut coverage result:
Function Coverage: 35.68% (8982/25172)
Line Coverage: 27.35% (74253/271502)
Region Coverage: 26.58% (38375/144402)
Branch Coverage: 23.39% (19569/83672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/377243efc772b33f0bee51e7d8e684331e08ba44_377243efc772b33f0bee51e7d8e684331e08ba44/report/index.html

doris-robot · 2024-05-09T08:00:37Z

TPC-DS: Total hot run time: 186243 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 377243efc772b33f0bee51e7d8e684331e08ba44, data reload: false

query1	920	368	352	352
query2	6443	2475	2263	2263
query3	6640	208	214	208
query4	26313	21308	21178	21178
query5	4117	412	427	412
query6	270	179	183	179
query7	4586	285	284	284
query8	233	189	186	186
query9	8550	2422	2418	2418
query10	427	248	250	248
query11	14668	14235	14084	14084
query12	134	95	91	91
query13	1652	375	385	375
query14	9809	6928	8643	6928
query15	253	164	174	164
query16	8161	268	273	268
query17	1713	577	567	567
query18	2130	295	278	278
query19	271	160	156	156
query20	93	119	83	83
query21	195	133	126	126
query22	5055	4836	4803	4803
query23	34526	33682	33474	33474
query24	9261	2863	2839	2839
query25	553	362	365	362
query26	689	154	154	154
query27	2122	324	326	324
query28	5715	2043	2042	2042
query29	846	603	615	603
query30	248	154	160	154
query31	985	746	735	735
query32	90	54	54	54
query33	619	269	243	243
query34	866	493	476	476
query35	771	702	654	654
query36	1096	868	895	868
query37	105	65	66	65
query38	2904	2806	2792	2792
query39	1625	1536	1576	1536
query40	195	127	123	123
query41	42	39	39	39
query42	108	98	96	96
query43	573	528	541	528
query44	1120	717	734	717
query45	264	247	264	247
query46	1066	708	702	702
query47	1966	1896	1920	1896
query48	365	295	294	294
query49	861	411	392	392
query50	791	386	396	386
query51	6962	6839	6890	6839
query52	103	85	96	85
query53	351	299	290	290
query54	747	429	432	429
query55	74	72	73	72
query56	237	229	217	217
query57	1244	1172	1157	1157
query58	228	197	194	194
query59	3468	3231	3096	3096
query60	269	233	234	233
query61	90	89	88	88
query62	623	483	458	458
query63	308	281	279	279
query64	8490	7418	7346	7346
query65	3119	3074	3097	3074
query66	784	343	337	337
query67	15356	15076	14983	14983
query68	4507	539	519	519
query69	473	301	299	299
query70	1179	1139	1142	1139
query71	368	267	301	267
query72	7564	2516	2339	2339
query73	698	320	326	320
query74	6520	6161	6152	6152
query75	3314	2623	2605	2605
query76	2310	978	1023	978
query77	416	265	265	265
query78	10758	10191	10127	10127
query79	2620	504	495	495
query80	1129	445	427	427
query81	537	219	220	219
query82	950	103	93	93
query83	257	164	173	164
query84	253	90	85	85
query85	1204	263	263	263
query86	459	315	297	297
query87	3305	3085	3171	3085
query88	3991	2427	2414	2414
query89	490	384	393	384
query90	2007	195	203	195
query91	125	102	104	102
query92	97	50	46	46
query93	1968	510	501	501
query94	1285	184	188	184
query95	404	314	307	307
query96	598	270	273	270
query97	3178	2968	2958	2958
query98	236	226	210	210
query99	1227	959	911	911
Total cold run time: 279885 ms
Total hot run time: 186243 ms

zhiqiang-hhhh · 2024-05-09T12:56:13Z

run cloud_p1

HappenLee

LGTM

github-actions · 2024-05-10T06:52:37Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-05-10T06:52:39Z

PR approved by anyone and no changes requested.

zhiqiang-hhhh · 2024-05-10T09:42:27Z

@yiguolei branch-2.0 does not need this pr, since previous pr is not picked to 2.0

…#34471) * FIX NEEDED * FORMAT * FORMAT * FIX TEST

…apache#34471) * FIX NEEDED * FORMAT * FORMAT * FIX TEST

zhiqiang-hhhh added 2 commits May 9, 2024 11:28

FIX NEEDED

d1d5570

FORMAT

9ef78b9

zhiqiang-hhhh force-pushed the fix-round branch from 8d8eeb2 to 9ef78b9 Compare May 9, 2024 03:29

zhiqiang-hhhh changed the title ~~[opt](test) more solid test for round like function~~ [fix](round) Fix incorrect decimal scale inference in round functions May 9, 2024

FORMAT

d28d860

zhiqiang-hhhh added 2 commits May 9, 2024 14:46

Merge branch 'master' of https://github.com/apache/doris into fix-round

fab4314

FIX TEST

377243e

HappenLee approved these changes May 10, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2024

github-actions bot added the reviewed label May 10, 2024

morrySnow approved these changes May 10, 2024

View reviewed changes

yiguolei merged commit 8194398 into apache:master May 10, 2024

yiguolei added usercase Important user case type label dev/2.0.x labels May 10, 2024

zhiqiang-hhhh deleted the fix-round branch May 10, 2024 08:10

morrySnow mentioned this pull request May 10, 2024

[fix](Nereids) ComputePrecisionForRound should only process integral literal #34473

Closed

yiguolei removed the dev/2.0.x label May 11, 2024

yiguolei pushed a commit that referenced this pull request May 11, 2024

[fix](round) Fix incorrect decimal scale inference in round functions (…

58c19e3

…#34471) * FIX NEEDED * FORMAT * FORMAT * FIX TEST

yiguolei added dev/2.1.3-merged dev/2.1.4-merged labels May 11, 2024

ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024

[fix](round) Fix incorrect decimal scale inference in round functions (…

f0d5178

…apache#34471) * FIX NEEDED * FORMAT * FORMAT * FIX TEST

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

[fix](round) Fix incorrect decimal scale inference in round functions #34471

[fix](round) Fix incorrect decimal scale inference in round functions #34471

Uh oh!

Conversation

zhiqiang-hhhh commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

zhiqiang-hhhh commented May 7, 2024

Uh oh!

zhiqiang-hhhh commented May 7, 2024

Uh oh!

github-actions bot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

zhiqiang-hhhh commented May 7, 2024

Uh oh!

github-actions bot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

doris-robot commented May 7, 2024

Uh oh!

github-actions bot commented May 9, 2024

Uh oh!

github-actions bot commented May 9, 2024

Uh oh!

zhiqiang-hhhh commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

zhiqiang-hhhh commented May 9, 2024

Uh oh!

github-actions bot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

zhiqiang-hhhh commented May 9, 2024

Uh oh!

github-actions bot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

zhiqiang-hhhh commented May 9, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

zhiqiang-hhhh commented May 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zhiqiang-hhhh commented May 7, 2024 •

edited

Loading