[fix](Nereids) ComputePrecisionForRound should only process integral literal #34473
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run p0 |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| int scale; | ||
|
|
||
| if (floatLength.isLiteral() || (floatLength instanceof Cast && floatLength.child(0).isLiteral() | ||
| if ((floatLength.isLiteral() && floatLength.getDataType() instanceof Int32OrLessType) |
There was a problem hiding this comment.
in what situation would scale does not have integer type?
There was a problem hiding this comment.
when we do computePrecision, we do not finish compute signature. so type coercion do not apply. so its child could be any type literal
| List<Column> columns = Lists.newArrayList(); | ||
| PhysicalEmptyRelation physicalEmptyRelation = (PhysicalEmptyRelation) physicalPlan.child(0); | ||
| for (int i = 0; i < physicalEmptyRelation.getProjects().size(); i++) { | ||
| for (int i = 0; i < physicalPlan.getOutput().size(); i++) { |
There was a problem hiding this comment.
what is the relation between this for loop with round function?
There was a problem hiding this comment.
this is another bug, and have no relation with round function
|
already fixed by #34471 |
4 participants
No description provided.