[Refactor](pipeline) refactor the pipeline exec code remove unless code #34557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run be_ut |
Gabriel39
requested changes
May 9, 2024
Contributor
Author
|
run buildall |
HappenLee
force-pushed
the
timer
branch
2 times, most recently
from
484f4a2 to
e3ed928
Compare
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Gabriel39
previously approved these changes
May 9, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 40820 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187374 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41248 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187471 ms |
Mryange
approved these changes
May 10, 2024
Gabriel39
approved these changes
May 10, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
mengzhisy
reviewed
Apr 2, 2025
| COUNTER_UPDATE(_yield_counts, 1); | ||
| break; | ||
| } | ||
| SCOPED_RAW_TIMER(&time_spent); |
There was a problem hiding this comment.
Why was this line removed? It seems to have broken the dynamic priority level adjustment of PipelineTask in task_queue. @HappenLee @Gabriel39
Contributor
There was a problem hiding this comment.
@mengzhisy Sorry for that. I think it is a mistake and I fix it in #49939
16 tasks
Gabriel39
added a commit
that referenced
this pull request
Apr 10, 2025
Execution timer is needed to make a task yield after a time slice. #34557 removed the timer by mistake.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
Execution timer is needed to make a task yield after a time slice. apache#34557 removed the timer by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...