Skip to content

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Apr 10, 2025

What problem does this PR solve?

Execution timer is needed to make a task yield after a time slice. #34557 removed the timer by mistake.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34498 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf78f63a119157e9babd5bb121f539fc9dc42f75, data reload: false

------ Round 1 ----------------------------------
q1	26151	5086	5088	5086
q2	2072	291	182	182
q3	10375	1241	692	692
q4	10223	1038	534	534
q5	7532	2424	2339	2339
q6	194	164	133	133
q7	925	740	619	619
q8	9330	1301	1154	1154
q9	6849	5161	5146	5146
q10	6832	2308	1915	1915
q11	501	302	281	281
q12	346	357	226	226
q13	17796	3668	3119	3119
q14	232	234	208	208
q15	525	489	512	489
q16	624	609	590	590
q17	605	876	383	383
q18	7629	7104	7111	7104
q19	1211	961	573	573
q20	340	352	252	252
q21	4466	3411	2512	2512
q22	1037	1017	961	961
Total cold run time: 115795 ms
Total hot run time: 34498 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5131	5161	5121	5121
q2	239	327	229	229
q3	2202	2626	2316	2316
q4	1458	1822	1513	1513
q5	4592	4517	4370	4370
q6	207	175	127	127
q7	1990	1920	1766	1766
q8	2620	2581	2513	2513
q9	7140	7098	7164	7098
q10	3021	3145	2712	2712
q11	587	507	481	481
q12	680	792	629	629
q13	3516	3892	3230	3230
q14	288	288	282	282
q15	535	458	476	458
q16	656	706	653	653
q17	1166	1557	1387	1387
q18	7766	7657	7382	7382
q19	839	980	984	980
q20	1963	2050	1811	1811
q21	5247	4693	4713	4693
q22	1078	1003	962	962
Total cold run time: 52921 ms
Total hot run time: 50713 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186918 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf78f63a119157e9babd5bb121f539fc9dc42f75, data reload: false

query1	1019	484	461	461
query2	6541	1962	1937	1937
query3	6748	224	218	218
query4	26283	23935	23417	23417
query5	4790	637	465	465
query6	315	212	194	194
query7	4632	496	286	286
query8	306	249	262	249
query9	8646	2570	2564	2564
query10	505	316	262	262
query11	15352	15064	14882	14882
query12	151	109	102	102
query13	1663	511	406	406
query14	9336	6252	6193	6193
query15	210	188	171	171
query16	7169	627	476	476
query17	1143	719	595	595
query18	1995	409	312	312
query19	196	189	180	180
query20	123	121	116	116
query21	217	128	107	107
query22	4026	4146	4223	4146
query23	33978	33138	32972	32972
query24	8436	2378	2400	2378
query25	553	481	454	454
query26	1229	276	147	147
query27	2741	511	330	330
query28	4316	2419	2417	2417
query29	767	561	429	429
query30	296	219	192	192
query31	942	891	755	755
query32	77	62	67	62
query33	559	364	318	318
query34	785	864	503	503
query35	816	840	747	747
query36	999	998	877	877
query37	119	99	100	99
query38	4179	4287	4020	4020
query39	1442	1382	1387	1382
query40	216	115	107	107
query41	56	54	53	53
query42	120	105	107	105
query43	507	495	471	471
query44	1301	820	809	809
query45	180	177	173	173
query46	846	1026	624	624
query47	1751	1787	1708	1708
query48	374	410	314	314
query49	775	488	416	416
query50	643	704	403	403
query51	4188	4227	4086	4086
query52	109	104	102	102
query53	227	263	194	194
query54	575	575	520	520
query55	88	81	86	81
query56	296	328	302	302
query57	1128	1124	1068	1068
query58	268	265	256	256
query59	2594	2791	2634	2634
query60	324	345	310	310
query61	134	132	137	132
query62	809	738	660	660
query63	219	186	193	186
query64	4349	1042	760	760
query65	4389	4258	4244	4244
query66	1146	411	312	312
query67	15664	15653	15352	15352
query68	7733	892	528	528
query69	455	301	267	267
query70	1189	1196	1120	1120
query71	458	320	285	285
query72	5562	4721	4745	4721
query73	645	585	348	348
query74	9333	8889	8624	8624
query75	3778	3208	2709	2709
query76	3475	1195	785	785
query77	786	388	282	282
query78	9983	10050	9262	9262
query79	2047	810	565	565
query80	592	513	444	444
query81	482	252	224	224
query82	507	125	99	99
query83	262	250	233	233
query84	249	112	87	87
query85	795	352	363	352
query86	376	313	285	285
query87	4530	4508	4513	4508
query88	3722	2189	2212	2189
query89	390	302	277	277
query90	1929	210	208	208
query91	144	141	112	112
query92	79	61	58	58
query93	1726	936	589	589
query94	623	426	306	306
query95	377	290	291	290
query96	486	564	273	273
query97	3156	3212	3199	3199
query98	236	205	198	198
query99	1338	1389	1288	1288
Total cold run time: 274319 ms
Total hot run time: 186918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf78f63a119157e9babd5bb121f539fc9dc42f75, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.19	0.11
query5	0.55	0.54	0.53
query6	1.20	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.52	0.50
query10	0.62	0.58	0.59
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.62	0.59	0.61
query14	2.82	2.81	2.70
query15	0.92	0.86	0.86
query16	0.39	0.38	0.38
query17	1.05	1.02	1.03
query18	0.21	0.19	0.20
query19	2.06	1.89	1.82
query20	0.01	0.01	0.01
query21	15.35	0.88	0.54
query22	0.75	1.19	0.69
query23	14.88	1.40	0.60
query24	7.33	1.78	0.77
query25	0.47	0.24	0.14
query26	0.59	0.16	0.12
query27	0.05	0.04	0.05
query28	9.38	0.84	0.45
query29	12.54	3.98	3.34
query30	0.25	0.09	0.06
query31	2.81	0.59	0.38
query32	3.24	0.54	0.48
query33	3.07	3.21	3.11
query34	15.68	5.08	4.54
query35	4.54	4.52	4.50
query36	0.68	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.09	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.49 s
Total hot run time: 31.17 s

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 10, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 52c0748 into apache:master Apr 10, 2025
26 of 29 checks passed
@Gabriel39 Gabriel39 mentioned this pull request Apr 10, 2025
16 tasks
Gabriel39 added a commit that referenced this pull request Apr 11, 2025
#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in `PipelineTaskTest`
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Apr 11, 2025
Execution timer is needed to make a task yield after a time slice.
dataroaring pushed a commit that referenced this pull request Apr 14, 2025
pick #49939
Execution timer is needed to make a task yield after a time slice.
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
apache#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in `PipelineTaskTest`
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Execution timer is needed to make a task yield after a time slice.
apache#34557 removed the timer by mistake.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
apache#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in `PipelineTaskTest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants