Skip to content

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Apr 10, 2025

What problem does this PR solve?

#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in PipelineTaskTest

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34583 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 02dd33e31d465a519ef48e71c818e9d29cd73763, data reload: false

------ Round 1 ----------------------------------
q1	27115	5076	5112	5076
q2	2078	301	202	202
q3	10349	1259	692	692
q4	10225	1015	519	519
q5	8128	2430	2401	2401
q6	192	170	137	137
q7	927	756	605	605
q8	9315	1303	1157	1157
q9	6837	5146	5203	5146
q10	6807	2328	1914	1914
q11	496	282	280	280
q12	352	358	223	223
q13	17762	3713	3071	3071
q14	247	222	207	207
q15	538	484	488	484
q16	617	631	586	586
q17	598	887	374	374
q18	7812	7263	7193	7193
q19	1240	965	558	558
q20	348	336	229	229
q21	4491	3507	2549	2549
q22	1053	1031	980	980
Total cold run time: 117527 ms
Total hot run time: 34583 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5143	5139	5159	5139
q2	237	330	232	232
q3	2204	2665	2270	2270
q4	1504	1944	1475	1475
q5	4537	4472	4331	4331
q6	220	175	129	129
q7	2042	1939	1826	1826
q8	2655	2705	2620	2620
q9	7158	7243	7182	7182
q10	2976	3151	2769	2769
q11	589	517	490	490
q12	691	777	621	621
q13	3609	3980	3309	3309
q14	287	323	262	262
q15	532	480	473	473
q16	641	681	652	652
q17	1174	1551	1406	1406
q18	8008	7589	7233	7233
q19	830	825	917	825
q20	1982	2086	1892	1892
q21	5417	4931	4750	4750
q22	1105	1061	1051	1051
Total cold run time: 53541 ms
Total hot run time: 50937 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193417 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 02dd33e31d465a519ef48e71c818e9d29cd73763, data reload: false

query1	1394	1110	1065	1065
query2	6284	1914	1939	1914
query3	11008	4585	4606	4585
query4	57457	25406	23457	23457
query5	4969	499	476	476
query6	372	221	196	196
query7	4995	516	281	281
query8	339	258	242	242
query9	6671	2599	2625	2599
query10	436	338	276	276
query11	15155	15173	14787	14787
query12	164	112	105	105
query13	1158	526	425	425
query14	10071	6470	6425	6425
query15	206	204	172	172
query16	7303	645	502	502
query17	1093	767	595	595
query18	1684	429	336	336
query19	209	196	186	186
query20	127	127	123	123
query21	212	132	111	111
query22	4756	4561	4321	4321
query23	34013	33629	33508	33508
query24	7056	2436	2426	2426
query25	461	473	394	394
query26	703	278	153	153
query27	2633	504	343	343
query28	3301	2463	2447	2447
query29	593	569	434	434
query30	272	224	195	195
query31	862	900	787	787
query32	75	66	64	64
query33	479	373	328	328
query34	820	868	558	558
query35	832	853	780	780
query36	959	1012	893	893
query37	125	104	77	77
query38	4152	4319	4256	4256
query39	1470	1436	1394	1394
query40	205	121	108	108
query41	54	52	53	52
query42	121	112	105	105
query43	497	490	466	466
query44	1334	804	812	804
query45	179	168	168	168
query46	828	998	642	642
query47	1748	1803	1706	1706
query48	388	431	308	308
query49	705	508	403	403
query50	646	678	409	409
query51	4124	4210	4191	4191
query52	110	109	102	102
query53	224	272	184	184
query54	579	571	542	542
query55	83	79	83	79
query56	307	308	301	301
query57	1124	1139	1080	1080
query58	259	280	258	258
query59	2623	2673	2643	2643
query60	351	329	312	312
query61	133	130	123	123
query62	711	710	694	694
query63	222	191	184	184
query64	1701	1033	700	700
query65	4327	4244	4267	4244
query66	751	407	314	314
query67	15950	15539	15478	15478
query68	6738	898	525	525
query69	603	303	266	266
query70	1181	1113	1105	1105
query71	521	315	300	300
query72	6092	4679	4690	4679
query73	1323	588	347	347
query74	9251	9202	8849	8849
query75	3888	3214	2707	2707
query76	4383	1196	771	771
query77	621	380	288	288
query78	10000	9976	9168	9168
query79	5631	792	551	551
query80	622	526	423	423
query81	473	264	217	217
query82	645	126	92	92
query83	353	269	237	237
query84	287	105	85	85
query85	845	369	312	312
query86	383	307	254	254
query87	4520	4543	4465	4465
query88	3407	2225	2225	2225
query89	451	314	281	281
query90	1824	211	219	211
query91	161	150	116	116
query92	77	67	56	56
query93	3027	938	578	578
query94	658	417	318	318
query95	366	301	297	297
query96	487	571	274	274
query97	3142	3194	3148	3148
query98	235	229	200	200
query99	1436	1440	1256	1256
Total cold run time: 308784 ms
Total hot run time: 193417 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 02dd33e31d465a519ef48e71c818e9d29cd73763, data reload: false

query1	0.04	0.03	0.04
query2	0.13	0.10	0.10
query3	0.26	0.20	0.19
query4	1.59	0.19	0.20
query5	0.59	0.57	0.58
query6	1.18	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.50	0.53
query10	0.58	0.58	0.55
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.84	2.69	2.72
query15	0.92	0.85	0.84
query16	0.38	0.38	0.38
query17	1.00	1.03	1.03
query18	0.21	0.19	0.20
query19	1.88	1.87	1.92
query20	0.01	0.01	0.01
query21	15.35	0.91	0.56
query22	0.76	1.24	0.99
query23	14.68	1.41	0.66
query24	6.65	2.16	0.69
query25	0.55	0.16	0.07
query26	0.62	0.17	0.13
query27	0.06	0.05	0.05
query28	9.40	0.87	0.42
query29	12.59	3.95	3.32
query30	0.24	0.09	0.06
query31	2.84	0.59	0.38
query32	3.22	0.55	0.47
query33	3.03	3.02	3.05
query34	15.67	5.06	4.48
query35	4.52	4.54	4.52
query36	0.67	0.48	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.49 s
Total hot run time: 31.33 s

@Gabriel39 Gabriel39 merged commit 1718f45 into apache:master Apr 11, 2025
24 of 28 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
apache#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in `PipelineTaskTest`
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
apache#49939 fixed missing yielding logics. And then UT to test terminating is not suitable. This PR fix cases in `PipelineTaskTest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants