Skip to content

Conversation

@starocean999
Copy link
Contributor

Proposed changes

The last param of AggregateExpression's constructor should be agg function in phase 3 or 4-phase agg

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fcd69a9bd4e5a6eb30664da6f2b047f5447741c9, data reload: false

------ Round 1 ----------------------------------
q1	17598	4310	4244	4244
q2	2037	194	186	186
q3	10670	1235	1238	1235
q4	10581	845	806	806
q5	7889	2679	2646	2646
q6	217	134	134	134
q7	1006	599	581	581
q8	9312	2113	2075	2075
q9	9424	6658	6621	6621
q10	8988	3779	3811	3779
q11	475	249	237	237
q12	395	220	227	220
q13	18581	3085	3083	3083
q14	256	233	221	221
q15	522	485	488	485
q16	565	389	377	377
q17	961	718	726	718
q18	7982	7389	7344	7344
q19	1644	1501	1499	1499
q20	626	297	298	297
q21	4995	3162	3980	3162
q22	348	276	286	276
Total cold run time: 115072 ms
Total hot run time: 40226 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4300	4201	4202	4201
q2	379	281	265	265
q3	3009	2756	2761	2756
q4	1832	1596	1613	1596
q5	5295	5262	5295	5262
q6	211	124	127	124
q7	2226	1858	1874	1858
q8	3202	3309	3348	3309
q9	8345	8343	8344	8343
q10	3881	3638	3647	3638
q11	572	490	478	478
q12	747	613	628	613
q13	17807	2954	2927	2927
q14	278	274	270	270
q15	517	487	468	468
q16	470	402	429	402
q17	1744	1481	1475	1475
q18	7622	7501	7338	7338
q19	1719	1506	1521	1506
q20	1958	1751	1762	1751
q21	5057	4705	4865	4705
q22	576	503	500	500
Total cold run time: 71747 ms
Total hot run time: 53785 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187790 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fcd69a9bd4e5a6eb30664da6f2b047f5447741c9, data reload: false

query1	908	366	350	350
query2	7131	2395	2390	2390
query3	6660	209	219	209
query4	24120	21189	21472	21189
query5	4178	416	410	410
query6	264	195	176	176
query7	4584	289	288	288
query8	242	187	190	187
query9	8693	2438	2428	2428
query10	438	273	252	252
query11	14920	14239	14208	14208
query12	144	91	91	91
query13	1651	395	373	373
query14	8829	8700	7814	7814
query15	259	175	170	170
query16	8181	267	261	261
query17	1853	549	539	539
query18	2089	274	267	267
query19	206	145	146	145
query20	93	91	87	87
query21	199	138	128	128
query22	5029	4844	4848	4844
query23	34289	33568	33601	33568
query24	11545	2941	2988	2941
query25	651	374	361	361
query26	1723	153	156	153
query27	2971	319	332	319
query28	7646	2066	2056	2056
query29	987	627	598	598
query30	300	150	154	150
query31	974	764	729	729
query32	89	53	54	53
query33	749	254	245	245
query34	1056	484	493	484
query35	800	689	662	662
query36	1071	893	917	893
query37	157	68	66	66
query38	2914	2786	2823	2786
query39	1629	1574	1567	1567
query40	276	123	124	123
query41	41	40	42	40
query42	107	97	95	95
query43	578	579	555	555
query44	1228	733	740	733
query45	267	253	251	251
query46	1061	708	713	708
query47	1933	1878	1915	1878
query48	402	310	295	295
query49	1172	393	400	393
query50	769	396	388	388
query51	6858	6845	6693	6693
query52	104	92	88	88
query53	346	283	277	277
query54	1008	432	445	432
query55	76	74	72	72
query56	238	233	231	231
query57	1250	1155	1151	1151
query58	250	195	202	195
query59	3575	3502	3028	3028
query60	267	232	235	232
query61	93	94	88	88
query62	677	465	469	465
query63	318	285	283	283
query64	9743	7454	7351	7351
query65	3132	3085	3076	3076
query66	1387	344	352	344
query67	15375	15299	15254	15254
query68	4620	533	525	525
query69	482	314	308	308
query70	1197	1118	1075	1075
query71	403	262	269	262
query72	7454	2550	2406	2406
query73	708	326	320	320
query74	6577	6101	6157	6101
query75	3447	2638	2622	2622
query76	2863	971	993	971
query77	389	258	260	258
query78	10646	10123	10102	10102
query79	2370	517	511	511
query80	1037	436	433	433
query81	519	224	216	216
query82	701	92	93	92
query83	234	159	161	159
query84	232	86	84	84
query85	1713	273	267	267
query86	519	320	303	303
query87	3346	3117	3130	3117
query88	4454	2485	2464	2464
query89	482	383	388	383
query90	2027	194	194	194
query91	135	109	111	109
query92	62	52	120	52
query93	1781	506	497	497
query94	1161	181	186	181
query95	391	296	293	293
query96	600	280	276	276
query97	3192	3021	2960	2960
query98	229	228	218	218
query99	1121	875	899	875
Total cold run time: 287845 ms
Total hot run time: 187790 ms

@starocean999 starocean999 marked this pull request as ready for review May 14, 2024 07:25
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants