Skip to content

[fix](nereids)4 phase agg may lost parameter in some case #34816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 1 commit into from
May 15, 2024
Merged

[fix](nereids)4 phase agg may lost parameter in some case #34816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1766,7 +1766,7 @@ private List<PhysicalHashAggregate<? extends Plan>> fourPhaseAggregateWithDistin
AggregateFunction nonDistinct = aggregateFunction
.withDistinctAndChildren(false, ImmutableList.copyOf(aggChild));
AggregateExpression nonDistinctAggExpr = new AggregateExpression(nonDistinct,
distinctLocalParam, aggregateFunction.child(0));
distinctLocalParam, aggregateFunction);
return nonDistinctAggExpr;
} else {
needUpdateSlot.add(aggregateFunction);
Expand Down
2 changes: 2 additions & 0 deletions regression-test/suites/nereids_syntax_p0/agg_4_phase.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,6 @@ suite("agg_4_phase") {
contains ":VAGGREGATE (update serialize)"
}
qt_4phase (test_sql)

sql """select GROUP_CONCAT(distinct name, " ") from agg_4_phase_tbl;"""
}