[improvement](mtmv) Add id to statistics map in statement context for cost estimation later #35436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cost estimation later
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41317 ms |
morrySnow
reviewed
May 27, 2024
| // Maybe return null, which means the id according statistics should calc normally rather than getting | ||
| // form this map | ||
| // id maybe relation id or cteId or other type of id | ||
| private final Map<Pair<Id, Class<? extends Id>>, Statistics> idToStatisticsMap = new LinkedHashMap<>(); |
Contributor
There was a problem hiding this comment.
just support relation id now
TPC-DS: Total hot run time: 169253 ms |
ClickBench: Total hot run time: 31.16 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41713 ms |
morrySnow
approved these changes
May 27, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 171030 ms |
ClickBench: Total hot run time: 30.64 s |
englefly
reviewed
May 27, 2024
englefly
approved these changes
May 28, 2024
morrySnow
approved these changes
May 28, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 28, 2024
… cost estimation later (#35436) Add id to statistics map in statement context for cost estimation later this helps to improve the probability to use materialized view when query a single table with aggregate and many filter
dataroaring
pushed a commit
that referenced
this pull request
May 28, 2024
… cost estimation later (#35436) Add id to statistics map in statement context for cost estimation later this helps to improve the probability to use materialized view when query a single table with aggregate and many filter
morrySnow
pushed a commit
that referenced
this pull request
Jun 3, 2024
…ats to mv scan plan based (#35749) this is brought by #35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ats to mv scan plan based (#35749) this is brought by #35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 7, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
morningman
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 8, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 14, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add id to statistics map in statement context for cost estimation later
this helps to improve the probability to use materialized view when query a single table with aggregate and many filter
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...