[fix](mtmv) Mapping materialization statistics's expressionToColumnStats to mv scan plan based #35749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be same as the scan plan output
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
seawinde
changed the title
Contributor
Author
|
run buildall |
starocean999
approved these changes
Jun 3, 2024
starocean999
approved these changes
Jun 3, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41537 ms |
TPC-DS: Total hot run time: 172459 ms |
Contributor
|
run p0 |
ClickBench: Total hot run time: 30.25 s |
morrySnow
approved these changes
Jun 3, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ats to mv scan plan based (#35749) this is brought by #35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 7, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
morningman
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 8, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jun 14, 2024
…ats to mv scan plan based (apache#35749) this is brought by apache#35436 in the method `MaterializationContext#getPlanStatistics` this get the materialization context orginal plan statistics. but the `expressionToColumnStats` in statistics is the slot of original plan. We want the statistics of original plan but the `expressionToColumnStats` in which should be mv scan plan based actually. So add the method `MaterializationContext#normalizeStatisticsColumnExpression`. when after generate the PlanStatistics in MaterializationContext, should call the normalizeStatisticsColumnExpression method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this is brought by #35436
in the method
MaterializationContext#getPlanStatisticsthis get the materialization context orginal plan statistics.but the
expressionToColumnStatsin statistics is the slot of original plan.We want the statistics of original plan but the
expressionToColumnStatsin which should be mv scan plan based actually.So add the method
MaterializationContext#normalizeStatisticsColumnExpression. when after generate the PlanStatisticsin MaterializationContext, should call the normalizeStatisticsColumnExpression method.