[fix](fe) Add check editlog size mechanism for backupJob #35653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
swjtu-zhanglei
force-pushed
the
master-fix5
branch
from
1f95585 to
7a66e22
Compare
Contributor
Author
|
run buildall |
gavinchou
reviewed
May 30, 2024
| } | ||
|
|
||
| @Override | ||
| public boolean exceedMaxJournalSize(short op, Writable writable) throws IOException { |
Contributor
There was a problem hiding this comment.
Is param op mandatory for this check?
gavinchou
reviewed
May 30, 2024
| return ""; | ||
| } | ||
|
|
||
| public boolean exceedMaxJournalSize(BackupJob job) { |
Contributor
There was a problem hiding this comment.
It seems that we can change it to the following form
Suggested change
| public boolean exceedMaxJournalSize(BackupJob job) { | |
| public boolean exceedMaxJournalSize(Writable w) { |
gavinchou
reviewed
May 30, 2024
| return true; | ||
| } | ||
|
|
||
| private boolean exceedMaxJournalSize(short op, Writable writable) throws IOException { |
Contributor
There was a problem hiding this comment.
This function is redundant if we do not care about op
Contributor
Author
There was a problem hiding this comment.
This function is redundant if we do not care about
op
opCode is important, we will print opCode
Contributor
|
please add a regression test in p2. |
TPC-H: Total hot run time: 41182 ms |
TPC-DS: Total hot run time: 168366 ms |
ClickBench: Total hot run time: 30.3 s |
dataroaring
changed the title
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Jun 3, 2024
Contributor
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40871 ms |
TPC-DS: Total hot run time: 170773 ms |
ClickBench: Total hot run time: 30.32 s |
* When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow
Contributor
|
run buildall |
TPC-H: Total hot run time: 41136 ms |
TPC-DS: Total hot run time: 169986 ms |
ClickBench: Total hot run time: 30.92 s |
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
* When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
* When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 8, 2024
* When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow
dataroaring
pushed a commit
that referenced
this pull request
Jul 9, 2024
…7466) * When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 10, 2024
* When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow
dataroaring
pushed a commit
that referenced
this pull request
Jul 12, 2024
…7628) * When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
… (apache#37628) * When creating a backupJob with huge of tables in a database, it can cause backupJob editlog size over 2GB and bdbje will throw exception because of ByteBuffer overflow ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx