-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fe) Add check editlog size mechanism for backupJob #35653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2102,4 +2102,17 @@ public String getNotReadyReason() { | |||||
| } | ||||||
| return ""; | ||||||
| } | ||||||
|
|
||||||
| public boolean exceedMaxJournalSize(BackupJob job) { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems that we can change it to the following form
Suggested change
|
||||||
| try { | ||||||
| return exceedMaxJournalSize(OperationType.OP_BACKUP_JOB, job); | ||||||
| } catch (Exception e) { | ||||||
| LOG.warn("exceedMaxJournalSize exception:", e); | ||||||
| } | ||||||
| return true; | ||||||
| } | ||||||
|
|
||||||
| private boolean exceedMaxJournalSize(short op, Writable writable) throws IOException { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function is redundant if we do not care about
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
opCode is important, we will print opCode |
||||||
| return journal.exceedMaxJournalSize(op, writable); | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is param
opmandatory for this check?