[revert](memory) Revert fix jdk17 and jemalloc hook not compatible on some env #35694

xinyiZzz · 2024-05-31T03:26:56Z

Proposed changes

After #35557, jdk17 and jemalloc compatibility problems not exist.

doris-robot · 2024-05-31T03:27:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions

clang-tidy made some suggestions

be/src/runtime/memory/tcmalloc_hook.h

github-actions · 2024-05-31T03:49:17Z

PR approved by anyone and no changes requested.

github-actions · 2024-05-31T04:28:28Z

clang-tidy review says "All clean, LGTM! 👍"

…pache#34886)" This reverts commit 75fee8f.

…)" This reverts commit 667f5b5.

…apache#34643)" This reverts commit 875b85c.

…ome envs (apache#34578)" This reverts commit 673c61a.

xinyiZzz · 2024-05-31T07:29:41Z

run buildall

github-actions · 2024-05-31T07:34:51Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-31T07:36:20Z

clang-tidy review says "All clean, LGTM! 👍"

xinyiZzz · 2024-05-31T07:39:32Z

run buildall

github-actions · 2024-05-31T07:44:23Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-31T08:48:32Z

TPC-H: Total hot run time: 41701 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab8259c78b496952cc4883a03850673f6458b218, data reload: false

------ Round 1 ----------------------------------
q1	17606	4475	4343	4343
q2	2008	190	197	190
q3	10483	1253	1124	1124
q4	10188	859	827	827
q5	7510	2733	2760	2733
q6	233	138	136	136
q7	988	630	615	615
q8	9209	2146	2132	2132
q9	9423	6763	6760	6760
q10	9185	4022	3935	3935
q11	452	251	242	242
q12	455	230	236	230
q13	17201	3334	3224	3224
q14	260	219	227	219
q15	520	485	478	478
q16	535	414	403	403
q17	1009	740	758	740
q18	8308	7861	7865	7861
q19	9375	1659	1608	1608
q20	646	319	330	319
q21	5202	4095	3254	3254
q22	399	328	331	328
Total cold run time: 121195 ms
Total hot run time: 41701 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4679	4431	4492	4431
q2	379	278	278	278
q3	3150	2891	2849	2849
q4	2000	1660	1735	1660
q5	5420	5373	5526	5373
q6	217	130	131	130
q7	2189	1828	1827	1827
q8	3273	3430	3442	3430
q9	8662	8554	8643	8554
q10	4105	3959	3847	3847
q11	586	497	477	477
q12	760	589	605	589
q13	15872	3173	3157	3157
q14	310	271	278	271
q15	531	472	474	472
q16	512	424	460	424
q17	1834	1558	1504	1504
q18	8158	7602	7336	7336
q19	1697	1619	1521	1521
q20	2003	1767	1785	1767
q21	4993	4753	4767	4753
q22	597	498	532	498
Total cold run time: 71927 ms
Total hot run time: 55148 ms

doris-robot · 2024-05-31T08:59:08Z

TPC-DS: Total hot run time: 168866 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab8259c78b496952cc4883a03850673f6458b218, data reload: false

query1	919	379	379	379
query2	6437	2387	2318	2318
query3	6643	204	202	202
query4	19918	17350	17218	17218
query5	4119	414	416	414
query6	259	157	157	157
query7	4580	296	287	287
query8	321	289	265	265
query9	8598	2389	2380	2380
query10	450	279	266	266
query11	10508	10010	9966	9966
query12	137	87	89	87
query13	1641	351	348	348
query14	9811	6802	6822	6802
query15	230	201	180	180
query16	7221	268	261	261
query17	1348	514	507	507
query18	1916	275	269	269
query19	201	152	152	152
query20	91	82	84	82
query21	193	125	129	125
query22	4215	4024	3790	3790
query23	33511	33394	33108	33108
query24	7024	2885	2887	2885
query25	536	369	362	362
query26	706	157	155	155
query27	1993	327	334	327
query28	3948	2097	2068	2068
query29	837	604	597	597
query30	227	160	148	148
query31	949	759	751	751
query32	93	52	55	52
query33	497	264	279	264
query34	857	486	485	485
query35	721	614	626	614
query36	1041	921	886	886
query37	105	67	67	67
query38	2903	2763	2726	2726
query39	835	792	784	784
query40	201	128	124	124
query41	49	47	44	44
query42	103	96	96	96
query43	581	547	563	547
query44	1056	739	735	735
query45	185	169	170	169
query46	1068	746	692	692
query47	1857	1741	1765	1741
query48	367	288	301	288
query49	761	382	385	382
query50	771	389	404	389
query51	6808	6558	6703	6558
query52	106	93	93	93
query53	359	280	282	280
query54	539	457	425	425
query55	73	73	72	72
query56	264	252	243	243
query57	1098	1018	1019	1018
query58	227	225	214	214
query59	3362	3043	2984	2984
query60	292	256	262	256
query61	97	93	88	88
query62	554	440	454	440
query63	319	281	286	281
query64	8478	2240	1774	1774
query65	3173	3085	3092	3085
query66	885	341	327	327
query67	15198	14582	14935	14582
query68	4513	530	539	530
query69	443	269	307	269
query70	1098	1133	1040	1040
query71	361	262	270	262
query72	7599	5504	2759	2759
query73	706	326	321	321
query74	5919	5617	5605	5605
query75	3291	2616	2641	2616
query76	2240	1003	1028	1003
query77	382	263	261	261
query78	10190	9976	9822	9822
query79	2557	523	509	509
query80	1124	433	431	431
query81	528	226	223	223
query82	743	97	101	97
query83	249	174	173	173
query84	249	85	83	83
query85	1334	340	329	329
query86	495	314	323	314
query87	3321	3126	3169	3126
query88	4257	2368	2373	2368
query89	492	387	394	387
query90	2079	191	193	191
query91	137	108	111	108
query92	70	52	52	52
query93	2227	504	496	496
query94	1149	192	190	190
query95	414	331	326	326
query96	594	273	264	264
query97	3188	3033	2973	2973
query98	252	226	218	218
query99	1168	859	860	859
Total cold run time: 258739 ms
Total hot run time: 168866 ms

doris-robot · 2024-05-31T09:04:40Z

ClickBench: Total hot run time: 30.58 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab8259c78b496952cc4883a03850673f6458b218, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.06
query5	0.50	0.48	0.50
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.49	0.50
query10	0.54	0.55	0.55
query11	0.16	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.58	0.61
query14	0.77	0.77	0.79
query15	0.83	0.82	0.82
query16	0.36	0.38	0.36
query17	0.98	0.97	0.95
query18	0.21	0.25	0.21
query19	1.78	1.77	1.68
query20	0.02	0.01	0.02
query21	15.49	0.70	0.67
query22	4.97	6.49	1.99
query23	18.23	1.32	1.28
query24	1.94	0.22	0.20
query25	0.15	0.08	0.09
query26	0.27	0.16	0.16
query27	0.07	0.07	0.08
query28	13.38	1.02	1.00
query29	13.36	3.30	3.29
query30	0.24	0.05	0.06
query31	2.86	0.39	0.38
query32	3.27	0.47	0.47
query33	2.92	2.89	2.90
query34	17.18	4.47	4.43
query35	4.50	4.49	4.72
query36	0.65	0.49	0.47
query37	0.18	0.16	0.17
query38	0.15	0.15	0.14
query39	0.05	0.03	0.03
query40	0.16	0.14	0.14
query41	0.09	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 110.85 s
Total hot run time: 30.58 s

doris-robot · 2024-05-31T09:10:36Z

TeamCity be ut coverage result:
Function Coverage: 36.28% (9231/25442)
Line Coverage: 27.64% (75708/273951)
Region Coverage: 26.85% (39198/145991)
Branch Coverage: 23.61% (19899/84284)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ab8259c78b496952cc4883a03850673f6458b218_ab8259c78b496952cc4883a03850673f6458b218/report/index.html

xinyiZzz · 2024-06-19T08:45:55Z

run buildall

github-actions · 2024-06-19T08:51:42Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-06-19T09:40:36Z

TPC-H: Total hot run time: 40277 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7bfb7f4c5b37cdec12ac3e414fb6174056f91eec, data reload: false

------ Round 1 ----------------------------------
q1	17784	4659	4418	4418
q2	2578	190	197	190
q3	11489	1190	1123	1123
q4	10558	798	898	798
q5	7813	2717	2720	2717
q6	233	142	138	138
q7	990	627	633	627
q8	9565	2130	2132	2130
q9	8900	6504	6513	6504
q10	9032	3784	3749	3749
q11	454	236	246	236
q12	420	241	245	241
q13	17809	2991	3002	2991
q14	276	226	221	221
q15	520	472	466	466
q16	523	385	370	370
q17	992	658	805	658
q18	8126	7456	7374	7374
q19	6734	1490	1541	1490
q20	656	336	326	326
q21	5015	3177	3255	3177
q22	381	333	343	333
Total cold run time: 120848 ms
Total hot run time: 40277 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4407	4295	4210	4210
q2	364	278	275	275
q3	3028	2794	2794	2794
q4	1867	1614	1646	1614
q5	5286	5281	5310	5281
q6	215	127	130	127
q7	2096	1732	1728	1728
q8	3202	3332	3331	3331
q9	8334	8359	8347	8347
q10	3929	3674	3690	3674
q11	573	491	496	491
q12	769	609	624	609
q13	16482	2984	2983	2983
q14	275	272	253	253
q15	523	472	473	472
q16	460	423	424	423
q17	1774	1504	1466	1466
q18	7579	7506	7303	7303
q19	1740	1571	1631	1571
q20	1975	1791	1779	1779
q21	4797	4686	4842	4686
q22	630	536	577	536
Total cold run time: 70305 ms
Total hot run time: 53953 ms

doris-robot · 2024-06-19T09:51:30Z

TPC-DS: Total hot run time: 169605 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7bfb7f4c5b37cdec12ac3e414fb6174056f91eec, data reload: false

query1	947	385	367	367
query2	6454	2349	2262	2262
query3	6648	203	218	203
query4	18993	17524	17421	17421
query5	4143	484	461	461
query6	257	163	157	157
query7	4582	291	291	291
query8	307	278	284	278
query9	8506	2423	2396	2396
query10	617	327	291	291
query11	10841	10187	10280	10187
query12	142	96	86	86
query13	1653	400	359	359
query14	10211	6252	6232	6232
query15	233	188	196	188
query16	7806	265	262	262
query17	1501	536	534	534
query18	1957	275	273	273
query19	200	161	148	148
query20	91	81	80	80
query21	208	129	122	122
query22	4599	4213	4307	4213
query23	33662	33042	33188	33042
query24	12199	2814	2883	2814
query25	665	349	355	349
query26	1806	152	155	152
query27	3095	316	312	312
query28	7842	2060	2050	2050
query29	1139	619	606	606
query30	271	149	149	149
query31	953	737	745	737
query32	99	53	56	53
query33	774	330	282	282
query34	963	471	457	457
query35	725	615	629	615
query36	1093	948	966	948
query37	299	69	70	69
query38	2868	2753	2752	2752
query39	859	780	819	780
query40	287	130	127	127
query41	56	54	57	54
query42	123	99	100	99
query43	590	543	532	532
query44	1272	712	714	712
query45	203	169	167	167
query46	1087	722	724	722
query47	1867	1802	1806	1802
query48	365	307	295	295
query49	1201	403	398	398
query50	770	373	387	373
query51	6855	6856	6699	6699
query52	136	94	92	92
query53	353	292	291	291
query54	953	434	430	430
query55	73	74	73	73
query56	287	259	260	259
query57	1186	1052	1078	1052
query58	269	230	245	230
query59	3404	3121	3112	3112
query60	288	292	277	277
query61	92	89	96	89
query62	656	434	445	434
query63	319	292	286	286
query64	9876	2220	1723	1723
query65	3180	3076	3090	3076
query66	1406	336	334	334
query67	15530	15111	14931	14931
query68	4499	532	532	532
query69	453	301	302	301
query70	1079	1164	1095	1095
query71	389	270	270	270
query72	7129	2762	2620	2620
query73	737	321	324	321
query74	5993	5560	5666	5560
query75	3374	2654	2634	2634
query76	2922	875	928	875
query77	459	300	301	300
query78	10280	9784	9922	9784
query79	2216	508	507	507
query80	1157	462	457	457
query81	577	223	217	217
query82	695	102	105	102
query83	237	167	182	167
query84	231	83	85	83
query85	1985	282	279	279
query86	487	325	321	321
query87	3298	3160	3086	3086
query88	3585	2337	2331	2331
query89	480	387	385	385
query90	1824	189	194	189
query91	141	113	111	111
query92	67	50	50	50
query93	2302	509	506	506
query94	1266	199	199	199
query95	412	318	338	318
query96	588	266	265	265
query97	3252	3065	3038	3038
query98	210	205	198	198
query99	1313	866	857	857
Total cold run time: 276529 ms
Total hot run time: 169605 ms

doris-robot · 2024-06-19T09:57:01Z

ClickBench: Total hot run time: 30.9 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7bfb7f4c5b37cdec12ac3e414fb6174056f91eec, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.05
query3	0.23	0.06	0.06
query4	1.66	0.07	0.09
query5	0.50	0.49	0.51
query6	1.13	0.74	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.54	0.55	0.54
query11	0.16	0.11	0.12
query12	0.14	0.12	0.13
query13	0.60	0.59	0.61
query14	0.78	0.79	0.77
query15	0.84	0.81	0.82
query16	0.37	0.37	0.36
query17	1.04	1.03	0.99
query18	0.21	0.25	0.23
query19	1.81	1.68	1.74
query20	0.01	0.01	0.01
query21	15.41	0.65	0.64
query22	4.07	7.00	2.16
query23	18.31	1.37	1.22
query24	2.14	0.21	0.22
query25	0.16	0.09	0.08
query26	0.26	0.18	0.18
query27	0.08	0.08	0.08
query28	13.31	1.02	1.01
query29	12.63	3.35	3.34
query30	0.26	0.06	0.06
query31	2.86	0.38	0.38
query32	3.25	0.47	0.47
query33	2.92	2.92	2.96
query34	17.25	4.43	4.41
query35	4.54	4.50	4.48
query36	0.65	0.47	0.47
query37	0.18	0.15	0.16
query38	0.15	0.15	0.15
query39	0.04	0.04	0.03
query40	0.18	0.14	0.14
query41	0.10	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.61 s
Total hot run time: 30.9 s

doris-robot · 2024-06-19T10:10:08Z

TeamCity be ut coverage result:
Function Coverage: 36.46% (9005/24696)
Line Coverage: 28.01% (73793/263442)
Region Coverage: 27.49% (38331/139434)
Branch Coverage: 24.19% (19540/80786)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7bfb7f4c5b37cdec12ac3e414fb6174056f91eec_7bfb7f4c5b37cdec12ac3e414fb6174056f91eec/report/index.html

github-actions · 2024-06-20T07:15:18Z

PR approved by at least one committer and no changes requested.

morningman

LGTM

… some env (apache#35694) After apache#35557, jdk17 and jemalloc compatibility problems not exist.

… some env (#35694) After #35557, jdk17 and jemalloc compatibility problems not exist.

github-actions bot reviewed May 31, 2024

View reviewed changes

be/src/runtime/memory/tcmalloc_hook.h Show resolved Hide resolved

w41ter previously approved these changes May 31, 2024

View reviewed changes

github-actions bot added the reviewed label May 31, 2024

xinyiZzz added 6 commits May 31, 2024 15:29

Revert "[fix](memory) Fix BE compile in Mac with no prefix Jemalloc (a…

6e3fed9

…pache#34886)" This reverts commit 75fee8f.

Revert "[fix](memory) Fix BE compile in Mac with Jemalloc (apache#34750…

f174bd6

…)" This reverts commit 667f5b5.

Revert "[fix](memory) Fix build.sh thirdparty path error for jemalloc (…

2e98559

…apache#34643)" This reverts commit 875b85c.

Revert "[fix](memory) Fix jdk17 and jemalloc hook not compatible on s…

a0e78b1

…ome envs (apache#34578)" This reverts commit 673c61a.

Revert Fix jdk17 and jemalloc hook not compatible on some envs

b9c92e5

Revert Fix jdk17 and jemalloc hook not compatible on some envs

9bfb8e1

xinyiZzz force-pushed the 20240529_revert_jemalloc_prefix branch from 792b5f3 to 9bfb8e1 Compare May 31, 2024 07:29

Revert Fix jdk17 and jemalloc hook not compatible on some envs

ab8259c

xinyiZzz dismissed w41ter’s stale review via ab8259c June 17, 2024 03:44

Merge branch 'master' into 20240529_revert_jemalloc_prefix

7bfb7f4

w41ter approved these changes Jun 20, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2024

morningman approved these changes Jun 20, 2024

View reviewed changes

xinyiZzz merged commit 09e5d35 into apache:master Jun 20, 2024

xinyiZzz added the dev/2.1.x label Jun 20, 2024

iszhangpch pushed a commit to iszhangpch/doris-p that referenced this pull request Jun 21, 2024

[revert](memory) Revert fix jdk17 and jemalloc hook not compatible on…

1af67cc

… some env (apache#35694) After apache#35557, jdk17 and jemalloc compatibility problems not exist.

xinyiZzz removed the dev/2.1.x label Jun 21, 2024

dataroaring pushed a commit that referenced this pull request Jun 21, 2024

[revert](memory) Revert fix jdk17 and jemalloc hook not compatible on…

5848cd9

… some env (#35694) After #35557, jdk17 and jemalloc compatibility problems not exist.

xinyiZzz mentioned this pull request Jul 22, 2024

[Bug] BE crash at JEMALLOC free #36641

Closed

3 tasks

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

xinyiZzz mentioned this pull request Dec 17, 2024

[revert](memory) Revert disable Jemalloc Hook #45507

Closed

16 tasks

[revert](memory) Revert fix jdk17 and jemalloc hook not compatible on some env #35694

[revert](memory) Revert fix jdk17 and jemalloc hook not compatible on some env #35694

Uh oh!

Conversation

xinyiZzz commented May 31, 2024

Proposed changes

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

xinyiZzz commented May 31, 2024

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

xinyiZzz commented May 31, 2024

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

xinyiZzz commented Jun 19, 2024

Uh oh!

github-actions bot commented Jun 19, 2024

Uh oh!

doris-robot commented Jun 19, 2024

Uh oh!

doris-robot commented Jun 19, 2024

Uh oh!

doris-robot commented Jun 19, 2024

Uh oh!

doris-robot commented Jun 19, 2024

Uh oh!

github-actions bot commented Jun 20, 2024

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants