-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Nereids) unix_timestamp compute signature and fold const is wrong #35727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41754 ms |
TPC-DS: Total hot run time: 171730 ms |
ClickBench: Total hot run time: 30.53 s |
|
run cloud_p1 |
4fe7a51 to
83acb92
Compare
|
run buildall |
TPC-H: Total hot run time: 41717 ms |
TPC-DS: Total hot run time: 169479 ms |
ClickBench: Total hot run time: 30.75 s |
|
run feut |
|
jshell> Integer.parseInt("3.14159")
| 异常错误 java.lang.NumberFormatException:For input string: "3.14159"
| at NumberFormatException.forInputString (NumberFormatException.java:67)
| at Integer.parseInt (Integer.java:668)
| at Integer.parseInt (Integer.java:786)
| at (#1:1) |
83acb92 to
b8acd12
Compare
|
run buildall |
TPC-H: Total hot run time: 40549 ms |
TPC-DS: Total hot run time: 170895 ms |
|
run feut |
ClickBench: Total hot run time: 30.46 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
b8acd12 to
95ab9ce
Compare
|
run buildall |
TPC-H: Total hot run time: 40781 ms |
TPC-DS: Total hot run time: 169436 ms |
ClickBench: Total hot run time: 30.62 s |
|
PR approved by at least one committer and no changes requested. |
…ng (apache#35727) 1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827 we already have p0 for this case, but our regression framework has bug that it report success when compare decimal type if real result lose scale
we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose scale