-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement](function) support unix_timestamp with float #26827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
|
run buildall |
|
@Gabriel39 @morrySnow PTAL |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
--------- Co-authored-by: YangWithU <plzw8@outlook.com>
--------- Co-authored-by: YangWithU <plzw8@outlook.com>
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827
…ng (apache#35727) 1. compute signature should call super#computeSignature first 2. fold const return type not changed after signature changed in apache#26827 we already have p0 for this case, but our regression framework has bug that it report success when compare decimal type if real result lose scale
Proposed changes
Issue Number: close #24382
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...