Skip to content

[Bug](materialized-view) fix divide double can not match mv #23504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 3 commits into from
Aug 28, 2023
Merged

[Bug](materialized-view) fix divide double can not match mv #23504

BiteTheDDDDt merged 3 commits into from
Aug 28, 2023

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Aug 25, 2023

Proposed changes

fix divide double can not match mv

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 25, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 25, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.75 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162085123 Bytes

HappenLee
HappenLee previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 28, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 28, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.81 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162088365 Bytes

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 28, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 28, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.33 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162216154 Bytes

HappenLee
HappenLee approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 8e4c0d1 into apache:master Aug 28, 2023
xiaokang pushed a commit that referenced this pull request Aug 30, 2023
@BiteTheDDDDt @xiaokang
[Bug](materialized-view) fix divide double can not match mv (#23504)
1c65098 
* fix divide double can not match mv

* fix

* fix
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Dec 28, 2023
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
3f7492f 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal
@morrySnow morrySnow mentioned this pull request Dec 28, 2023
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Dec 28, 2023
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
3bb1b72 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Dec 28, 2023
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
86fe51a 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Dec 29, 2023
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
e286733 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jan 5, 2024
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
dba3fd8 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jan 5, 2024
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
fea04bf 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jan 8, 2024
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
082e2a1 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jan 8, 2024
@morrySnow
[fix](Nereids) create double literal when create decimal literal failed
483998a 
remove float and double literal toString and getStringValue introduced by
PR apache#23504 and PR apache#23271
These functions lead to wrong cast result of double and float literal

fix string cast to datetimev2 error introduced by PR apache#26827
we should cast to exactly scale of datetimev2 when cast string to it
morrySnow added a commit that referenced this pull request Jan 9, 2024
@morrySnow
[fix](Nereids) create double literal when create decimal literal fail…
6a4cb51 
…ed (#28959)

FIX
1. remove float and double literal toString and getStringValue introduced by
  PR #23504 and PR #23271
  These functions lead to wrong cast result of double and float literal
2. fix compute signature for datetimev2 always produce scale 6
3. fix stats calculator failed when generate node stats with two same column
4. constant fold on fe failed when cast double to integral

TODO
after fix the first problem, some mv matching not work well, fix them later
- test_dup_mv_div
- test_dup_mv_json
- test_tcu
yiguolei pushed a commit that referenced this pull request Jan 12, 2024
@morrySnow @Doris-Extras
[fix](Nereids) create double literal when create decimal literal fail…
9cbb55d 
…ed (#28959)

FIX
1. remove float and double literal toString and getStringValue introduced by
  PR #23504 and PR #23271
  These functions lead to wrong cast result of double and float literal
2. fix compute signature for datetimev2 always produce scale 6
3. fix stats calculator failed when generate node stats with two same column
4. constant fold on fe failed when cast double to integral

TODO
after fix the first problem, some mv matching not work well, fix them later
- test_dup_mv_div
- test_dup_mv_json
- test_tcu
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@morrySnow @HappenLee
[fix](Nereids) create double literal when create decimal literal fail…
73550cb 
…ed (apache#28959)

FIX
1. remove float and double literal toString and getStringValue introduced by
  PR apache#23504 and PR apache#23271
  These functions lead to wrong cast result of double and float literal
2. fix compute signature for datetimev2 always produce scale 6
3. fix stats calculator failed when generate node stats with two same column
4. constant fold on fe failed when cast double to integral

TODO
after fix the first problem, some mv matching not work well, fix them later
- test_dup_mv_div
- test_dup_mv_json
- test_tcu
@BiteTheDDDDt BiteTheDDDDt deleted the fix_0825 branch January 20, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt @hello-stephen @HappenLee @zhangstar333 @xiaokang