[fix](Nereids) create double literal when create decimal literal failed #28959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
force-pushed
the
decimal_double
branch
from
48c2e8d to
2b95457
Compare
Contributor
Author
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
force-pushed
the
decimal_double
branch
from
2b95457 to
1614960
Compare
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
force-pushed
the
decimal_double
branch
from
1614960 to
3f7492f
Compare
Contributor
Author
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
force-pushed
the
decimal_double
branch
2 times, most recently
from
3bb1b72 to
86fe51a
Compare
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
force-pushed
the
decimal_double
branch
from
86fe51a to
e286733
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
morrySnow
force-pushed
the
decimal_double
branch
from
e286733 to
dba3fd8
Compare
Contributor
Author
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal fix string cast to datetimev2 error introduced by PR apache#26827 we should cast to exactly scale of datetimev2 when cast string to it
morrySnow
force-pushed
the
decimal_double
branch
from
082e2a1 to
483998a
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38271 ms |
TPC-H: Total hot run time: 38857 ms |
TPC-DS: Total hot run time: 184384 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38245 ms |
TPC-DS: Total hot run time: 183738 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run p0 |
Contributor
Author
|
run pipelinex_p0 |
keanji-x
approved these changes
Jan 9, 2024
englefly
approved these changes
Jan 9, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Jan 9, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jan 12, 2024
…ed (#28959) FIX 1. remove float and double literal toString and getStringValue introduced by PR #23504 and PR #23271 These functions lead to wrong cast result of double and float literal 2. fix compute signature for datetimev2 always produce scale 6 3. fix stats calculator failed when generate node stats with two same column 4. constant fold on fe failed when cast double to integral TODO after fix the first problem, some mv matching not work well, fix them later - test_dup_mv_div - test_dup_mv_json - test_tcu
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…ed (apache#28959) FIX 1. remove float and double literal toString and getStringValue introduced by PR apache#23504 and PR apache#23271 These functions lead to wrong cast result of double and float literal 2. fix compute signature for datetimev2 always produce scale 6 3. fix stats calculator failed when generate node stats with two same column 4. constant fold on fe failed when cast double to integral TODO after fix the first problem, some mv matching not work well, fix them later - test_dup_mv_div - test_dup_mv_json - test_tcu
16 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR [Bug](materialized-view) fix divide double can not match mv #23504 and PR [feature](nereids)support subquery in select list #23271
These functions lead to wrong cast result of double and float literal
TODO
after fix the first problem, some mv matching not work well
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...