[fix](function) fix date_format and from_unixtime core when meet long format string #35883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TPC-H: Total hot run time: 41096 ms |
TPC-DS: Total hot run time: 168908 ms |
ClickBench: Total hot run time: 31.59 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41794 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 173175 ms |
ClickBench: Total hot run time: 30.45 s |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41385 ms |
TPC-DS: Total hot run time: 171704 ms |
ClickBench: Total hot run time: 30.53 s |
HappenLee
reviewed
Jun 6, 2024
HappenLee
reviewed
Jun 6, 2024
Contributor
Author
|
run buildall |
zclllyybb
changed the title
TPC-H: Total hot run time: 41025 ms |
TPC-DS: Total hot run time: 171259 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.84 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40538 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 173881 ms |
ClickBench: Total hot run time: 30.5 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Mryange
approved these changes
Jun 11, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 12, 2024
… format string (apache#35883) ## Proposed changes before: crash now: ```sql mysql> SELECT DATE_FORMAT('2011-06-24', '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b'); +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | date_format(cast('2011-06-24' as DATETIMEV2(0)), '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b') | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | NULL | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.80 sec) ```
dataroaring
pushed a commit
that referenced
this pull request
Jun 13, 2024
… format string (#35883) ## Proposed changes before: crash now: ```sql mysql> SELECT DATE_FORMAT('2011-06-24', '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b'); +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | date_format(cast('2011-06-24' as DATETIMEV2(0)), '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b') | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | NULL | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.80 sec) ```
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jul 2, 2024
… format string (apache#35883) before: crash now: ```sql mysql> SELECT DATE_FORMAT('2011-06-24', '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b'); +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | date_format(cast('2011-06-24' as DATETIMEV2(0)), '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b') | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | NULL | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.80 sec) ```
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jul 2, 2024
… format string (apache#35883) before: crash now: ```sql mysql> SELECT DATE_FORMAT('2011-06-24', '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b'); +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | date_format(cast('2011-06-24' as DATETIMEV2(0)), '%f %V %f %l %V %I %S %p %w %r %j %f %l %I %D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r %j %a %h %s %m %a %v %u %b') | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | NULL | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.80 sec) ```
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…et long format string (apache#35883) (apache#37178) pick apache#35883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
before:
crash
now: