[feature](mtmv) Support to use mv group dimension when query aggregate function is distinct #36318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function is distinct
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39852 ms |
TPC-DS: Total hot run time: 171638 ms |
ClickBench: Total hot run time: 30.74 s |
morrySnow
approved these changes
Jun 17, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Jun 17, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
…e function is distinct (#36318) ## Proposed changes This extend the query rewrite by materialized view ability For example mv def is > CREATE MATERIALIZED VIEW mv1 > BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL > DISTRIBUTED BY RANDOM BUCKETS 2 > PROPERTIES ('replication_num' = '1') > AS > select > count(o_totalprice), > o_shippriority, > o_orderstatus, > bin(o_orderkey) > from orders > group by > o_orderstatus, > o_shippriority, > bin(o_orderkey); the query as following can be rewritten by materialized view successfully though `sum(distinct o_shippriority)` in query is not appear in mv output, but query aggregate function is distinct and it use the group by dimension in mv, in this scene, the `sum(distinct o_shippriority)` can use mv group dimension `o_shippriority` directly and the result is true. Suppport the following distinct aggregate function currently, others are supported in the furture on demand - max(distinct arg) - min(distinct arg) - sum(distinct arg) - avg(distinct arg) - count(distinct arg) > select > count(o_totalprice), > max(distinct o_shippriority), > min(distinct o_shippriority), > avg(distinct o_shippriority), > sum(distinct o_shippriority) / count(distinct o_shippriority) > o_orderstatus, > bin(o_orderkey) > from orders > group by > o_orderstatus, > bin(o_orderkey);
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jul 11, 2024
…e function is distinct (apache#36318) ## Proposed changes This extend the query rewrite by materialized view ability For example mv def is > CREATE MATERIALIZED VIEW mv1 > BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL > DISTRIBUTED BY RANDOM BUCKETS 2 > PROPERTIES ('replication_num' = '1') > AS > select > count(o_totalprice), > o_shippriority, > o_orderstatus, > bin(o_orderkey) > from orders > group by > o_orderstatus, > o_shippriority, > bin(o_orderkey); the query as following can be rewritten by materialized view successfully though `sum(distinct o_shippriority)` in query is not appear in mv output, but query aggregate function is distinct and it use the group by dimension in mv, in this scene, the `sum(distinct o_shippriority)` can use mv group dimension `o_shippriority` directly and the result is true. Suppport the following distinct aggregate function currently, others are supported in the furture on demand - max(distinct arg) - min(distinct arg) - sum(distinct arg) - avg(distinct arg) - count(distinct arg) > select > count(o_totalprice), > max(distinct o_shippriority), > min(distinct o_shippriority), > avg(distinct o_shippriority), > sum(distinct o_shippriority) / count(distinct o_shippriority) > o_orderstatus, > bin(o_orderkey) > from orders > group by > o_orderstatus, > bin(o_orderkey);
morrySnow
pushed a commit
that referenced
this pull request
Jul 12, 2024
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This extend the query rewrite by materialized view ability
For example mv def is
the query as following can be rewritten by materialized view successfully
though
sum(distinct o_shippriority)in query is not appear in mv output, but query aggregate function is distinct and it usethe group by dimension in mv, in this scene, the
sum(distinct o_shippriority)can use mv group dimensiono_shipprioritydirectly and the result is true.
Suppport the following distinct aggregate function currently, others are supported in the furture on demand