[fix](mtmv) Fix aggregate function roll up fail when function is always nullable #52960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33070 ms |
TPC-DS: Total hot run time: 185571 ms |
ClickBench: Total hot run time: 29.39 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
seawinde
force-pushed
the
fix_count_distinct_mv_rewrite_fail
branch
from
225eec0 to
62ce865
Compare
Contributor
Author
|
run buildall |
zddr
approved these changes
Aug 13, 2025
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Aug 13, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ys nullable (#52960) ### What problem does this PR solve? Related PR: #36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
Closed
16 tasks
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
Closed
16 tasks
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 14, 2025
…ys nullable (apache#52960) ### What problem does this PR solve? Related PR: apache#36318 Problem Summary: materaialized view def is as fllowing: create materialized view as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; `sum(k2) ` nullable is true if query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this select sum(distinct k1) from agg_use_key_direct
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
…ion is always nullable apache#52960 (apache#5650) ## Proposed changes pr: apache#52960 commitId: selectdb/selectdb-core@0a5cd95 Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
materaialized view def is as fllowing:
sum(k2)nullable is trueif query is as following, would rewritten fail with err info 'query aggregate function roll up fail', the pr fix this
Issue Number: close #xxx
Related PR: #36318
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)