Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Apr 14, 2021

Proposed changes

Remove jprotobuf and use grpc client to connect brpc service, improve the concurrency

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix Remove jprotobuf and use grpc client to connect brpc service #5572) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added the kind/refactor Issues or PRs to refactor code label Apr 20, 2021
@morningman morningman self-assigned this Apr 20, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Apr 20, 2021
@yangzhg yangzhg merged commit b121ad6 into apache:master Apr 21, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
…ce (apache#5650)

Change-Id: I79b3c5d4c22f0bed6f056a134458e2ceb406210b
@yangzhg yangzhg deleted the replace_jprobuf branch June 7, 2021 03:05
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
…ion is always nullable apache#52960 (apache#5650)

## Proposed changes

pr: apache#52960
commitId:
selectdb/selectdb-core@0a5cd95

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants