[Optimize] Using sorted schema change processing to merge the data #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reducing the key columns of an aggregate table by doing schema change or rollup, we should trigger a re-sort schema change process to re-sort and merge the data into new schema. So that the data in new schema will be more aggregated.
morningman
added
kind/fix
chaoyli
requested changes
May 23, 2020
| // new keys: A B C | ||
| // | ||
| // old keys: A B C D | ||
| // new keys: A B |
Contributor
There was a problem hiding this comment.
After this pull request.
old keys: A B C D
new keys: A B C
will be resorted.
Contributor
Author
There was a problem hiding this comment.
Sorry that this PR is not ready, I will consider more situation.
Contributor
There was a problem hiding this comment.
This case also need be re-agg, so the sc_sorting must be marked as true.
Contributor
|
Another pr #4587 has fixed this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reducing the key columns of an aggregate table by doing schema change
or rollup, we should trigger a re-sort schema change process to re-sort
and merge the data into new schema. So that the data in new schema will
be more aggregated.
Fix: #3660