[BUG] ReAgg when adding agg mv on dup base table #4587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the keystype of mv and base table is difference, Doris should execute sorting schema change instead of linked schema change. If doesn't, the data size of mv actually is same as base table. This will cause mv to have no pre-aggregation effect at all. The query will not choose mv. This commit fixed this problem. Fixed apache#4586 Change-Id: Ibe67a389235b716d260f600edf7a0f9d9d4242b4
EmmyMiao87
added
kind/fix
Change-Id: Ib4b59f7cfe6e0e30d0740257e9bf073659807e88
Contributor
Author
|
Fixed #3660 |
morningman
pushed a commit
that referenced
this pull request
Sep 14, 2020
When the keystype of mv and base table is difference, Doris should execute sorting schema change instead of linked schema change. If doesn't, the data size of mv actually is same as base table. This will cause mv to have no pre-aggregation effect at all. The query will not choose mv. This commit fixed this problem. Fixed #4586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ibe67a389235b716d260f600edf7a0f9d9d4242b4
Proposed changes
When the keystype of mv and base table is difference, Doris should execute sorting schema change instead of linked schema change.
If doesn't, the data size of mv actually is same as base table. This will cause mv to have no pre-aggregation effect at all.
The query will not choose mv.
This commit fixed this problem. Fixed #4586
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.