-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](merge-on-write) when full clone failed, duplicate key might occur #37001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39816 ms |
TPC-DS: Total hot run time: 174671 ms |
ClickBench: Total hot run time: 29.97 s |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ur (#37001) ## Proposed changes Issue Number: close #xxx introduced by #31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
…ur (apache#37001) ## Proposed changes Issue Number: close #xxx introduced by apache#31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
…ur (apache#37001) ## Proposed changes Issue Number: close #xxx introduced by apache#31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
Proposed changes
Issue Number: close #xxx
introduced by #31268
full clone failure may produce duplicate keys in mow table
the bug would be triggered in the following condition:
solution:
for full clone, don't override the delete bitmap, use
merge()method instead.