Skip to content

[fix](merge-on-write) when full clone failed, duplicate key might occur (#37001) #37227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Jul 3, 2024
Merged

[fix](merge-on-write) when full clone failed, duplicate key might occur (#37001) #37227

zhannngchen merged 1 commit into from
Jul 3, 2024

Conversation

@zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Jul 3, 2024

Proposed changes

cherry-pick #37001

@zhannngchen
[fix](merge-on-write) when full clone failed, duplicate key might occ…
e4dd904 
…ur (apache#37001)

## Proposed changes

Issue Number: close #xxx

introduced by apache#31268

full clone failure may produce duplicate keys in mow table
the bug would be triggered in the following condition:
1. replica 0 miss version
2. replica 0 try to do full clone from other replicas
3. the full clone failed and the delete bitmap is overrided incorrectly
4. replica 0 try to do incremental clone again and this time the clone
succeed
5. incremental clone can't fix the delete bitmap overrided by previous
failed full clone
6. duplicate key occurred

solution:
for full clone, don't override the delete bitmap, use `merge()` method
instead.
@doris-robot
Copy link

doris-robot commented Jul 3, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Jul 3, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 3, 2024

TPC-H: Total hot run time: 49978 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e4dd9044ba4b2823830cbbbea938f78b94121e84, data reload: false

------ Round 1 ----------------------------------
q1	17534	4412	4339	4339
q2	2075	157	151	151
q3	10402	1918	1968	1918
q4	10336	1255	1340	1255
q5	8476	3966	3932	3932
q6	235	128	126	126
q7	2039	1598	1604	1598
q8	9514	2751	2714	2714
q9	13789	11230	10233	10233
q10	8632	3525	3532	3525
q11	413	245	254	245
q12	468	310	308	308
q13	18339	3955	3972	3955
q14	367	339	332	332
q15	512	457	465	457
q16	672	580	579	579
q17	1125	962	943	943
q18	7432	6996	7034	6996
q19	1818	1626	1559	1559
q20	561	329	305	305
q21	4427	4096	4070	4070
q22	528	438	438	438
Total cold run time: 119694 ms
Total hot run time: 49978 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4312	4289	4289
q2	321	228	220	220
q3	4160	4183	4178	4178
q4	2729	2755	2734	2734
q5	7145	7095	7087	7087
q6	238	120	118	118
q7	3254	2835	2830	2830
q8	4330	4456	4433	4433
q9	16845	16792	16706	16706
q10	4221	4278	4288	4278
q11	727	681	655	655
q12	1021	848	866	848
q13	7245	3720	3717	3717
q14	463	426	421	421
q15	513	456	455	455
q16	731	685	685	685
q17	3758	3794	3839	3794
q18	8823	8880	8786	8786
q19	1738	1692	1669	1669
q20	2385	2169	2169	2169
q21	8466	8353	8468	8353
q22	1066	995	933	933
Total cold run time: 84555 ms
Total hot run time: 79358 ms

@doris-robot
Copy link

doris-robot commented Jul 3, 2024

TeamCity be ut coverage result:
Function Coverage: 37.87% (8111/21417)
Line Coverage: 29.54% (66428/224885)
Region Coverage: 29.00% (34230/118031)
Branch Coverage: 24.87% (17576/70672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e4dd9044ba4b2823830cbbbea938f78b94121e84_e4dd9044ba4b2823830cbbbea938f78b94121e84/report/index.html

@doris-robot
Copy link

doris-robot commented Jul 3, 2024

TPC-DS: Total hot run time: 203850 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e4dd9044ba4b2823830cbbbea938f78b94121e84, data reload: false

query1	923	421	380	380
query2	6530	2687	2734	2687
query3	6921	206	204	204
query4	21183	17841	17840	17840
query5	19732	6522	6545	6522
query6	303	227	249	227
query7	4168	293	302	293
query8	453	407	435	407
query9	3126	2687	2605	2605
query10	417	306	297	297
query11	11225	10650	10574	10574
query12	126	80	77	77
query13	5591	700	699	699
query14	18196	13915	13226	13226
query15	377	242	247	242
query16	6460	288	263	263
query17	1697	1445	883	883
query18	2311	427	404	404
query19	212	149	147	147
query20	86	79	80	79
query21	191	99	99	99
query22	5147	4918	5024	4918
query23	32405	31943	31912	31912
query24	6993	6534	6578	6534
query25	540	431	415	415
query26	530	168	159	159
query27	1878	298	298	298
query28	6162	2355	2308	2308
query29	2834	2817	2773	2773
query30	253	162	171	162
query31	936	738	756	738
query32	66	60	61	60
query33	393	261	264	261
query34	837	481	480	480
query35	1144	923	911	911
query36	1339	1179	1108	1108
query37	91	62	60	60
query38	3061	3009	2924	2924
query39	1385	1348	1334	1334
query40	211	100	95	95
query41	47	45	46	45
query42	85	89	80	80
query43	772	687	709	687
query44	1135	730	735	730
query45	254	237	231	231
query46	1224	963	981	963
query47	2006	1638	1685	1638
query48	1025	710	697	697
query49	636	371	373	371
query50	860	580	621	580
query51	4820	4699	4698	4698
query52	96	88	89	88
query53	453	332	329	329
query54	2644	2469	2492	2469
query55	81	81	81	81
query56	250	223	205	205
query57	1181	1105	1102	1102
query58	215	209	210	209
query59	4336	3982	3779	3779
query60	212	200	210	200
query61	100	98	95	95
query62	857	573	480	480
query63	496	343	349	343
query64	2347	1534	1467	1467
query65	3599	3537	3571	3537
query66	823	368	389	368
query67	15751	15602	15263	15263
query68	8880	668	643	643
query69	585	357	350	350
query70	1562	1469	1368	1368
query71	416	303	306	303
query72	6494	3518	3506	3506
query73	730	318	316	316
query74	6279	5924	5845	5845
query75	5437	3681	3621	3621
query76	5247	1184	1200	1184
query77	930	249	261	249
query78	12452	12491	12786	12491
query79	13005	643	638	638
query80	868	391	392	391
query81	497	230	232	230
query82	955	99	101	99
query83	181	128	130	128
query84	267	70	69	69
query85	778	319	323	319
query86	341	301	299	299
query87	3231	3018	3085	3018
query88	6024	2308	2282	2282
query89	434	313	286	286
query90	2586	210	200	200
query91	175	144	143	143
query92	58	52	52	52
query93	5999	585	578	578
query94	1224	211	204	204
query95	1093	1068	1044	1044
query96	631	330	317	317
query97	6407	6376	6334	6334
query98	190	171	171	171
query99	2821	898	832	832
Total cold run time: 319515 ms
Total hot run time: 203850 ms

@doris-robot
Copy link

doris-robot commented Jul 3, 2024

ClickBench: Total hot run time: 31.22 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e4dd9044ba4b2823830cbbbea938f78b94121e84, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.03
query3	0.25	0.04	0.05
query4	1.78	0.07	0.07
query5	0.53	0.52	0.52
query6	1.23	0.61	0.65
query7	0.01	0.02	0.01
query8	0.03	0.02	0.03
query9	0.53	0.49	0.48
query10	0.54	0.54	0.54
query11	0.12	0.09	0.08
query12	0.11	0.10	0.09
query13	0.62	0.62	0.61
query14	0.79	0.78	0.78
query15	0.78	0.76	0.77
query16	0.35	0.35	0.35
query17	0.96	1.03	1.01
query18	0.22	0.24	0.26
query19	1.95	1.82	1.86
query20	0.02	0.01	0.01
query21	15.50	0.55	0.57
query22	1.91	2.02	1.91
query23	17.00	1.11	0.90
query24	5.29	1.45	1.27
query25	0.41	0.12	0.05
query26	0.62	0.15	0.14
query27	0.05	0.04	0.04
query28	7.16	0.76	0.72
query29	12.62	2.33	2.28
query30	0.64	0.57	0.52
query31	2.81	0.40	0.37
query32	3.37	0.50	0.50
query33	3.08	3.05	3.08
query34	15.25	4.78	4.76
query35	4.87	4.83	4.86
query36	1.06	1.00	1.01
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.15	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.01
query43	0.02	0.01	0.02
Total cold run time: 102.94 s
Total hot run time: 31.22 s

@doris-robot
Copy link

doris-robot commented Jul 3, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e4dd9044ba4b2823830cbbbea938f78b94121e84 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.9 seconds inserted 10000000 Rows, about 456K ops/s

@zhannngchen zhannngchen merged commit 473c163 into apache:branch-2.0 Jul 3, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhannngchen
[fix](merge-on-write) when full clone failed, duplicate key might occ…
c74422e 
…ur (apache#37001) (apache#37227)

cherry-pick apache#37001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhannngchen @doris-robot