FixBug: Load data Is error in json load #3702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
requested changes
May 27, 2020
|
|
||
| /** | ||
| * The `document` parameter must be has parsed. | ||
| * return Value Is Array object |
Contributor
There was a problem hiding this comment.
better to change its name to get_json_array_from_parsed_json() to make it more explict.
And in src//exec/json_scanner.cpp line 270, you can this method, but judge the return value as either array or non-array? the else should not happen?
Contributor
Author
There was a problem hiding this comment.
The method MUST return ArrayObject.
else if (!root->IsArray()) is true, then I warp a ArrayObject in root outside.
else case MUST be ArrayObject
Contributor
Author
There was a problem hiding this comment.
The method name changed to get_json_objects_from_parsed_json ??
morningman
added
approved
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data is always 1 by json load
#3697