[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

zy-kkk · 2024-11-18T07:21:18Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-18T07:21:33Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

…reSQL

zy-kkk · 2024-11-22T08:59:45Z

run buildall

morningman · 2024-11-18T07:25:05Z

...java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/PostgreSQLJdbcExecutor.java

+            } else if (element instanceof byte[]) {
+                sb.append(pgByteArrayToHexString((byte[]) element));
+            } else {
+                String elementStr = element != null ? element.toString().trim() : "null";


Why use trim()?

morningman · 2024-11-25T15:19:58Z

fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcPostgreSQLClient.java

+        }
+
+        String innerType = fieldSchema.getDataTypeName().orElse("unknown").substring(1);
+        String[] supportedInnerType = new String[] {


Make it is static final field

zy-kkk · 2024-11-26T03:04:27Z

run buildall

morningman

LGTM

github-actions · 2024-11-26T08:11:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-26T08:11:50Z

PR approved by anyone and no changes requested.

…reSQL (#44160) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: This PR supports reading some PostgreSQL array types, including: ``` { "int2", "int4", "int8", "smallserial", "serial", "bigserial", "float4", "float8", "timestamp", "timestamptz", "date", "bool", "bpchar", "varchar", "text" } ``` ### Release note [feat](jdbc catalog) Support reading some array types of PostgreSQL

…reSQL (apache#44160) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: This PR supports reading some PostgreSQL array types, including: ``` { "int2", "int4", "int8", "smallserial", "serial", "bigserial", "float4", "float8", "timestamp", "timestamptz", "date", "bool", "bpchar", "varchar", "text" } ``` ### Release note [feat](jdbc catalog) Support reading some array types of PostgreSQL

…reSQL (#44160) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: This PR supports reading some PostgreSQL array types, including: ``` { "int2", "int4", "int8", "smallserial", "serial", "bigserial", "float4", "float8", "timestamp", "timestamptz", "date", "bool", "bpchar", "varchar", "text" } ``` ### Release note [feat](jdbc catalog) Support reading some array types of PostgreSQL

…pes of PostgreSQL #44160 (#45219) Cherry-picked from #44160 Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>

…pache#44160) (apache#3702) pick [(apache#44160)](apache#44160)

… array types of PostgreSQL apache#44160

zy-kkk force-pushed the pg_array branch from b1f8573 to 3992643 Compare November 21, 2024 11:45

[Enhancement](jdbc catalog) Support reading some array types of Postg…

3deca38

…reSQL

zy-kkk force-pushed the pg_array branch from 3992643 to 3deca38 Compare November 22, 2024 08:57

morningman reviewed Nov 25, 2024

View reviewed changes

1

129cad7

morningman approved these changes Nov 26, 2024

View reviewed changes

morningman closed this Nov 26, 2024

morningman reopened this Nov 26, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024

github-actions bot added the reviewed label Nov 26, 2024

CalvinKirs approved these changes Nov 28, 2024

View reviewed changes

morningman merged commit 24f1eef into apache:master Nov 28, 2024

zy-kkk deleted the pg_array branch December 10, 2024 03:02

zy-kkk added the dev/3.0.x label Dec 10, 2024

github-actions bot mentioned this pull request Dec 10, 2024

branch-3.0: [Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160 #45219

Merged

morningman pushed a commit that referenced this pull request Dec 20, 2024

branch-3.0: [Enhancement](jdbc catalog) Support reading some array ty…

85e2e99

…pes of PostgreSQL #44160 (#45219) Cherry-picked from #44160 Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>

morningman added dev/3.0.4-merged dev/2.1.x-experimental and removed dev/3.0.x labels Dec 20, 2024

hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025

[feat](jdbc catalog) Support reading some array types of PostgreSQL (a…

79f3027

…pache#44160) (apache#3702) pick [(apache#44160)](apache#44160)

liutang123 pushed a commit to liutang123/doris that referenced this pull request Apr 29, 2025

[Tencent][branch-2.1][Enhancement](jdbc catalog) Support reading some…

b50e609

… array types of PostgreSQL apache#44160

cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Jul 17, 2025

[Tencent][branch-2.1][Enhancement](jdbc catalog) Support reading some…

5876915

… array types of PostgreSQL apache#44160

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

Uh oh!

zy-kkk commented Nov 18, 2024 •

edited

Loading

Uh oh!

doris-robot commented Nov 18, 2024

Uh oh!

zy-kkk commented Nov 22, 2024

Uh oh!

morningman Nov 18, 2024

Uh oh!

morningman Nov 25, 2024

Uh oh!

zy-kkk commented Nov 26, 2024

Uh oh!

morningman left a comment

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

Uh oh!

Conversation

zy-kkk commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 18, 2024

Uh oh!

zy-kkk commented Nov 22, 2024

Uh oh!

morningman Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

morningman Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

zy-kkk commented Nov 26, 2024

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zy-kkk commented Nov 18, 2024 •

edited

Loading