[Fix]add set thread num config for wg flush pool #37028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
Author
|
@liaoxin01 please add merge branch label for this pr. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| int64_t memory_limitation_bytes_per_thread_for_schema_change() const; | ||
|
|
||
| int get_disk_num() { return _disk_num; } |
Contributor
There was a problem hiding this comment.
warning: method 'get_disk_num' can be made const [readability-make-member-function-const]
Suggested change
| int get_disk_num() { return _disk_num; } | |
| int get_disk_num() const { return _disk_num; } |
TPC-H: Total hot run time: 40079 ms |
TPC-DS: Total hot run time: 174362 ms |
ClickBench: Total hot run time: 30.91 s |
wangbo
force-pushed
the
0629_mem_tab_flush
branch
3 times, most recently
from
ea6f06f to
3828097
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41367 ms |
TPC-DS: Total hot run time: 173154 ms |
ClickBench: Total hot run time: 31.92 s |
wangbo
force-pushed
the
0629_mem_tab_flush
branch
from
3828097 to
0803305
Compare
Contributor
Author
|
run buildall |
wangbo
force-pushed
the
0629_mem_tab_flush
branch
from
beb9fdb to
afd28a1
Compare
TPC-H: Total hot run time: 40404 ms |
wangbo
force-pushed
the
0629_mem_tab_flush
branch
from
afd28a1 to
97f7c6a
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40207 ms |
TPC-DS: Total hot run time: 173694 ms |
ClickBench: Total hot run time: 31.1 s |
kaijchen
approved these changes
Jul 1, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 2, 2024
## Proposed changes calculate workload group's mem table flush pool 's thread num by cpu and disk num, other wise it may cause mem table flush cost more memory than not enable workload group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
calculate workload group's mem table flush pool 's thread num by cpu and disk num, other wise it may cause mem table flush cost more memory than not enable workload group.