Skip to content

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Jul 1, 2024

Proposed changes

pick #37028

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wangbo
Copy link
Contributor Author

wangbo commented Jul 1, 2024

run buildall

@wangbo wangbo force-pushed the 0701_memtab_flush_21 branch from 773ad8a to 3d3857d Compare July 1, 2024 11:26
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


std::set<string> get_broken_paths() { return _broken_paths; }

int get_disk_num() { return _disk_num; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: method 'get_disk_num' can be made const [readability-make-member-function-const]

Suggested change
int get_disk_num() { return _disk_num; }
int get_disk_num() const { return _disk_num; }

@wangbo
Copy link
Contributor Author

wangbo commented Jul 2, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.33% (9150/25184)
Line Coverage: 27.88% (74678/267893)
Region Coverage: 26.78% (38506/143786)
Branch Coverage: 23.47% (19512/83142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3d3857d66413ec95b1fca14c6bf9f37edc4b1033_3d3857d66413ec95b1fca14c6bf9f37edc4b1033/report/index.html

@wangbo wangbo merged commit f5572ac into apache:branch-2.1 Jul 2, 2024
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants