-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](autoinc) Forbid some schema change when the table has auto-increment column #37186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](autoinc) Forbid some schema change when the table has auto-increment column #37186
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39801 ms |
TPC-DS: Total hot run time: 172515 ms |
ClickBench: Total hot run time: 30.44 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
Why need to do that? |
…ement column (#37186) ## Proposed changes 1. forbid schema change that modify the auto-increment attribute of a column. 2. forbid adding auto-increment column to a table. 3. forbid schema change that invoke double writes on table which has auto-increment column.
…t has auto-increment column (#40280) ## Proposed changes - #37186 forbids some schema change on table with auto-increment column, one of which is to forbid schema change that involves double write on tables which has auto-increment column. However, the process of generating auto-increment column values is before the distributing data to indexes. So this restriction can be removed. branch-2.1-pick: #41096
…t has auto-increment column (#40280) ## Proposed changes - #37186 forbids some schema change on table with auto-increment column, one of which is to forbid schema change that involves double write on tables which has auto-increment column. However, the process of generating auto-increment column values is before the distributing data to indexes. So this restriction can be removed. branch-2.1-pick: #41096
Proposed changes
branch-2.1-pick: #37331