Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 2, 2024

Proposed changes

branch-2.1-pick: #41096

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 2, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38102 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5d5f03462698eddfd7ee2f86d4d17160cdfc8e8d, data reload: false

------ Round 1 ----------------------------------
q1	17657	4624	4339	4339
q2	2019	192	185	185
q3	11525	962	1116	962
q4	10470	692	768	692
q5	7746	2909	2861	2861
q6	230	138	140	138
q7	967	634	608	608
q8	9328	2123	2092	2092
q9	6988	6565	6590	6565
q10	6989	2211	2227	2211
q11	464	251	247	247
q12	395	235	230	230
q13	17764	3076	3080	3076
q14	276	225	248	225
q15	528	484	480	480
q16	578	539	512	512
q17	995	646	682	646
q18	7479	6731	6975	6731
q19	1389	1104	1038	1038
q20	666	350	345	345
q21	4301	3163	2908	2908
q22	1120	1022	1011	1011
Total cold run time: 109874 ms
Total hot run time: 38102 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4384	4335	4294	4294
q2	391	279	276	276
q3	2917	2669	2672	2669
q4	1931	1640	1675	1640
q5	5699	5762	5755	5755
q6	230	139	136	136
q7	2244	1849	1842	1842
q8	3342	3405	3521	3405
q9	8968	8915	8943	8915
q10	3624	3419	3344	3344
q11	597	512	512	512
q12	823	658	666	658
q13	13502	3246	3277	3246
q14	344	293	281	281
q15	537	497	501	497
q16	600	584	598	584
q17	1844	1591	1563	1563
q18	8356	8039	7838	7838
q19	1743	1674	1581	1581
q20	2190	1918	1923	1918
q21	5812	5563	5616	5563
q22	1135	1079	1033	1033
Total cold run time: 71213 ms
Total hot run time: 57550 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192538 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5d5f03462698eddfd7ee2f86d4d17160cdfc8e8d, data reload: false

query1	1256	902	873	873
query2	6288	1909	1880	1880
query3	10587	3935	3995	3935
query4	59829	26663	23212	23212
query5	5513	497	508	497
query6	407	159	169	159
query7	5769	297	287	287
query8	283	203	203	203
query9	9060	2452	2433	2433
query10	497	271	262	262
query11	18379	15005	15427	15005
query12	147	109	103	103
query13	1573	391	392	391
query14	11264	7308	7422	7308
query15	219	181	182	181
query16	7551	490	488	488
query17	1161	589	592	589
query18	2039	310	301	301
query19	286	165	147	147
query20	121	115	111	111
query21	220	104	106	104
query22	4579	4470	4544	4470
query23	34133	33455	33500	33455
query24	6002	2814	2814	2814
query25	549	407	405	405
query26	691	161	155	155
query27	1774	285	284	284
query28	3713	2061	2044	2044
query29	711	426	437	426
query30	238	158	160	158
query31	949	744	754	744
query32	83	58	55	55
query33	459	291	289	289
query34	856	465	499	465
query35	848	708	725	708
query36	1045	931	928	928
query37	151	92	91	91
query38	3978	3870	3892	3870
query39	1450	1389	1418	1389
query40	205	116	116	116
query41	48	49	47	47
query42	121	95	97	95
query43	498	475	480	475
query44	1109	765	758	758
query45	196	168	167	167
query46	1095	746	719	719
query47	1941	1792	1844	1792
query48	381	299	307	299
query49	778	445	447	445
query50	856	410	413	410
query51	7059	6901	6867	6867
query52	100	87	88	87
query53	250	182	180	180
query54	566	470	472	470
query55	74	74	75	74
query56	284	262	259	259
query57	1210	1081	1081	1081
query58	228	227	240	227
query59	3013	2779	2649	2649
query60	303	276	279	276
query61	126	118	119	118
query62	761	660	652	652
query63	217	183	189	183
query64	2782	842	662	662
query65	3200	3104	3190	3104
query66	665	330	333	330
query67	15545	15380	15360	15360
query68	4441	559	559	559
query69	429	277	278	277
query70	1153	1147	1100	1100
query71	376	269	269	269
query72	6640	4014	4025	4014
query73	747	329	329	329
query74	9166	8805	8851	8805
query75	3343	2676	2649	2649
query76	1775	958	991	958
query77	565	324	315	315
query78	11651	9585	8983	8983
query79	1359	522	518	518
query80	911	517	498	498
query81	565	235	238	235
query82	389	148	138	138
query83	227	146	151	146
query84	262	74	73	73
query85	698	293	282	282
query86	392	293	305	293
query87	4427	4214	4253	4214
query88	3290	2313	2309	2309
query89	387	286	279	279
query90	1939	187	187	187
query91	124	110	100	100
query92	63	47	55	47
query93	1098	531	545	531
query94	781	292	295	292
query95	394	255	254	254
query96	585	263	260	260
query97	3236	3076	3065	3065
query98	213	202	196	196
query99	1569	1265	1242	1242
Total cold run time: 311464 ms
Total hot run time: 192538 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5d5f03462698eddfd7ee2f86d4d17160cdfc8e8d, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.07	0.08
query5	0.50	0.49	0.49
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.56	0.53	0.56
query11	0.15	0.12	0.12
query12	0.15	0.13	0.12
query13	0.61	0.59	0.58
query14	2.02	2.04	2.09
query15	0.86	0.82	0.82
query16	0.37	0.36	0.38
query17	1.07	1.06	1.02
query18	0.22	0.21	0.20
query19	1.83	1.71	1.83
query20	0.02	0.01	0.01
query21	15.38	0.66	0.66
query22	4.37	7.53	1.72
query23	18.26	1.42	1.26
query24	2.12	0.21	0.21
query25	0.14	0.10	0.08
query26	0.25	0.17	0.18
query27	0.08	0.08	0.08
query28	13.31	1.01	1.00
query29	12.64	3.40	3.35
query30	0.24	0.06	0.06
query31	2.86	0.41	0.40
query32	3.24	0.50	0.47
query33	3.01	2.99	3.03
query34	17.24	4.37	4.41
query35	4.47	4.48	4.43
query36	0.66	0.47	0.47
query37	0.19	0.15	0.15
query38	0.15	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.06	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.16 s
Total hot run time: 31.79 s

@bobhan1 bobhan1 force-pushed the allow-auto-inc-schema-change branch from 5d5f034 to dfb298a Compare September 2, 2024 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 2, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37798 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dfb298aec8e9ac17069878879605e92eb020d22f, data reload: false

------ Round 1 ----------------------------------
q1	17629	5172	4288	4288
q2	2031	183	177	177
q3	11411	953	1119	953
q4	10517	735	680	680
q5	7768	2819	2827	2819
q6	225	136	134	134
q7	959	608	594	594
q8	9321	2044	2027	2027
q9	6987	6495	6583	6495
q10	7033	2223	2189	2189
q11	456	234	238	234
q12	383	221	221	221
q13	17765	3132	3103	3103
q14	273	235	236	235
q15	528	472	478	472
q16	618	515	514	514
q17	973	688	680	680
q18	7228	6817	6757	6757
q19	1394	991	1070	991
q20	664	333	325	325
q21	3984	3044	2905	2905
q22	1129	1050	1005	1005
Total cold run time: 109276 ms
Total hot run time: 37798 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4329	4307	4279	4279
q2	386	282	265	265
q3	2900	2642	2675	2642
q4	1970	1682	1662	1662
q5	5595	5665	5691	5665
q6	233	131	134	131
q7	2256	1829	1839	1829
q8	3311	3421	3430	3421
q9	8887	8819	8837	8819
q10	3590	3341	3367	3341
q11	622	521	512	512
q12	813	615	655	615
q13	14323	3300	3204	3204
q14	313	283	302	283
q15	529	507	495	495
q16	646	571	570	570
q17	1843	1527	1520	1520
q18	8185	7710	7810	7710
q19	1696	1618	1718	1618
q20	2155	1894	1917	1894
q21	5659	5578	5424	5424
q22	1177	1059	1023	1023
Total cold run time: 71418 ms
Total hot run time: 56922 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192907 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dfb298aec8e9ac17069878879605e92eb020d22f, data reload: false

query1	1261	890	870	870
query2	6313	1945	1916	1916
query3	10749	4320	4202	4202
query4	59429	26810	23247	23247
query5	5323	510	502	502
query6	405	162	157	157
query7	5760	300	310	300
query8	293	213	203	203
query9	8873	2444	2442	2442
query10	489	278	265	265
query11	17952	15060	15306	15060
query12	156	104	101	101
query13	1566	393	377	377
query14	10859	7484	7163	7163
query15	244	174	181	174
query16	7586	476	505	476
query17	1119	596	609	596
query18	2042	296	287	287
query19	292	149	141	141
query20	116	108	106	106
query21	208	104	106	104
query22	4621	4383	4578	4383
query23	34277	33461	33706	33461
query24	6032	2908	2872	2872
query25	529	373	385	373
query26	677	155	153	153
query27	1776	288	278	278
query28	3707	2049	2036	2036
query29	690	432	423	423
query30	233	153	155	153
query31	954	768	763	763
query32	84	51	50	50
query33	469	278	280	278
query34	865	476	472	472
query35	812	716	725	716
query36	1083	927	955	927
query37	146	93	91	91
query38	3952	3892	3893	3892
query39	1448	1406	1445	1406
query40	198	113	112	112
query41	47	43	42	42
query42	118	95	93	93
query43	513	477	450	450
query44	1105	739	753	739
query45	197	164	167	164
query46	1087	752	725	725
query47	1889	1809	1793	1793
query48	371	297	296	296
query49	765	441	453	441
query50	828	435	405	405
query51	7045	6880	6898	6880
query52	101	90	89	89
query53	250	181	180	180
query54	575	461	468	461
query55	76	75	78	75
query56	292	262	268	262
query57	1200	1071	1062	1062
query58	232	243	233	233
query59	3145	2749	2830	2749
query60	299	279	280	279
query61	123	118	121	118
query62	756	650	638	638
query63	221	185	191	185
query64	2821	760	767	760
query65	3206	3130	3146	3130
query66	685	346	348	346
query67	15356	15183	15208	15183
query68	3092	590	580	580
query69	411	297	291	291
query70	1174	1100	1107	1100
query71	474	274	282	274
query72	6316	4103	4048	4048
query73	741	330	329	329
query74	9200	9041	8762	8762
query75	3327	2706	2617	2617
query76	1411	1019	970	970
query77	559	328	317	317
query78	10129	9091	9273	9091
query79	1063	528	526	526
query80	741	503	510	503
query81	542	231	234	231
query82	384	149	144	144
query83	169	147	146	146
query84	256	79	72	72
query85	748	287	339	287
query86	321	308	303	303
query87	4519	4276	4454	4276
query88	3405	2305	2314	2305
query89	377	291	291	291
query90	1989	191	193	191
query91	131	102	99	99
query92	59	52	51	51
query93	1043	526	533	526
query94	761	289	287	287
query95	349	253	252	252
query96	591	266	260	260
query97	3159	3039	3132	3039
query98	221	205	193	193
query99	1547	1240	1250	1240
Total cold run time: 306100 ms
Total hot run time: 192907 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dfb298aec8e9ac17069878879605e92eb020d22f, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.08	0.08
query5	0.50	0.50	0.51
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.54	0.49	0.48
query10	0.55	0.54	0.56
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.59	0.58
query14	2.02	2.05	2.10
query15	0.89	0.83	0.83
query16	0.37	0.38	0.38
query17	1.04	1.04	1.05
query18	0.22	0.21	0.20
query19	1.87	1.90	1.90
query20	0.01	0.01	0.01
query21	15.40	0.66	0.66
query22	4.25	7.16	2.08
query23	18.24	1.36	1.29
query24	2.11	0.23	0.23
query25	0.15	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.07
query28	13.18	1.03	1.00
query29	12.64	3.38	3.32
query30	0.24	0.08	0.05
query31	2.84	0.41	0.39
query32	3.25	0.49	0.50
query33	2.99	3.01	3.01
query34	16.93	4.39	4.46
query35	4.48	4.45	4.49
query36	0.64	0.49	0.50
query37	0.18	0.16	0.16
query38	0.16	0.15	0.14
query39	0.05	0.05	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 110.61 s
Total hot run time: 32.5 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 3, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37823 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dbc41311174943bbcbaeb156431b004fb7fc6a41, data reload: false

------ Round 1 ----------------------------------
q1	17613	4469	4327	4327
q2	2011	184	176	176
q3	11782	951	1121	951
q4	10522	739	751	739
q5	7744	2857	2805	2805
q6	226	135	136	135
q7	951	603	598	598
q8	9526	2066	2075	2066
q9	7963	6508	6536	6508
q10	7001	2179	2410	2179
q11	441	242	239	239
q12	400	219	223	219
q13	17798	3071	3085	3071
q14	270	242	235	235
q15	535	489	476	476
q16	603	505	502	502
q17	972	696	685	685
q18	7268	6750	6812	6750
q19	1403	1069	976	976
q20	700	326	328	326
q21	4036	2849	3048	2849
q22	1089	1027	1011	1011
Total cold run time: 110854 ms
Total hot run time: 37823 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4331	4251	4278	4251
q2	376	273	265	265
q3	2856	2641	2697	2641
q4	1934	1607	1644	1607
q5	5592	5670	5722	5670
q6	227	133	130	130
q7	2211	1849	1824	1824
q8	3306	3410	3456	3410
q9	8778	8820	8831	8820
q10	3571	3374	3367	3367
q11	624	502	500	500
q12	838	662	653	653
q13	15560	3200	3263	3200
q14	319	288	282	282
q15	541	492	482	482
q16	592	584	598	584
q17	1837	1575	1537	1537
q18	8146	7797	7718	7718
q19	1722	1545	1493	1493
q20	2147	1907	1871	1871
q21	5804	5441	5488	5441
q22	1091	1016	1041	1016
Total cold run time: 72403 ms
Total hot run time: 56762 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191895 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dbc41311174943bbcbaeb156431b004fb7fc6a41, data reload: false

query1	1256	902	881	881
query2	6405	1978	1959	1959
query3	10612	3803	3920	3803
query4	59983	26717	23043	23043
query5	5274	501	499	499
query6	407	156	157	156
query7	5755	297	293	293
query8	285	203	216	203
query9	8709	2444	2426	2426
query10	465	268	256	256
query11	18294	15190	15305	15190
query12	157	98	102	98
query13	1534	417	384	384
query14	11024	7250	7298	7250
query15	254	172	171	171
query16	7413	469	447	447
query17	1136	572	549	549
query18	1946	304	304	304
query19	294	157	153	153
query20	123	108	112	108
query21	209	103	104	103
query22	4817	4340	4507	4340
query23	34072	33380	33352	33352
query24	5935	2876	2841	2841
query25	534	381	380	380
query26	678	151	148	148
query27	1774	267	271	267
query28	3751	2041	2029	2029
query29	689	400	402	400
query30	237	151	159	151
query31	942	758	784	758
query32	84	52	53	52
query33	432	296	281	281
query34	860	472	473	472
query35	848	728	726	726
query36	1065	942	894	894
query37	151	87	91	87
query38	3942	3981	3858	3858
query39	1489	1404	1382	1382
query40	207	115	114	114
query41	48	46	45	45
query42	118	94	96	94
query43	507	477	459	459
query44	1099	736	734	734
query45	201	173	167	167
query46	1081	744	734	734
query47	1917	1785	1780	1780
query48	381	303	296	296
query49	772	452	440	440
query50	808	416	408	408
query51	7060	6816	6828	6816
query52	98	85	85	85
query53	249	177	180	177
query54	564	484	466	466
query55	77	74	73	73
query56	282	258	264	258
query57	1206	1045	1084	1045
query58	221	234	230	230
query59	2858	2881	2855	2855
query60	297	276	281	276
query61	126	120	115	115
query62	755	634	642	634
query63	224	186	185	185
query64	2853	755	751	751
query65	3222	3137	3126	3126
query66	684	340	354	340
query67	15652	15129	15127	15127
query68	3424	596	569	569
query69	407	285	289	285
query70	1226	1131	1059	1059
query71	341	275	271	271
query72	6451	4051	4176	4051
query73	759	326	327	326
query74	9153	8743	8918	8743
query75	3366	2716	2689	2689
query76	1475	946	1026	946
query77	536	319	297	297
query78	9665	9208	9018	9018
query79	1149	513	523	513
query80	974	511	506	506
query81	565	232	235	232
query82	263	144	139	139
query83	175	152	143	143
query84	272	74	76	74
query85	885	310	267	267
query86	410	292	303	292
query87	4479	4220	4253	4220
query88	3238	2309	2289	2289
query89	390	288	282	282
query90	1816	187	185	185
query91	124	99	97	97
query92	66	50	52	50
query93	2196	537	537	537
query94	806	298	276	276
query95	351	254	249	249
query96	601	262	262	262
query97	3255	3068	3083	3068
query98	216	206	194	194
query99	1853	1283	1242	1242
Total cold run time: 308289 ms
Total hot run time: 191895 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dbc41311174943bbcbaeb156431b004fb7fc6a41, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.67	0.08	0.08
query5	0.51	0.49	0.49
query6	1.13	0.73	0.73
query7	0.01	0.01	0.01
query8	0.05	0.05	0.04
query9	0.55	0.48	0.48
query10	0.53	0.54	0.56
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.59
query14	2.03	2.05	2.04
query15	0.90	0.82	0.81
query16	0.40	0.38	0.36
query17	0.98	1.00	1.05
query18	0.21	0.21	0.19
query19	1.95	1.78	1.78
query20	0.01	0.02	0.01
query21	15.40	0.67	0.65
query22	4.49	6.71	2.05
query23	18.29	1.33	1.26
query24	2.13	0.21	0.22
query25	0.15	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.32	1.02	0.99
query29	12.64	3.36	3.36
query30	0.25	0.06	0.06
query31	2.87	0.40	0.39
query32	3.28	0.49	0.47
query33	2.98	3.08	3.02
query34	17.08	4.39	4.42
query35	4.40	4.47	4.44
query36	0.66	0.48	0.47
query37	0.18	0.16	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.17	0.13	0.13
query41	0.10	0.05	0.06
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.24 s
Total hot run time: 32.21 s

dataroaring
dataroaring previously approved these changes Sep 3, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the allow-auto-inc-schema-change branch from b73f3a3 to d3a9dad Compare September 3, 2024 07:25
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 3, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the allow-auto-inc-schema-change branch from d3a9dad to c053a19 Compare September 4, 2024 02:02
@dataroaring dataroaring force-pushed the allow-auto-inc-schema-change branch from f117555 to a97ad71 Compare September 20, 2024 11:07
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.23% (9595/25769)
Line Coverage: 28.62% (79304/277057)
Region Coverage: 28.08% (41028/146135)
Branch Coverage: 24.70% (20901/84614)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a97ad7138329c06e413080d751dd24c6312d6f11_a97ad7138329c06e413080d751dd24c6312d6f11/report/index.html

@bobhan1 bobhan1 dismissed stale reviews from dataroaring, zhannngchen, and gavinchou via 7da99ad September 21, 2024 02:29
@bobhan1 bobhan1 force-pushed the allow-auto-inc-schema-change branch from a97ad71 to 7da99ad Compare September 21, 2024 02:29
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 21, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 21, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9606/25772)
Line Coverage: 28.68% (79517/277236)
Region Coverage: 28.12% (41110/146209)
Branch Coverage: 24.76% (20957/84648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7da99ad355efc1baa0914898620fb9bb4dc23929_7da99ad355efc1baa0914898620fb9bb4dc23929/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 22, 2024

run p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 1593b4d into apache:master Sep 24, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
…t has auto-increment column (#40280)

## Proposed changes

- #37186 forbids some schema change on table with auto-increment column,
one of which is to forbid schema change that involves double write on
tables which has auto-increment column. However, the process of
generating auto-increment column values is before the distributing data
to indexes. So this restriction can be removed.

branch-2.1-pick: #41096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants