-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](autoinc) Remove some restrictions on schema change on table that has auto-increment column #40280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](autoinc) Remove some restrictions on schema change on table that has auto-increment column #40280
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38102 ms |
TPC-DS: Total hot run time: 192538 ms |
ClickBench: Total hot run time: 31.79 s |
5d5f034 to
dfb298a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 37798 ms |
TPC-DS: Total hot run time: 192907 ms |
ClickBench: Total hot run time: 32.5 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37823 ms |
TPC-DS: Total hot run time: 191895 ms |
ClickBench: Total hot run time: 32.21 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
b73f3a3 to
d3a9dad
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
d3a9dad to
c053a19
Compare
f117555 to
a97ad71
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
7da99ad
a97ad71 to
7da99ad
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
run p0 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…t has auto-increment column (#40280) ## Proposed changes - #37186 forbids some schema change on table with auto-increment column, one of which is to forbid schema change that involves double write on tables which has auto-increment column. However, the process of generating auto-increment column values is before the distributing data to indexes. So this restriction can be removed. branch-2.1-pick: #41096
Proposed changes
branch-2.1-pick: #41096