-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](explode-json-array)change explode-json-array-xx func signature from string to json type #37278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](explode-json-array)change explode-json-array-xx func signature from string to json type #37278
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
...a/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonArrayDouble.java
Show resolved
Hide resolved
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41273 ms |
TPC-DS: Total hot run time: 168527 ms |
ClickBench: Total hot run time: 30.55 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42024 ms |
TPC-DS: Total hot run time: 168226 ms |
ClickBench: Total hot run time: 30.13 s |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 39224 ms |
TPC-H: Total hot run time: 39886 ms |
TPC-DS: Total hot run time: 202936 ms |
ClickBench: Total hot run time: 31.11 s |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run cloud_p0 |
|
run compile |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38226 ms |
TPC-DS: Total hot run time: 195239 ms |
ClickBench: Total hot run time: 30.66 s |
|
run p0 |
…ure from string to json type (#37278) change explode-json-array-xx func signature from string to json type to improve function behavior
|
behavior change is fixed by #39572 |
Proposed changes
change explode-json-array-xx func signature from string to json type to improve function behavior
Issue Number: close #xxx