Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Jul 4, 2024

Proposed changes

change explode-json-array-xx func signature from string to json type to improve function behavior
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow morrySnow marked this pull request as draft August 2, 2024 13:32
@amorynan amorynan marked this pull request as ready for review August 6, 2024 11:02
@amorynan
Copy link
Contributor Author

amorynan commented Aug 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41273 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9fe3d5b156c2dd9ee9980bac0bb0be7d0c777ac, data reload: false

------ Round 1 ----------------------------------
q1	18127	4273	4134	4134
q2	2302	214	197	197
q3	10473	1261	1353	1261
q4	10165	780	936	780
q5	7671	2950	2928	2928
q6	224	141	136	136
q7	1055	609	609	609
q8	9421	1841	1941	1841
q9	8339	6561	6593	6561
q10	8680	3818	3793	3793
q11	424	253	262	253
q12	413	228	227	227
q13	17759	2902	2922	2902
q14	267	240	251	240
q15	527	482	499	482
q16	491	408	387	387
q17	961	925	914	914
q18	7967	7243	7199	7199
q19	1386	1205	1222	1205
q20	577	317	343	317
q21	5247	4716	4630	4630
q22	348	277	283	277
Total cold run time: 112824 ms
Total hot run time: 41273 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4023	3991	3992	3991
q2	318	213	216	213
q3	2973	2977	2987	2977
q4	1848	1850	1829	1829
q5	5233	5183	5187	5183
q6	217	127	129	127
q7	2038	1662	1649	1649
q8	3161	3242	3219	3219
q9	8254	8235	8213	8213
q10	3734	3854	3827	3827
q11	538	456	447	447
q12	697	560	542	542
q13	15657	2914	2904	2904
q14	301	259	266	259
q15	516	472	485	472
q16	445	396	385	385
q17	1714	1676	1695	1676
q18	7756	7307	7265	7265
q19	1658	1676	1663	1663
q20	1969	1743	1747	1743
q21	5393	5150	5171	5150
q22	520	490	479	479
Total cold run time: 68963 ms
Total hot run time: 54213 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168527 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9fe3d5b156c2dd9ee9980bac0bb0be7d0c777ac, data reload: false

query1	919	374	378	374
query2	6476	1685	1650	1650
query3	6662	212	217	212
query4	20007	17413	17307	17307
query5	4283	518	515	515
query6	301	160	172	160
query7	4609	297	302	297
query8	249	209	190	190
query9	8519	2361	2354	2354
query10	474	270	255	255
query11	10504	10101	9965	9965
query12	144	89	85	85
query13	1612	378	381	378
query14	9347	6798	7294	6798
query15	197	168	169	168
query16	7095	489	429	429
query17	962	598	559	559
query18	1941	293	290	290
query19	193	151	146	146
query20	95	86	88	86
query21	210	100	101	100
query22	4406	4163	3970	3970
query23	33643	32967	33125	32967
query24	10536	3097	3093	3093
query25	705	411	409	409
query26	1775	148	155	148
query27	2858	282	282	282
query28	6930	1986	1970	1970
query29	1350	430	424	424
query30	288	154	153	153
query31	930	750	755	750
query32	102	56	59	56
query33	698	318	330	318
query34	898	482	494	482
query35	850	734	712	712
query36	1003	849	910	849
query37	289	81	82	81
query38	2898	2790	2809	2790
query39	854	813	829	813
query40	283	115	115	115
query41	48	49	48	48
query42	119	103	106	103
query43	459	426	431	426
query44	1172	719	721	719
query45	211	183	178	178
query46	1087	827	800	800
query47	1816	1742	1740	1740
query48	365	296	292	292
query49	1203	439	435	435
query50	901	442	433	433
query51	6805	6719	6727	6719
query52	98	91	89	89
query53	253	185	185	185
query54	646	451	453	451
query55	75	75	75	75
query56	283	250	258	250
query57	1148	1053	1056	1053
query58	280	260	258	258
query59	2529	2256	2285	2256
query60	301	277	272	272
query61	95	95	99	95
query62	916	649	668	649
query63	218	183	187	183
query64	5880	1950	1871	1871
query65	3151	3093	3073	3073
query66	1432	343	329	329
query67	15485	14762	14663	14663
query68	6898	571	590	571
query69	688	413	311	311
query70	1109	1040	1077	1040
query71	565	275	271	271
query72	7521	2725	2491	2491
query73	960	328	327	327
query74	6098	5695	5649	5649
query75	4019	2752	2708	2708
query76	5526	1273	1296	1273
query77	664	317	315	315
query78	9435	8860	8932	8860
query79	3655	533	528	528
query80	1044	501	507	501
query81	565	229	227	227
query82	770	138	132	132
query83	216	178	171	171
query84	261	83	85	83
query85	1576	323	305	305
query86	501	278	282	278
query87	3259	3166	3148	3148
query88	3556	2390	2438	2390
query89	447	285	288	285
query90	2036	201	186	186
query91	128	103	113	103
query92	65	49	50	49
query93	4081	620	618	618
query94	925	298	301	298
query95	370	269	264	264
query96	618	278	280	278
query97	3217	3028	3040	3028
query98	219	203	203	203
query99	1717	1291	1303	1291
Total cold run time: 275780 ms
Total hot run time: 168527 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d9fe3d5b156c2dd9ee9980bac0bb0be7d0c777ac, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.05
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.48	0.48
query6	1.14	0.71	0.70
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.52	0.51
query10	0.55	0.57	0.56
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.60	0.60	0.60
query14	0.78	0.81	0.78
query15	0.93	0.85	0.85
query16	0.35	0.36	0.36
query17	0.99	1.02	1.01
query18	0.23	0.21	0.21
query19	1.82	1.74	1.74
query20	0.01	0.00	0.01
query21	15.42	0.72	0.65
query22	4.31	8.33	1.80
query23	18.10	1.33	1.35
query24	2.25	0.23	0.22
query25	0.17	0.08	0.08
query26	0.32	0.22	0.21
query27	0.46	0.23	0.22
query28	13.15	1.00	0.97
query29	12.55	3.31	3.31
query30	0.25	0.05	0.06
query31	2.89	0.40	0.40
query32	3.23	0.49	0.49
query33	2.89	2.98	2.93
query34	15.44	4.24	4.24
query35	4.27	4.29	4.29
query36	0.69	0.48	0.49
query37	0.18	0.17	0.15
query38	0.16	0.16	0.14
query39	0.04	0.03	0.04
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 107.95 s
Total hot run time: 30.55 s

@amorynan
Copy link
Contributor Author

amorynan commented Aug 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 42024 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c005fb50fff8e434041131b14170de3e89f8845, data reload: false

------ Round 1 ----------------------------------
q1	4808	4118	4102	4102
q2	1619	203	205	203
q3	1527	1386	1390	1386
q4	1160	1019	1023	1019
q5	3028	2995	2975	2975
q6	227	140	144	140
q7	1042	629	622	622
q8	9452	1950	1943	1943
q9	8457	6593	6565	6565
q10	8787	3846	3821	3821
q11	443	248	257	248
q12	428	226	223	223
q13	17769	2926	2942	2926
q14	271	241	234	234
q15	509	479	484	479
q16	481	423	410	410
q17	954	923	934	923
q18	8071	7267	7326	7267
q19	1465	1228	1209	1209
q20	559	312	322	312
q21	5236	4745	4731	4731
q22	359	286	292	286
Total cold run time: 76652 ms
Total hot run time: 42024 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4073	4006	4026	4006
q2	330	228	217	217
q3	2997	3001	2979	2979
q4	1910	1856	1886	1856
q5	5256	5210	5205	5205
q6	214	132	133	132
q7	2059	1716	1700	1700
q8	3171	3243	3251	3243
q9	8309	8285	8301	8285
q10	3728	3876	3837	3837
q11	548	450	465	450
q12	734	550	542	542
q13	16428	2929	2922	2922
q14	298	274	251	251
q15	525	475	477	475
q16	443	396	409	396
q17	1705	1686	1696	1686
q18	7866	7241	7155	7155
q19	1673	1686	1674	1674
q20	1967	1749	1745	1745
q21	5496	5278	5259	5259
q22	524	462	468	462
Total cold run time: 70254 ms
Total hot run time: 54477 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c005fb50fff8e434041131b14170de3e89f8845, data reload: false

query1	908	381	369	369
query2	6460	1671	1694	1671
query3	6688	212	222	212
query4	18857	17531	17140	17140
query5	4315	512	499	499
query6	276	157	162	157
query7	4613	295	296	295
query8	253	219	199	199
query9	8521	2403	2380	2380
query10	458	278	274	274
query11	10587	10070	10004	10004
query12	138	90	87	87
query13	1642	389	367	367
query14	9238	6944	6997	6944
query15	205	171	169	169
query16	7143	417	506	417
query17	967	577	567	567
query18	1923	291	285	285
query19	190	145	146	145
query20	96	90	85	85
query21	210	101	98	98
query22	4160	3879	4049	3879
query23	33823	32951	33029	32951
query24	10441	3016	3059	3016
query25	707	414	414	414
query26	1746	154	154	154
query27	2752	285	288	285
query28	6789	1995	1990	1990
query29	1337	437	439	437
query30	292	154	155	154
query31	915	776	758	758
query32	105	56	57	56
query33	707	315	325	315
query34	901	472	487	472
query35	843	708	744	708
query36	1012	897	890	890
query37	299	84	83	83
query38	2869	2759	2774	2759
query39	848	819	811	811
query40	285	115	113	113
query41	53	46	46	46
query42	137	102	104	102
query43	482	418	402	402
query44	1183	725	731	725
query45	206	271	180	180
query46	1081	806	796	796
query47	1814	1711	1734	1711
query48	356	311	289	289
query49	1186	435	430	430
query50	904	438	436	436
query51	6713	6792	6670	6670
query52	104	95	89	89
query53	259	186	179	179
query54	635	481	451	451
query55	77	73	76	73
query56	270	254	259	254
query57	1121	1061	1048	1048
query58	285	280	263	263
query59	2485	2486	2166	2166
query60	300	264	287	264
query61	96	96	98	96
query62	909	668	669	668
query63	216	183	178	178
query64	5852	1955	1878	1878
query65	3182	3120	3085	3085
query66	1452	353	326	326
query67	15296	15003	14815	14815
query68	4730	580	582	580
query69	719	359	323	323
query70	1118	1077	1050	1050
query71	482	279	282	279
query72	7868	2716	2483	2483
query73	783	330	336	330
query74	6017	5632	5613	5613
query75	4094	2748	2699	2699
query76	3216	1147	1255	1147
query77	698	354	325	325
query78	9661	8935	8861	8861
query79	1880	539	551	539
query80	863	503	499	499
query81	553	232	230	230
query82	755	136	130	130
query83	324	171	166	166
query84	272	85	79	79
query85	1463	301	293	293
query86	441	300	281	281
query87	3312	3102	3083	3083
query88	3698	2423	2418	2418
query89	413	287	285	285
query90	1953	191	192	191
query91	126	99	98	98
query92	66	51	53	51
query93	1626	619	612	612
query94	928	297	292	292
query95	381	272	261	261
query96	600	283	282	282
query97	3221	3044	3084	3044
query98	229	194	199	194
query99	1586	1295	1279	1279
Total cold run time: 265249 ms
Total hot run time: 168226 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c005fb50fff8e434041131b14170de3e89f8845, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.06	0.07
query5	0.48	0.49	0.49
query6	1.15	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.05	0.04
query9	0.57	0.52	0.51
query10	0.56	0.57	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.61	0.60
query14	0.78	0.82	0.80
query15	0.91	0.88	0.87
query16	0.35	0.36	0.34
query17	1.00	1.02	0.99
query18	0.23	0.21	0.21
query19	1.87	1.76	1.71
query20	0.01	0.01	0.02
query21	15.45	0.76	0.67
query22	4.20	7.77	1.39
query23	18.15	1.41	1.33
query24	2.26	0.23	0.22
query25	0.18	0.09	0.08
query26	0.32	0.22	0.22
query27	0.46	0.23	0.23
query28	13.16	1.00	0.96
query29	12.57	3.30	3.27
query30	0.24	0.05	0.06
query31	2.87	0.41	0.41
query32	3.24	0.49	0.48
query33	2.99	2.92	2.97
query34	15.43	4.26	4.27
query35	4.30	4.28	4.32
query36	0.69	0.47	0.48
query37	0.19	0.17	0.16
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.05
Total cold run time: 108.14 s
Total hot run time: 30.13 s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Aug 8, 2024

run buildall

@amorynan amorynan requested a review from eldenmoon August 8, 2024 01:44
@doris-robot
Copy link

TPC-H: Total hot run time: 39224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 32532f9701b622176e0a873412bc3f2aadc16d05, data reload: false

------ Round 1 ----------------------------------
q1	17614	4321	4262	4262
q2	2019	177	167	167
q3	10490	1240	1121	1121
q4	10155	739	811	739
q5	7491	2473	2485	2473
q6	230	137	137	137
q7	957	595	596	595
q8	9221	1885	1898	1885
q9	8772	6515	6522	6515
q10	7040	2161	2192	2161
q11	466	251	240	240
q12	439	223	223	223
q13	18956	2963	3013	2963
q14	272	236	234	234
q15	527	489	499	489
q16	505	394	393	393
q17	963	636	741	636
q18	7986	7414	7269	7269
q19	5481	1005	993	993
q20	667	351	338	338
q21	5363	4386	4384	4384
q22	1078	1022	1007	1007
Total cold run time: 116692 ms
Total hot run time: 39224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4448	4248	4234	4234
q2	381	279	274	274
q3	2879	2576	2700	2576
q4	1947	1714	1698	1698
q5	5560	5471	5452	5452
q6	229	134	132	132
q7	2104	1732	1787	1732
q8	3270	3416	3406	3406
q9	8823	8701	8915	8701
q10	3471	3265	3297	3265
q11	576	478	491	478
q12	785	613	613	613
q13	15996	3230	3158	3158
q14	319	271	294	271
q15	517	498	503	498
q16	493	496	452	452
q17	2004	1526	1543	1526
q18	7965	7945	7865	7865
q19	1737	1626	1545	1545
q20	2177	1904	1895	1895
q21	6273	5246	5368	5246
q22	1119	1032	1024	1024
Total cold run time: 73073 ms
Total hot run time: 56041 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 39886 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 90cfcd4fd3334347544f6c9cf5a23e66c0a574a9, data reload: false

------ Round 1 ----------------------------------
q1	17631	4469	4381	4381
q2	2033	179	173	173
q3	10505	1261	1099	1099
q4	10148	759	745	745
q5	7501	2586	2604	2586
q6	230	143	140	140
q7	978	594	586	586
q8	9307	1938	1918	1918
q9	8725	6620	6640	6620
q10	7083	2184	2150	2150
q11	471	237	245	237
q12	492	228	216	216
q13	17765	2991	3027	2991
q14	282	247	235	235
q15	526	484	485	484
q16	513	386	387	386
q17	975	640	756	640
q18	8026	7559	7471	7471
q19	1385	1041	1026	1026
q20	657	333	336	333
q21	5252	4618	4463	4463
q22	1121	1020	1006	1006
Total cold run time: 111606 ms
Total hot run time: 39886 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4393	4338	4385	4338
q2	397	282	265	265
q3	2879	2665	2608	2608
q4	1890	1645	1599	1599
q5	5340	5314	5351	5314
q6	223	132	133	132
q7	2014	1665	1665	1665
q8	3168	3361	3370	3361
q9	8452	8436	8422	8422
q10	3431	3247	3187	3187
q11	593	499	503	499
q12	781	610	604	604
q13	17498	2975	2998	2975
q14	311	279	276	276
q15	519	479	485	479
q16	476	432	409	409
q17	1793	1484	1507	1484
q18	7690	7420	7403	7403
q19	2037	1568	1651	1568
q20	1983	1788	1801	1788
q21	5333	5097	5229	5097
q22	1110	1057	989	989
Total cold run time: 72311 ms
Total hot run time: 54462 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 202936 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 90cfcd4fd3334347544f6c9cf5a23e66c0a574a9, data reload: false

query1	961	412	396	396
query2	6472	2026	1945	1945
query3	6649	213	215	213
query4	34190	23208	23411	23208
query5	4195	492	510	492
query6	278	184	177	177
query7	4586	304	311	304
query8	252	195	193	193
query9	8476	2382	2352	2352
query10	937	921	936	921
query11	15792	15038	14969	14969
query12	138	96	93	93
query13	1628	383	362	362
query14	10533	7976	7889	7889
query15	420	342	324	324
query16	7777	504	508	504
query17	1722	550	530	530
query18	2047	385	361	361
query19	255	202	213	202
query20	114	103	107	103
query21	208	104	108	104
query22	4407	3991	4052	3991
query23	34261	33127	33160	33127
query24	11157	2926	2903	2903
query25	566	386	363	363
query26	692	150	149	149
query27	2200	280	275	275
query28	6011	2009	2001	2001
query29	791	410	407	407
query30	310	149	147	147
query31	990	743	748	743
query32	95	53	56	53
query33	721	282	281	281
query34	913	472	474	472
query35	987	876	879	876
query36	1095	928	920	920
query37	135	76	77	76
query38	4157	4043	4145	4043
query39	1421	1375	1371	1371
query40	198	114	112	112
query41	47	45	43	43
query42	113	96	96	96
query43	533	493	470	470
query44	1193	744	756	744
query45	405	381	350	350
query46	1113	791	787	787
query47	1848	1760	1793	1760
query48	373	301	305	301
query49	1021	414	414	414
query50	806	435	429	429
query51	6883	6757	6686	6686
query52	97	97	90	90
query53	256	185	176	176
query54	919	447	443	443
query55	79	76	78	76
query56	287	253	247	247
query57	1129	1061	1068	1061
query58	237	222	257	222
query59	3240	2794	2898	2794
query60	303	265	259	259
query61	97	90	95	90
query62	805	670	647	647
query63	205	180	178	178
query64	9387	2397	1938	1938
query65	3183	3137	3167	3137
query66	737	335	338	335
query67	15660	14824	15021	14824
query68	4588	533	551	533
query69	433	358	380	358
query70	1181	1072	1018	1018
query71	380	275	268	268
query72	17889	16698	16638	16638
query73	769	325	323	323
query74	9088	8764	8787	8764
query75	3391	2664	2698	2664
query76	2624	1021	936	936
query77	690	310	312	310
query78	10118	9120	8973	8973
query79	2109	515	520	515
query80	2076	557	477	477
query81	596	230	231	230
query82	796	141	131	131
query83	295	151	147	147
query84	262	83	82	82
query85	2075	317	305	305
query86	467	297	313	297
query87	4675	4406	4547	4406
query88	3884	2480	2493	2480
query89	392	286	287	286
query90	1870	199	194	194
query91	140	124	123	123
query92	58	49	51	49
query93	2317	541	533	533
query94	776	305	301	301
query95	407	258	256	256
query96	618	274	281	274
query97	3210	3087	3068	3068
query98	214	200	190	190
query99	1555	1280	1258	1258
Total cold run time: 309636 ms
Total hot run time: 202936 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.11 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 90cfcd4fd3334347544f6c9cf5a23e66c0a574a9, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.08	0.08
query5	0.50	0.48	0.48
query6	1.13	0.74	0.72
query7	0.03	0.02	0.01
query8	0.05	0.05	0.04
query9	0.56	0.49	0.50
query10	0.55	0.55	0.54
query11	0.16	0.12	0.11
query12	0.15	0.13	0.12
query13	0.60	0.60	0.59
query14	0.77	0.77	0.80
query15	0.88	0.82	0.82
query16	0.37	0.38	0.35
query17	0.99	1.04	0.99
query18	0.24	0.21	0.21
query19	1.77	1.82	1.80
query20	0.01	0.02	0.01
query21	15.40	0.75	0.66
query22	4.22	6.51	2.34
query23	18.28	1.37	1.23
query24	2.18	0.22	0.22
query25	0.13	0.08	0.08
query26	0.30	0.21	0.21
query27	0.46	0.22	0.22
query28	13.22	1.00	0.99
query29	12.62	3.32	3.27
query30	0.23	0.06	0.06
query31	2.87	0.40	0.39
query32	3.26	0.47	0.47
query33	2.88	3.02	2.88
query34	17.00	4.36	4.38
query35	4.48	4.40	4.44
query36	0.65	0.48	0.48
query37	0.19	0.16	0.15
query38	0.16	0.16	0.15
query39	0.05	0.04	0.03
query40	0.15	0.12	0.12
query41	0.09	0.06	0.06
query42	0.05	0.05	0.04
query43	0.05	0.04	0.05
Total cold run time: 109.7 s
Total hot run time: 31.11 s

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run cloud_p0

@hello-stephen
Copy link
Contributor

run compile

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 205c63209b8438226d94536be2d9593c1d8af6be, data reload: false

------ Round 1 ----------------------------------
q1	17871	4396	4324	4324
q2	2054	214	237	214
q3	11616	1113	1158	1113
q4	10540	719	826	719
q5	7799	2848	2827	2827
q6	263	156	152	152
q7	994	641	636	636
q8	9434	2091	2087	2087
q9	7264	6559	6553	6553
q10	7084	2218	2204	2204
q11	473	276	278	276
q12	421	255	248	248
q13	17794	3030	3016	3016
q14	305	262	251	251
q15	572	533	528	528
q16	527	422	415	415
q17	983	639	732	639
q18	7466	6835	6688	6688
q19	6077	1136	1100	1100
q20	671	371	366	366
q21	3851	2853	2894	2853
q22	1130	1032	1017	1017
Total cold run time: 115189 ms
Total hot run time: 38226 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4500	4304	4287	4287
q2	420	322	315	315
q3	2863	2648	2634	2634
q4	1952	1759	1675	1675
q5	5671	5710	5732	5710
q6	238	142	140	140
q7	2183	1770	1796	1770
q8	3314	3441	3441	3441
q9	8765	8734	8706	8706
q10	3515	3308	3358	3308
q11	618	535	527	527
q12	828	657	642	642
q13	17210	3134	3178	3134
q14	311	306	290	290
q15	559	504	513	504
q16	515	452	456	452
q17	1839	1562	1535	1535
q18	8291	7883	7756	7756
q19	9042	1715	1583	1583
q20	2111	1899	1920	1899
q21	13932	5240	5380	5240
q22	1148	1055	1055	1055
Total cold run time: 89825 ms
Total hot run time: 56603 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195239 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 205c63209b8438226d94536be2d9593c1d8af6be, data reload: false

query1	1305	908	896	896
query2	6562	1955	1951	1951
query3	10646	3961	3730	3730
query4	57406	24160	23346	23346
query5	6350	650	644	644
query6	550	189	211	189
query7	6414	328	324	324
query8	522	423	417	417
query9	9363	2513	2482	2482
query10	550	303	317	303
query11	15957	14905	15019	14905
query12	180	126	130	126
query13	1666	427	427	427
query14	12161	6922	6546	6546
query15	288	187	198	187
query16	7477	516	550	516
query17	1155	605	624	605
query18	1996	345	345	345
query19	296	171	165	165
query20	146	135	135	135
query21	287	143	138	138
query22	4769	4457	4640	4457
query23	34404	33808	33910	33808
query24	5627	2911	2928	2911
query25	581	430	439	430
query26	710	188	186	186
query27	1733	303	310	303
query28	3704	2191	2160	2160
query29	709	461	450	450
query30	247	191	184	184
query31	1014	861	836	836
query32	101	77	83	77
query33	547	345	345	345
query34	956	493	487	487
query35	874	752	732	732
query36	1111	989	983	983
query37	150	101	103	101
query38	3945	3798	3844	3798
query39	1505	1471	1459	1459
query40	243	154	150	150
query41	135	130	131	130
query42	133	114	114	114
query43	552	508	497	497
query44	1134	780	777	777
query45	220	189	193	189
query46	1125	786	752	752
query47	1953	1844	1846	1844
query48	407	332	326	326
query49	905	579	598	579
query50	856	454	454	454
query51	6864	6795	6746	6746
query52	124	107	111	107
query53	297	223	220	220
query54	609	493	498	493
query55	94	91	87	87
query56	328	305	300	300
query57	1205	1132	1158	1132
query58	299	302	305	302
query59	2946	2700	2703	2700
query60	362	330	322	322
query61	145	148	147	147
query62	805	706	697	697
query63	261	227	221	221
query64	3332	1928	1805	1805
query65	3275	3168	3174	3168
query66	1050	673	656	656
query67	15406	15085	15060	15060
query68	5062	567	592	567
query69	483	308	301	301
query70	1207	1132	1100	1100
query71	504	318	321	318
query72	6633	2404	2138	2138
query73	806	354	355	354
query74	9299	8860	8888	8860
query75	3488	2767	2802	2767
query76	2774	1094	993	993
query77	689	438	436	436
query78	11225	9711	9102	9102
query79	7538	565	576	565
query80	2813	619	626	619
query81	608	259	265	259
query82	1247	161	156	156
query83	379	212	212	212
query84	285	97	98	97
query85	1074	373	360	360
query86	506	337	329	329
query87	4496	4257	4208	4208
query88	5141	2486	2507	2486
query89	445	331	333	331
query90	2133	233	233	233
query91	153	126	125	125
query92	95	76	78	76
query93	5690	559	555	555
query94	989	298	332	298
query95	393	302	303	302
query96	645	297	288	288
query97	3222	3173	3175	3173
query98	254	233	231	231
query99	1824	1342	1341	1341
Total cold run time: 331129 ms
Total hot run time: 195239 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 205c63209b8438226d94536be2d9593c1d8af6be, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.05	0.05
query3	0.22	0.07	0.06
query4	1.65	0.08	0.09
query5	0.53	0.50	0.49
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.06	0.04	0.05
query9	0.55	0.48	0.49
query10	0.55	0.54	0.55
query11	0.15	0.13	0.13
query12	0.16	0.13	0.13
query13	0.62	0.61	0.59
query14	0.77	0.80	0.78
query15	0.85	0.83	0.84
query16	0.37	0.36	0.37
query17	1.02	1.01	0.99
query18	0.25	0.23	0.24
query19	1.76	1.79	1.75
query20	0.02	0.02	0.01
query21	15.40	0.85	0.66
query22	4.20	7.78	1.26
query23	18.29	1.36	1.25
query24	2.13	0.22	0.23
query25	0.15	0.10	0.08
query26	0.31	0.22	0.23
query27	0.46	0.24	0.23
query28	13.27	1.03	1.02
query29	12.66	3.32	3.31
query30	0.38	0.24	0.24
query31	2.81	0.42	0.40
query32	3.23	0.50	0.50
query33	2.90	2.98	2.96
query34	17.16	4.37	4.39
query35	4.43	4.42	4.38
query36	0.67	0.48	0.49
query37	0.21	0.17	0.17
query38	0.17	0.17	0.18
query39	0.06	0.06	0.05
query40	0.20	0.15	0.15
query41	0.12	0.07	0.07
query42	0.08	0.07	0.08
query43	0.07	0.07	0.07
Total cold run time: 110.19 s
Total hot run time: 30.66 s

@amorynan
Copy link
Contributor Author

run p0

@eldenmoon eldenmoon merged commit 777dbfb into apache:master Aug 16, 2024
@eldenmoon eldenmoon removed the doing label Aug 16, 2024
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
…ure from string to json type (#37278)

change explode-json-array-xx func signature from string to json type to
improve function behavior
@xiaokang
Copy link
Contributor

xiaokang commented Sep 1, 2024

behavior change is fixed by #39572

@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants